Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-25 03:05:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1555044 - Update Onboarding's Sync screen text; r=petru

Browse Source 
Because the news strings are unused we need to add them in lint.xml as UnusedResources.
The suppress will be removed it in a future patch.

Differential Revision: https://phabricator.services.mozilla.com/D32979

--HG--
extra : moz-landing-system : lando
This commit is contained in:
diana.iacos 2019-05-29 10:55:32 +00:00
parent 2ea3454f1e
commit 8710fd9939
3 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mobile/android/app/lint.xml
View File

@ -242,6 +242,7 @@
preprocessed_resources res/raw folder. Lint reports it as unused. We should get
rid of the file eventually. See bug 1268948. -->
<ignore path="**/raw/.mkdir.done" />
<ignore regexp="updatednewfirstrun_sync_subtext|updatednewfirstrun_signin_button" />
</issue>
<issue id="Usability" severity="error" />
<issue id="UseCheckPermission" severity="error" />

2
mobile/android/base/locales/en-US/android_strings.dtd
View File

@ -24,9 +24,11 @@
<!ENTITY firstrun_sync_message2 "Pick up where you left off.">
<!ENTITY firstrun_sync_subtext2 "Use Sync to find the bookmarks, passwords, and other things you save to &brandShortName; on all your devices.">
<!ENTITY newfirstrun_sync_subtext "Sync the things you save on mobile to Firefox for desktop, privately and securely.">
<!ENTITY updatednewfirstrun_sync_subtext "Sign in to your account to get the most out of &brandShortName;">
<!ENTITY firstrun_signin_message "Get connected, get started">
<!ENTITY firstrun_signin_button "Sign in to Sync">
<!ENTITY newfirstrun_signin_button "Turn on Sync">
<!ENTITY updatednewfirstrun_signin_button "Sign in to &brandShortName;">
<!ENTITY onboard_start_button_browser "Start Browsing">
<!ENTITY firstrun_button_notnow "Not right now">
<!ENTITY firstrun_button_next "Next">

2
mobile/android/base/strings.xml.in
View File

@ -43,8 +43,10 @@
<string name="firstrun_sync_message">&firstrun_sync_message2;</string>
<string name="firstrun_sync_subtext">&firstrun_sync_subtext2;</string>
<string name="newfirstrun_sync_subtext">&newfirstrun_sync_subtext;</string>
<string name="updatednewfirstrun_sync_subtext">&updatednewfirstrun_sync_subtext;</string>
<string name="firstrun_signin_button">&firstrun_signin_button;</string>
<string name="newfirstrun_signin_button">&newfirstrun_signin_button;</string>
<string name="updatednewfirstrun_signin_button">&updatednewfirstrun_signin_button;</string>
<string name="firstrun_welcome_button_browser">&onboard_start_button_browser;</string>
<string name="firstrun_button_next">&firstrun_button_next;</string>