Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 17:23:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1485293 - Make test_resizers_resizing_elements.html allow 2px difference of the result r=m_kato

Browse Source 
Oddly, on Android, size of resized objects may be 2px different from ideal
value.  I don't know the reason, could be zoom level or something is affected.
However, fortunately, this difference is not important for this test because
this test checks whether resizers actually works with specific elements.
So, even if the result is 2px smaller or bigger than ideal value, we succeeded
to check the resizer makes the element bigger or smaller as expected.

Therefore, this patch makes the test allow 2px differences of the result.

Additionally, on Android, this test is always timed out if TV (even opt build).
So, this patch disables TV on Android.

Differential Revision: https://phabricator.services.mozilla.com/D4058

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Masayuki Nakano 2018-08-24 08:13:07 +00:00
parent 5eecd79002
commit 8799893651
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
editor/libeditor/tests/mochitest.ini
View File

@ -295,7 +295,7 @@ skip-if = toolkit == 'android' && debug # bug 1480702, causes permanent failure
[test_nsITableEditor_getTableSize.html]
[test_resizers_appearance.html]
[test_resizers_resizing_elements.html]
skip-if = android_version == '18' || (verify && debug && os == 'win') # bug 1147989
skip-if = toolkit == 'android' || (verify && debug && os == 'win') # bug 1147989 and bug 1485293
[test_root_element_replacement.html]
[test_select_all_without_body.html]
[test_spellcheck_pref.html]

8
editor/libeditor/tests/test_resizers_resizing_elements.html
View File

@ -76,6 +76,7 @@ SimpleTest.waitForFocus(async function() {
is(rect.height, 150, description + "Sanity check the height");
// Click on the target to show the resizers
ok(true, "waiting selectionchange to select the target element");
let promiseSelectionChangeEvent = waitForSelectionChange();
synthesizeMouseAtCenter(target, {});
await promiseSelectionChangeEvent;
@ -97,9 +98,12 @@ SimpleTest.waitForFocus(async function() {
synthesizeMouseAtCenter(outOfEditor, {});
// Get the new dimensions for the target
// XXX I don't know why we need 2px margin to check this on Android.
// Fortunately, this test checks whether objects are resizable
// actually. So, bigger difference is okay.
let newRect = target.getBoundingClientRect();
isfuzzy(newRect.width, rect.width + expectedDeltaX, 1, description + "The width should be increased by " + expectedDeltaX + " pixels");
isfuzzy(newRect.height, rect.height + expectedDeltaY, 1, description + "The height should be increased by " + expectedDeltaY + "pixels");
isfuzzy(newRect.width, rect.width + expectedDeltaX, 2, description + "The width should be increased by " + expectedDeltaX + " pixels");
isfuzzy(newRect.height, rect.height + expectedDeltaY, 2, description + "The height should be increased by " + expectedDeltaY + "pixels");
}
// Account for changes in the resizing behavior when we're trying to preserve