Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-13 11:38:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix for bug 49533. The test case was incorrect but we were not returning a meaningful error. Also the install.log was being filled with junk. r=ssu

Browse Source
This commit is contained in:
dbragg%netscape.com 2000-09-05 18:17:52 +00:00
parent a91867a028
commit 87aff23753
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
xpinstall/src/nsInstallFileOpItem.cpp
View File

@ -285,7 +285,7 @@ char* nsInstallFileOpItem::toString()
char* dstPath;
// STRING USE WARNING: perhaps |result| should be an |nsCAutoString| to avoid all this double converting
*resultCString = nsnull;
switch(mCommand)
{
case NS_FOP_FILE_COPY:
@ -632,7 +632,10 @@ nsInstallFileOpItem::NativeFileOpFileRenamePrepare()
mSrc->GetParent(&target);
nsAutoCString tempTargetString(*mStrTarget);
target->Append(tempTargetString);
nsresult rv = target->Append(tempTargetString);
//90% of the failures during Append will be because the target wasn't in string form
// which it must be.
if (NS_FAILED(rv)) return nsInstall::INVALID_ARGUMENTS;
target->Exists(&flagExists);
if(flagExists)