Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-19 09:30:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug #368869, suspect all native wrappers as cycle roots (yet again, after Igor's change to js gc).r=brendan, sr=jst

Browse Source
This commit is contained in:
graydon@mozilla.com 2007-06-05 16:50:22 -07:00
parent 019810ad4f
commit 87f15ddb10
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
js/src/xpconnect/src/xpcwrappednativescope.cpp
View File

@ -272,13 +272,8 @@ WrappedNativeJSGCThingTracer(JSDHashTable *table, JSDHashEntryHdr *hdr,
JS_CALL_OBJECT_TRACER(trc, wrapper->GetFlatJSObject(),
"XPCWrappedNative::mFlatJSObject");
// FIXME: this call appears to do more harm than good, but
// there is reason to imagine it might clean up some cycles
// formed by a poor order between C++ and JS garbage cycle
// formations. See Bug 368869.
//
// if (JS_IsGCMarkingTracer(trc))
// nsCycleCollector_suspectCurrent(wrapper);
if (JS_IsGCMarkingTracer(trc))
nsCycleCollector_suspectCurrent(wrapper);
}
return JS_DHASH_NEXT;
}