Bug 356328: $rankdir should be validated in showdependencygraph.cgi - Patch by Fr�d�ric Buclin <LpSolit@gmail.com> r=bkor a=myk

This commit is contained in:
lpsolit%gmail.com 2006-10-20 23:21:08 +00:00
parent 612de57f54
commit 88e9f40af8

View File

@ -96,7 +96,16 @@ sub AddLink {
}
}
# The list of valid directions. Some are not proposed in the dropdrown
# menu despite they are valid ones.
my @valid_rankdirs = ('LR', 'RL', 'TB', 'BT');
my $rankdir = $cgi->param('rankdir') || "LR";
# Make sure the submitted 'rankdir' value is valid.
if (lsearch(\@valid_rankdirs, $rankdir) < 0) {
$rankdir = 'LR';
}
my $webdotdir = bz_locations()->{'webdotdir'};
if (!defined $cgi->param('id') && !defined $cgi->param('doall')) {