diff --git a/camino/PreferencePanes/Appearance/Appearance.mm b/camino/PreferencePanes/Appearance/Appearance.mm index 378036667f7e..73d7be37ce7c 100644 --- a/camino/PreferencePanes/Appearance/Appearance.mm +++ b/camino/PreferencePanes/Appearance/Appearance.mm @@ -625,7 +625,7 @@ const int kDefaultFontSansSerifTag = 1; for (unsigned int i = 0; i < [regionMappingTable count]; i++) { NSMutableDictionary* regionDict = [regionMappingTable objectAtIndex:i]; - NSString* regionCode = [regionDict objectForKey:@"code"]; + // NSString* regionCode = [regionDict objectForKey:@"code"]; // for each region, we reset the dictionaries to be empty. [regionDict setObject:[NSMutableDictionary dictionary] forKey:@"serif"]; @@ -647,7 +647,6 @@ const int kDefaultFontSansSerifTag = 1; // Update the UI of the Appearance pane // order is important here -- syncing the font panel depends on the font previews being correct. [self updateFontPreviews]; - [self syncFontPanel]; } - (void)advancedFontsSheetDidEnd:(NSWindow *)sheet returnCode:(int)returnCode contextInfo:(void *)contextInfo diff --git a/camino/PreferencePanes/Privacy/PrivacyPane.mm b/camino/PreferencePanes/Privacy/PrivacyPane.mm index d194b8115c4f..29a2306efbfa 100644 --- a/camino/PreferencePanes/Privacy/PrivacyPane.mm +++ b/camino/PreferencePanes/Privacy/PrivacyPane.mm @@ -321,7 +321,7 @@ PR_STATIC_CALLBACK(int) compareValues(nsICookie* aCookie1, nsICookie* aCookie2, NSArray *rows = [[mCookiesTable selectedRowEnumerator] allObjects]; NSEnumerator *e = [rows reverseObjectEnumerator]; NSNumber *index; - while (index = [e nextObject]) + while ((index = [e nextObject])) { int row = [index intValue]; nsCAutoString host, name, path; @@ -436,7 +436,7 @@ PR_STATIC_CALLBACK(int) compareValues(nsICookie* aCookie1, nsICookie* aCookie2, NSArray *rows = [[mPermissionsTable selectedRowEnumerator] allObjects]; NSEnumerator *e = [rows reverseObjectEnumerator]; NSNumber *index; - while (index = [e nextObject]) { + while ((index = [e nextObject])) { int row = [index intValue]; nsCAutoString host; mCachedPermissions->ObjectAt(row)->GetHost(host); @@ -665,7 +665,7 @@ PR_STATIC_CALLBACK(int) compareValues(nsICookie* aCookie1, nsICookie* aCookie2, nsCOMArray selectedItems; NSEnumerator *e = [mPermissionsTable selectedRowEnumerator]; NSNumber *index; - while (index = [e nextObject]) { + while ((index = [e nextObject])) { int row = [index intValue]; selectedItems.AppendObject(mCachedPermissions->ObjectAt(row)); } @@ -689,7 +689,7 @@ PR_STATIC_CALLBACK(int) compareValues(nsICookie* aCookie1, nsICookie* aCookie2, nsCOMArray selectedItems; NSEnumerator *e = [mCookiesTable selectedRowEnumerator]; NSNumber *index; - while (index = [e nextObject]) { + while ((index = [e nextObject])) { int row = [index intValue]; selectedItems.AppendObject(mCachedCookies->ObjectAt(row)); }