Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 22:01:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make ReplaceObjectAt a little safer. Bug 227780, r=timeless, sr=alecf

Browse Source
This commit is contained in:
bzbarsky%mit.edu 2005-11-02 16:05:18 +00:00
parent 7550832d25
commit 8a516c2bc7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
xpcom/glue/nsCOMArray.cpp
View File

@ -115,8 +115,9 @@ nsCOMArray_base::ReplaceObjectAt(nsISupports* aObject, PRInt32 aIndex)
// ReplaceElementAt could fail, such as if the array grows
// so only release the existing object if the replacement succeeded
if (result) {
NS_IF_RELEASE(oldObject);
// Make sure to addref first, in case aObject == oldObject
NS_IF_ADDREF(aObject);
NS_IF_RELEASE(oldObject);
}
return result;
}