Bug 1613985 - Use default for equivalent-to-default constructors/destructors in layout. r=dholbert

Differential Revision: https://phabricator.services.mozilla.com/D66016

--HG--
extra : moz-landing-system : lando

layout/base/AccessibleCaret.h

@@ -191,7 +191,7 @@ class AccessibleCaret {
     }
 
    private:
-    virtual ~DummyTouchListener(){};
+    virtual ~DummyTouchListener() = default;
   };
 
   // Member variables

layout/base/FrameProperties.h

@@ -137,7 +137,7 @@ class FrameProperties {
   template <typename T>
   using PropertyType = typename detail::FramePropertyTypeHelper<T>::Type;
 
-  explicit FrameProperties() {}
+  explicit FrameProperties() = default;
 
   ~FrameProperties() {
     MOZ_ASSERT(mProperties.Length() == 0, "forgot to delete properties");

layout/base/MobileViewportManager.cpp

@@ -46,7 +46,7 @@ MobileViewportManager::MobileViewportManager(MVMContext* aContext)
   mContext->AddObserver(this, BEFORE_FIRST_PAINT.Data(), false);
 }
 
-MobileViewportManager::~MobileViewportManager() {}
+MobileViewportManager::~MobileViewportManager() = default;
 
 void MobileViewportManager::Destroy() {
   MVM_LOG("%p: destroying\n", this);

layout/base/PresShell.cpp

@@ -333,7 +333,7 @@ class IndiReflowCounter {
         mMgr(aMgr),
         mCounter(aMgr),
         mHasBeenOutput(false) {}
-  virtual ~IndiReflowCounter() {}
+  virtual ~IndiReflowCounter() = default;
 
   nsAutoString mName;
   nsIFrame* mFrame;  // weak reference (don't delete)
@@ -10078,7 +10078,7 @@ ReflowCounter::ReflowCounter(ReflowCountMgr* aMgr) : mMgr(aMgr) {
 }
 
 //------------------------------------------------------------------
-ReflowCounter::~ReflowCounter() {}
+ReflowCounter::~ReflowCounter() = default;
 
 //------------------------------------------------------------------
 void ReflowCounter::ClearTotals() { mTotal = 0; }
@@ -10154,7 +10154,7 @@ ReflowCountMgr::ReflowCountMgr() : mCounts(10), mIndiFrameCounts(10) {
 }
 
 //------------------------------------------------------------------
-ReflowCountMgr::~ReflowCountMgr() {}
+ReflowCountMgr::~ReflowCountMgr() = default;
 
 //------------------------------------------------------------------
 ReflowCounter* ReflowCountMgr::LookUp(const char* aName) {

layout/base/PresShell.h

@@ -1909,7 +1909,7 @@ class PresShell final : public nsStubDocumentObserver,
 
   class DelayedEvent {
    public:
-    virtual ~DelayedEvent() {}
+    virtual ~DelayedEvent() = default;
     virtual void Dispatch() {}
     virtual bool IsKeyPressEvent() { return false; }
   };

layout/base/StackArena.cpp

@@ -23,7 +23,7 @@ struct StackBlock {
   StackBlock* mNext;
 
   StackBlock() : mNext(nullptr) {}
-  ~StackBlock() {}
+  ~StackBlock() = default;
 };
 
 static_assert(sizeof(StackBlock) == 4096, "StackBlock must be 4096 bytes");

layout/base/ZoomConstraintsClient.cpp

@@ -42,7 +42,7 @@ using namespace mozilla::layers;
 ZoomConstraintsClient::ZoomConstraintsClient()
     : mDocument(nullptr), mPresShell(nullptr) {}
 
-ZoomConstraintsClient::~ZoomConstraintsClient() {}
+ZoomConstraintsClient::~ZoomConstraintsClient() = default;
 
 static nsIWidget* GetWidget(PresShell* aPresShell) {
   if (!aPresShell) {

layout/base/nsBidiPresUtils.h

@@ -149,7 +149,7 @@ class nsBidiPresUtils {
    */
   class BidiProcessor {
    public:
-    virtual ~BidiProcessor() {}
+    virtual ~BidiProcessor() = default;
 
     /**
      * Sets the current text with the given length and the given direction.

layout/base/nsCSSFrameConstructor.h

@@ -872,8 +872,7 @@ class nsCSSFrameConstructor final : public nsFrameManager {
      public:
       explicit Iterator(FrameConstructionItemList& aList)
           : mCurrent(aList.mItems.getFirst()), mList(aList) {}
-      Iterator(const Iterator& aOther)
+      Iterator(const Iterator& aOther) = default;
-          : mCurrent(aOther.mCurrent), mList(aOther.mList) {}
 
       bool operator==(const Iterator& aOther) const {
         MOZ_ASSERT(&mList == &aOther.mList, "Iterators for different lists?");

layout/base/nsFrameTraversal.cpp

@@ -34,7 +34,7 @@ class nsFrameIterator : public nsIFrameEnumerator {
                   bool aSkipPopupChecks);
 
  protected:
-  virtual ~nsFrameIterator() {}
+  virtual ~nsFrameIterator() = default;
 
   void setCurrent(nsIFrame* aFrame) { mCurrent = aFrame; }
   nsIFrame* getCurrent() { return mCurrent; }
@@ -156,9 +156,9 @@ nsresult NS_NewFrameTraversal(nsIFrameEnumerator** aEnumerator,
   return NS_OK;
 }
 
-nsFrameTraversal::nsFrameTraversal() {}
+nsFrameTraversal::nsFrameTraversal() = default;
 
-nsFrameTraversal::~nsFrameTraversal() {}
+nsFrameTraversal::~nsFrameTraversal() = default;
 
 NS_IMPL_ISUPPORTS(nsFrameTraversal, nsIFrameTraversal)
 

layout/base/nsGenConList.h

@@ -59,7 +59,7 @@ struct nsGenConNode : public mozilla::LinkedListElement<nsGenConNode> {
     return false;
   }
 
-  virtual ~nsGenConNode() {}  // XXX Avoid, perhaps?
+  virtual ~nsGenConNode() = default;  // XXX Avoid, perhaps?
 
  protected:
   void CheckFrameAssertions() {

layout/base/nsLayoutHistoryState.cpp

@@ -27,7 +27,7 @@ class nsLayoutHistoryState final : public nsILayoutHistoryState,
   NS_DECL_NSILAYOUTHISTORYSTATE
 
  private:
-  ~nsLayoutHistoryState() {}
+  ~nsLayoutHistoryState() = default;
   bool mScrollPositionOnly;
 
   nsDataHashtable<nsCStringHashKey, UniquePtr<PresState>> mStates;

layout/base/nsPresContext.cpp

@@ -1704,7 +1704,7 @@ class CounterStyleCleaner final : public nsAPostRefreshObserver {
                       CounterStyleManager* aCounterStyleManager)
       : mRefreshDriver(aRefreshDriver),
         mCounterStyleManager(aCounterStyleManager) {}
-  virtual ~CounterStyleCleaner() {}
+  virtual ~CounterStyleCleaner() = default;
 
   void DidRefresh() final {
     mRefreshDriver->RemovePostRefreshObserver(this);

layout/base/nsRefreshDriver.cpp

@@ -178,7 +178,7 @@ namespace mozilla {
  */
 class RefreshDriverTimer {
  public:
-  RefreshDriverTimer() {}
+  RefreshDriverTimer() = default;
 
   NS_INLINE_DECL_REFCOUNTING(RefreshDriverTimer)
 
@@ -548,7 +548,7 @@ class VsyncRefreshDriverTimer : public RefreshDriverTimer {
       }
 
      private:
-      ~ParentProcessVsyncNotifier() {}
+      ~ParentProcessVsyncNotifier() = default;
       RefPtr<RefreshDriverVsyncObserver> mObserver;
       static mozilla::Atomic<bool> sHighPriorityEnabled;
     };

layout/base/nsRefreshDriver.h

@@ -454,7 +454,7 @@ class nsRefreshDriver final : public mozilla::layers::TransactionIdAllocator,
   typedef nsTArray<RefPtr<VVPScrollEvent>> VisualViewportScrollEventArray;
   typedef nsTHashtable<nsISupportsHashKey> RequestTable;
   struct ImageStartData {
-    ImageStartData() {}
+    ImageStartData() = default;
 
     mozilla::Maybe<mozilla::TimeStamp> mStartTime;
     RequestTable mEntries;

layout/build/nsContentDLF.cpp

@@ -72,9 +72,9 @@ nsresult NS_NewContentDocumentLoaderFactory(
   return NS_OK;
 }
 
-nsContentDLF::nsContentDLF() {}
+nsContentDLF::nsContentDLF() = default;
 
-nsContentDLF::~nsContentDLF() {}
+nsContentDLF::~nsContentDLF() = default;
 
 NS_IMPL_ISUPPORTS(nsContentDLF, nsIDocumentLoaderFactory)
 

layout/forms/nsCheckboxRadioFrame.cpp

@@ -32,7 +32,7 @@ nsCheckboxRadioFrame::nsCheckboxRadioFrame(ComputedStyle* aStyle,
                                            nsPresContext* aPresContext)
     : nsAtomicContainerFrame(aStyle, aPresContext, kClassID) {}
 
-nsCheckboxRadioFrame::~nsCheckboxRadioFrame() {}
+nsCheckboxRadioFrame::~nsCheckboxRadioFrame() = default;
 
 void nsCheckboxRadioFrame::DestroyFrom(nsIFrame* aDestructRoot,
                                        PostDestroyData& aPostDestroyData) {

layout/forms/nsComboboxControlFrame.cpp

@@ -88,7 +88,7 @@ nsComboboxControlFrame::RedisplayTextEvent::Run() {
  */
 class nsComboButtonListener final : public nsIDOMEventListener {
  private:
-  virtual ~nsComboButtonListener() {}
+  virtual ~nsComboButtonListener() = default;
 
  public:
   NS_DECL_ISUPPORTS
@@ -374,7 +374,7 @@ class nsResizeDropdownAtFinalPosition final : public nsIReflowCallback,
       : mozilla::Runnable("nsResizeDropdownAtFinalPosition"), mFrame(aFrame) {}
 
  protected:
-  ~nsResizeDropdownAtFinalPosition() {}
+  ~nsResizeDropdownAtFinalPosition() = default;
 
  public:
   virtual bool ReflowFinished() override {

layout/forms/nsFileControlFrame.h

@@ -85,7 +85,7 @@ class nsFileControlFrame final : public nsBlockFrame,
     void ForgetFrame() { mFrame = nullptr; }
 
    protected:
-    virtual ~MouseListener() {}
+    virtual ~MouseListener() = default;
 
     nsFileControlFrame* mFrame;
   };

layout/forms/nsHTMLButtonControlFrame.cpp

@@ -34,7 +34,7 @@ nsHTMLButtonControlFrame::nsHTMLButtonControlFrame(ComputedStyle* aStyle,
                                                    nsIFrame::ClassID aID)
     : nsContainerFrame(aStyle, aPresContext, aID) {}
 
-nsHTMLButtonControlFrame::~nsHTMLButtonControlFrame() {}
+nsHTMLButtonControlFrame::~nsHTMLButtonControlFrame() = default;
 
 void nsHTMLButtonControlFrame::DestroyFrom(nsIFrame* aDestructRoot,
                                            PostDestroyData& aPostDestroyData) {

layout/forms/nsImageControlFrame.cpp

@@ -58,7 +58,7 @@ nsImageControlFrame::nsImageControlFrame(ComputedStyle* aStyle,
                                          nsPresContext* aPresContext)
     : nsImageFrame(aStyle, aPresContext, kClassID) {}
 
-nsImageControlFrame::~nsImageControlFrame() {}
+nsImageControlFrame::~nsImageControlFrame() = default;
 
 void nsImageControlFrame::DestroyFrom(nsIFrame* aDestructRoot,
                                       PostDestroyData& aPostDestroyData) {

layout/forms/nsListControlFrame.cpp

@@ -74,7 +74,7 @@ class nsListEventListener final : public nsIDOMEventListener {
   NS_IMETHOD HandleEvent(Event* aEvent) override;
 
  private:
-  ~nsListEventListener() {}
+  ~nsListEventListener() = default;
 
   nsListControlFrame* mFrame;
 };

layout/forms/nsMeterFrame.cpp

@@ -36,7 +36,7 @@ NS_IMPL_FRAMEARENA_HELPERS(nsMeterFrame)
 nsMeterFrame::nsMeterFrame(ComputedStyle* aStyle, nsPresContext* aPresContext)
     : nsContainerFrame(aStyle, aPresContext, kClassID), mBarDiv(nullptr) {}
 
-nsMeterFrame::~nsMeterFrame() {}
+nsMeterFrame::~nsMeterFrame() = default;
 
 void nsMeterFrame::DestroyFrom(nsIFrame* aDestructRoot,
                                PostDestroyData& aPostDestroyData) {

layout/forms/nsProgressFrame.cpp

@@ -35,7 +35,7 @@ nsProgressFrame::nsProgressFrame(ComputedStyle* aStyle,
                                  nsPresContext* aPresContext)
     : nsContainerFrame(aStyle, aPresContext, kClassID), mBarDiv(nullptr) {}
 
-nsProgressFrame::~nsProgressFrame() {}
+nsProgressFrame::~nsProgressFrame() = default;
 
 void nsProgressFrame::DestroyFrom(nsIFrame* aDestructRoot,
                                   PostDestroyData& aPostDestroyData) {

layout/forms/nsRangeFrame.cpp

@@ -48,7 +48,7 @@ nsIFrame* NS_NewRangeFrame(PresShell* aPresShell, ComputedStyle* aStyle) {
 nsRangeFrame::nsRangeFrame(ComputedStyle* aStyle, nsPresContext* aPresContext)
     : nsContainerFrame(aStyle, aPresContext, kClassID) {}
 
-nsRangeFrame::~nsRangeFrame() {}
+nsRangeFrame::~nsRangeFrame() = default;
 
 NS_IMPL_FRAMEARENA_HELPERS(nsRangeFrame)
 

layout/forms/nsRangeFrame.h

@@ -187,7 +187,7 @@ class nsRangeFrame final : public nsContainerFrame,
 
   class DummyTouchListener final : public nsIDOMEventListener {
    private:
-    ~DummyTouchListener() {}
+    ~DummyTouchListener() = default;
 
    public:
     NS_DECL_ISUPPORTS

layout/forms/nsSelectsAreaFrame.cpp

@@ -76,7 +76,7 @@ void nsDisplayOptionEventGrabber::HitTest(nsDisplayListBuilder* aBuilder,
 
 class nsOptionEventGrabberWrapper : public nsDisplayWrapper {
  public:
-  nsOptionEventGrabberWrapper() {}
+  nsOptionEventGrabberWrapper() = default;
   virtual nsDisplayItem* WrapList(nsDisplayListBuilder* aBuilder,
                                   nsIFrame* aFrame,
                                   nsDisplayList* aList) override {

layout/forms/nsTextControlFrame.cpp

@@ -103,7 +103,7 @@ class nsTextControlFrame::nsAnonDivObserver final
   NS_DECL_NSIMUTATIONOBSERVER_CONTENTREMOVED
 
  private:
-  ~nsAnonDivObserver() {}
+  ~nsAnonDivObserver() = default;
   nsTextControlFrame& mFrame;
 };
 
@@ -122,7 +122,7 @@ nsTextControlFrame::nsTextControlFrame(ComputedStyle* aStyle,
   ClearCachedValue();
 }
 
-nsTextControlFrame::~nsTextControlFrame() {}
+nsTextControlFrame::~nsTextControlFrame() = default;
 
 nsIScrollableFrame* nsTextControlFrame::GetScrollTargetFrame() {
   if (!mRootNode) {

layout/generic/BRFrame.cpp

@@ -86,7 +86,7 @@ nsIFrame* NS_NewBRFrame(mozilla::PresShell* aPresShell, ComputedStyle* aStyle) {
 
 NS_IMPL_FRAMEARENA_HELPERS(BRFrame)
 
-BRFrame::~BRFrame() {}
+BRFrame::~BRFrame() = default;
 
 void BRFrame::Reflow(nsPresContext* aPresContext, ReflowOutput& aMetrics,
                      const ReflowInput& aReflowInput, nsReflowStatus& aStatus) {

layout/generic/DetailsFrame.cpp

@@ -33,7 +33,7 @@ namespace mozilla {
 DetailsFrame::DetailsFrame(ComputedStyle* aStyle, nsPresContext* aPresContext)
     : nsBlockFrame(aStyle, aPresContext, kClassID) {}
 
-DetailsFrame::~DetailsFrame() {}
+DetailsFrame::~DetailsFrame() = default;
 
 void DetailsFrame::SetInitialChildList(ChildListID aListID,
                                        nsFrameList& aChildList) {

layout/generic/ReflowOutput.h

@@ -132,8 +132,7 @@ struct nsCollapsingMargin {
  public:
   nsCollapsingMargin() : mMostPos(0), mMostNeg(0) {}
 
-  nsCollapsingMargin(const nsCollapsingMargin& aOther)
+  nsCollapsingMargin(const nsCollapsingMargin& aOther) = default;
-      : mMostPos(aOther.mMostPos), mMostNeg(aOther.mMostNeg) {}
 
   bool operator==(const nsCollapsingMargin& aOther) {
     return mMostPos == aOther.mMostPos && mMostNeg == aOther.mMostNeg;
@@ -143,11 +142,7 @@ struct nsCollapsingMargin {
     return !(*this == aOther);
   }
 
-  nsCollapsingMargin& operator=(const nsCollapsingMargin& aOther) {
+  nsCollapsingMargin& operator=(const nsCollapsingMargin& aOther) = default;
-    mMostPos = aOther.mMostPos;
-    mMostNeg = aOther.mMostNeg;
-    return *this;
-  }
 
   void Include(nscoord aCoord) {
     if (aCoord > mMostPos)

layout/generic/ScrollAnchorContainer.cpp

@@ -46,7 +46,7 @@ ScrollAnchorContainer::ScrollAnchorContainer(ScrollFrameHelper* aScrollFrame)
       mApplyingAnchorAdjustment(false),
       mSuppressAnchorAdjustment(false) {}
 
-ScrollAnchorContainer::~ScrollAnchorContainer() {}
+ScrollAnchorContainer::~ScrollAnchorContainer() = default;
 
 ScrollAnchorContainer* ScrollAnchorContainer::FindFor(nsIFrame* aFrame) {
   aFrame = aFrame->GetParent();

layout/generic/ScrollAnimationPhysics.h

@@ -29,7 +29,7 @@ class ScrollAnimationPhysics {
 
   virtual bool IsFinished(const TimeStamp& aTime) = 0;
 
-  virtual ~ScrollAnimationPhysics() {}
+  virtual ~ScrollAnimationPhysics() = default;
 };
 
 // Helper for accelerated wheel deltas. This can be called from the main thread

layout/generic/ScrollbarActivity.h

@@ -97,7 +97,7 @@ class ScrollbarActivity final : public nsIDOMEventListener,
   }
 
  protected:
-  virtual ~ScrollbarActivity() {}
+  virtual ~ScrollbarActivity() = default;
 
   bool IsActivityOngoing() { return mNestedActivityCounter > 0; }
   bool IsStillFading(TimeStamp aTime);

layout/generic/ViewportFrame.h

@@ -34,7 +34,7 @@ class ViewportFrame : public nsContainerFrame {
   explicit ViewportFrame(ComputedStyle* aStyle, nsPresContext* aPresContext)
       : ViewportFrame(aStyle, aPresContext, kClassID) {}
 
-  virtual ~ViewportFrame() {}  // useful for debugging
+  virtual ~ViewportFrame() = default;  // useful for debugging
 
   virtual void Init(nsIContent* aContent, nsContainerFrame* aParent,
                     nsIFrame* aPrevInFlow) override;

layout/generic/nsBlockFrame.cpp

@@ -407,7 +407,7 @@ nsBlockFrame* NS_NewBlockFormattingContext(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsBlockFrame)
 
-nsBlockFrame::~nsBlockFrame() {}
+nsBlockFrame::~nsBlockFrame() = default;
 
 void nsBlockFrame::AddSizeOfExcludingThisForTree(
     nsWindowSizes& aWindowSizes) const {

layout/generic/nsBlockReflowContext.h

@@ -29,7 +29,7 @@ class nsBlockReflowContext {
  public:
   nsBlockReflowContext(nsPresContext* aPresContext,
                        const ReflowInput& aParentRI);
-  ~nsBlockReflowContext() {}
+  ~nsBlockReflowContext() = default;
 
   void ReflowBlock(const mozilla::LogicalRect& aSpace, bool aApplyBStartMargin,
                    nsCollapsingMargin& aPrevMargin, nscoord aClearance,

layout/generic/nsBulletFrame.cpp

@@ -67,7 +67,7 @@ NS_QUERYFRAME_HEAD(nsBulletFrame)
 NS_QUERYFRAME_TAIL_INHERITING(nsFrame)
 #endif
 
-nsBulletFrame::~nsBulletFrame() {}
+nsBulletFrame::~nsBulletFrame() = default;
 
 CounterStyle* nsBulletFrame::ResolveCounterStyle() {
   return PresContext()->CounterStyleManager()->ResolveCounterStyle(
@@ -1319,7 +1319,7 @@ NS_IMPL_ISUPPORTS(nsBulletListener, imgINotificationObserver)
 
 nsBulletListener::nsBulletListener() : mFrame(nullptr) {}
 
-nsBulletListener::~nsBulletListener() {}
+nsBulletListener::~nsBulletListener() = default;
 
 void nsBulletListener::Notify(imgIRequest* aRequest, int32_t aType,
                               const nsIntRect* aData) {

layout/generic/nsContainerFrame.cpp

@@ -43,7 +43,7 @@ using namespace mozilla;
 using namespace mozilla::dom;
 using namespace mozilla::layout;
 
-nsContainerFrame::~nsContainerFrame() {}
+nsContainerFrame::~nsContainerFrame() = default;
 
 NS_QUERYFRAME_HEAD(nsContainerFrame)
   NS_QUERYFRAME_ENTRY(nsContainerFrame)

layout/generic/nsFloatManager.cpp

@@ -503,7 +503,7 @@ bool nsFloatManager::ClearContinues(StyleClear aBreakType) const {
 //
 class nsFloatManager::ShapeInfo {
  public:
-  virtual ~ShapeInfo() {}
+  virtual ~ShapeInfo() = default;
 
   virtual nscoord LineLeft(const nscoord aBStart,
                            const nscoord aBEnd) const = 0;

layout/generic/nsFrame.cpp

@@ -11233,7 +11233,7 @@ void nsIFrame::DoAppendOwnedAnonBoxes(nsTArray<OwnedAnonBox>& aResult) {
 
 nsIFrame::CaretPosition::CaretPosition() : mContentOffset(0) {}
 
-nsIFrame::CaretPosition::~CaretPosition() {}
+nsIFrame::CaretPosition::~CaretPosition() = default;
 
 bool nsFrame::HasCSSAnimations() {
   auto collection =

layout/generic/nsFrameList.h

@@ -80,8 +80,7 @@ class nsFrameList {
     VerifyList();
   }
 
-  nsFrameList(const nsFrameList& aOther)
+  nsFrameList(const nsFrameList& aOther) = default;
-      : mFirstChild(aOther.mFirstChild), mLastChild(aOther.mLastChild) {}
 
   /**
    * Infallibly allocate a nsFrameList from the shell arena.
@@ -359,14 +358,7 @@ class nsFrameList {
           mEnd(aEnd) {
     }
 
-    Slice(const Slice& aOther)
+    Slice(const Slice& aOther) = default;
-        :
-#ifdef DEBUG
-          mList(aOther.mList),
-#endif
-          mStart(aOther.mStart),
-          mEnd(aOther.mEnd) {
-    }
 
    private:
 #ifdef DEBUG
@@ -388,14 +380,7 @@ class nsFrameList {
           mEnd(aSlice.mEnd) {
     }
 
-    Enumerator(const Enumerator& aOther)
+    Enumerator(const Enumerator& aOther) = default;
-        :
-#ifdef DEBUG
-          mSlice(aOther.mSlice),
-#endif
-          mFrame(aOther.mFrame),
-          mEnd(aOther.mEnd) {
-    }
 
     bool AtEnd() const {
       // Can't just check mEnd, because some table code goes and destroys the
@@ -466,8 +451,7 @@ class nsFrameList {
     explicit FrameLinkEnumerator(const nsFrameList& aList)
         : Enumerator(aList), mPrev(nullptr) {}
 
-    FrameLinkEnumerator(const FrameLinkEnumerator& aOther)
+    FrameLinkEnumerator(const FrameLinkEnumerator& aOther) = default;
-        : Enumerator(aOther), mPrev(aOther.mPrev) {}
 
     /* This constructor needs to know about nsIFrame, and nsIFrame will need to
        know about nsFrameList methods, so in order to inline this put
@@ -509,8 +493,7 @@ class nsFrameList {
     Iterator(const nsFrameList& aList, nsIFrame* aCurrent)
         : mList(aList), mCurrent(aCurrent) {}
 
-    Iterator(const Iterator& aOther)
+    Iterator(const Iterator& aOther) = default;
-        : mList(aOther.mList), mCurrent(aOther.mCurrent) {}
 
     nsIFrame* operator*() const { return mCurrent; }
 

layout/generic/nsFrameSelection.cpp

@@ -366,7 +366,7 @@ nsFrameSelection::nsFrameSelection(PresShell* aPresShell, nsIContent* aLimiter,
   }
 }
 
-nsFrameSelection::~nsFrameSelection() {}
+nsFrameSelection::~nsFrameSelection() = default;
 
 NS_IMPL_CYCLE_COLLECTION_CLASS(nsFrameSelection)
 

layout/generic/nsFrameSetFrame.cpp

@@ -182,7 +182,7 @@ nsHTMLFramesetFrame::nsHTMLFramesetFrame(ComputedStyle* aStyle,
   mEdgeColors.Set(NO_COLOR);
 }
 
-nsHTMLFramesetFrame::~nsHTMLFramesetFrame() {}
+nsHTMLFramesetFrame::~nsHTMLFramesetFrame() = default;
 
 NS_QUERYFRAME_HEAD(nsHTMLFramesetFrame)
   NS_QUERYFRAME_ENTRY(nsHTMLFramesetFrame)

layout/generic/nsFrameSetFrame.h

@@ -34,7 +34,7 @@ struct nsBorderColor {
   nscolor mBottom;
 
   nsBorderColor() { Set(NO_COLOR); }
-  ~nsBorderColor() {}
+  ~nsBorderColor() = default;
   void Set(nscolor aColor) { mLeft = mRight = mTop = mBottom = aColor; }
 };
 

layout/generic/nsHTMLCanvasFrame.cpp

@@ -271,7 +271,7 @@ void nsHTMLCanvasFrame::Init(nsIContent* aContent, nsContainerFrame* aParent,
   ActiveLayerTracker::NotifyContentChange(this);
 }
 
-nsHTMLCanvasFrame::~nsHTMLCanvasFrame() {}
+nsHTMLCanvasFrame::~nsHTMLCanvasFrame() = default;
 
 nsIntSize nsHTMLCanvasFrame::GetCanvasSize() {
   nsIntSize size(0, 0);

layout/generic/nsILineIterator.h

@@ -25,7 +25,7 @@ struct nsRect;
  */
 class nsILineIterator {
  protected:
-  ~nsILineIterator() {}
+  ~nsILineIterator() = default;
 
  public:
   virtual void DisposeLineIterator() = 0;

layout/generic/nsImageFrame.cpp

@@ -224,7 +224,7 @@ nsImageFrame::nsImageFrame(ComputedStyle* aStyle, nsPresContext* aPresContext,
   EnableVisibilityTracking();
 }
 
-nsImageFrame::~nsImageFrame() {}
+nsImageFrame::~nsImageFrame() = default;
 
 NS_QUERYFRAME_HEAD(nsImageFrame)
   NS_QUERYFRAME_ENTRY(nsImageFrame)

layout/generic/nsImageFrame.h

@@ -405,7 +405,7 @@ class nsImageFrame : public nsAtomicContainerFrame, public nsIReflowCallback {
     }
 
    private:
-    ~IconLoad() {}
+    ~IconLoad() = default;
 
     void GetPrefs();
     nsTObserverArray<nsImageFrame*> mIconObservers;

layout/generic/nsLeafFrame.cpp

@@ -11,7 +11,7 @@
 
 using namespace mozilla;
 
-nsLeafFrame::~nsLeafFrame() {}
+nsLeafFrame::~nsLeafFrame() = default;
 
 /* virtual */
 nscoord nsLeafFrame::GetMinISize(gfxContext* aRenderingContext) {

layout/generic/nsLineBox.h

@@ -1578,9 +1578,7 @@ class nsLineList {
 #endif /* !NS_LINELIST_DEBUG_PASS_END */
 
 inline nsLineList_iterator& nsLineList_iterator::operator=(
-    const nsLineList_iterator& aOther) {
+    const nsLineList_iterator& aOther) = default;
-  ASSIGN_FROM(aOther)
-}
 
 inline nsLineList_iterator& nsLineList_iterator::operator=(
     const nsLineList_reverse_iterator& aOther) {
@@ -1593,9 +1591,7 @@ inline nsLineList_reverse_iterator& nsLineList_reverse_iterator::operator=(
 }
 
 inline nsLineList_reverse_iterator& nsLineList_reverse_iterator::operator=(
-    const nsLineList_reverse_iterator& aOther) {
+    const nsLineList_reverse_iterator& aOther) = default;
-  ASSIGN_FROM(aOther)
-}
 
 inline nsLineList_const_iterator& nsLineList_const_iterator::operator=(
     const nsLineList_iterator& aOther) {
@@ -1608,9 +1604,7 @@ inline nsLineList_const_iterator& nsLineList_const_iterator::operator=(
 }
 
 inline nsLineList_const_iterator& nsLineList_const_iterator::operator=(
-    const nsLineList_const_iterator& aOther) {
+    const nsLineList_const_iterator& aOther) = default;
-  ASSIGN_FROM(aOther)
-}
 
 inline nsLineList_const_iterator& nsLineList_const_iterator::operator=(
     const nsLineList_const_reverse_iterator& aOther) {
@@ -1637,9 +1631,7 @@ nsLineList_const_reverse_iterator::operator=(
 
 inline nsLineList_const_reverse_iterator&
 nsLineList_const_reverse_iterator::operator=(
-    const nsLineList_const_reverse_iterator& aOther) {
+    const nsLineList_const_reverse_iterator& aOther) = default;
-  ASSIGN_FROM(aOther)
-}
 
 //----------------------------------------------------------------------
 

layout/generic/nsPageFrame.cpp

@@ -42,7 +42,7 @@ NS_QUERYFRAME_TAIL_INHERITING(nsContainerFrame)
 nsPageFrame::nsPageFrame(ComputedStyle* aStyle, nsPresContext* aPresContext)
     : nsContainerFrame(aStyle, aPresContext, kClassID) {}
 
-nsPageFrame::~nsPageFrame() {}
+nsPageFrame::~nsPageFrame() = default;
 
 void nsPageFrame::Reflow(nsPresContext* aPresContext,
                          ReflowOutput& aDesiredSize,
@@ -657,7 +657,7 @@ nsPageBreakFrame::nsPageBreakFrame(ComputedStyle* aStyle,
                                    nsPresContext* aPresContext)
     : nsLeafFrame(aStyle, aPresContext, kClassID), mHaveReflowed(false) {}
 
-nsPageBreakFrame::~nsPageBreakFrame() {}
+nsPageBreakFrame::~nsPageBreakFrame() = default;
 
 nscoord nsPageBreakFrame::GetIntrinsicISize() {
   return nsPresContext::CSSPixelsToAppUnits(1);

layout/generic/nsTextFrame.cpp

@@ -4571,7 +4571,7 @@ nsIFrame* NS_NewContinuingTextFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsContinuingTextFrame)
 
-nsTextFrame::~nsTextFrame() {}
+nsTextFrame::~nsTextFrame() = default;
 
 Maybe<nsIFrame::Cursor> nsTextFrame::GetCursor(const nsPoint& aPoint) {
   StyleCursorKind kind = StyleUI()->mCursor.keyword;

layout/generic/nsTextFrame.h

@@ -887,14 +887,7 @@ class nsTextFrame : public nsFrame {
           mStyle(aStyle),
           mTextUnderlinePosition(aUnderlinePosition) {}
 
-    LineDecoration(const LineDecoration& aOther)
+    LineDecoration(const LineDecoration& aOther) = default;
-        : mFrame(aOther.mFrame),
-          mBaselineOffset(aOther.mBaselineOffset),
-          mTextUnderlineOffset(aOther.mTextUnderlineOffset),
-          mTextDecorationThickness(aOther.mTextDecorationThickness),
-          mColor(aOther.mColor),
-          mStyle(aOther.mStyle),
-          mTextUnderlinePosition(aOther.mTextUnderlinePosition) {}
 
     bool operator==(const LineDecoration& aOther) const {
       return mFrame == aOther.mFrame && mStyle == aOther.mStyle &&
@@ -912,7 +905,7 @@ class nsTextFrame : public nsFrame {
   struct TextDecorations {
     AutoTArray<LineDecoration, 1> mOverlines, mUnderlines, mStrikes;
 
-    TextDecorations() {}
+    TextDecorations() = default;
 
     bool HasDecorationLines() const {
       return HasUnderline() || HasOverline() || HasStrikeout();

layout/generic/nsTextRunTransformations.h

@@ -41,7 +41,7 @@ struct nsTransformedCharStyle final {
   bool mMaskPassword = false;
 
  private:
-  ~nsTransformedCharStyle() {}
+  ~nsTransformedCharStyle() = default;
   nsTransformedCharStyle(const nsTransformedCharStyle& aOther) = delete;
   nsTransformedCharStyle& operator=(const nsTransformedCharStyle& aOther) =
       delete;
@@ -49,7 +49,7 @@ struct nsTransformedCharStyle final {
 
 class nsTransformingTextRunFactory {
  public:
-  virtual ~nsTransformingTextRunFactory() {}
+  virtual ~nsTransformingTextRunFactory() = default;
 
   // Default 8-bit path just transforms to Unicode and takes that path
   already_AddRefed<nsTransformedTextRun> MakeTextRun(

layout/generic/nsVideoFrame.cpp

@@ -76,7 +76,7 @@ nsVideoFrame::nsVideoFrame(ComputedStyle* aStyle, nsPresContext* aPresContext)
   EnableVisibilityTracking();
 }
 
-nsVideoFrame::~nsVideoFrame() {}
+nsVideoFrame::~nsVideoFrame() = default;
 
 NS_QUERYFRAME_HEAD(nsVideoFrame)
   NS_QUERYFRAME_ENTRY(nsVideoFrame)

layout/inspector/inDeepTreeWalker.cpp

@@ -34,7 +34,7 @@ inDeepTreeWalker::inDeepTreeWalker()
       mCurrentIndex(-1),
       mWhatToShow(mozilla::dom::NodeFilter_Binding::SHOW_ALL) {}
 
-inDeepTreeWalker::~inDeepTreeWalker() {}
+inDeepTreeWalker::~inDeepTreeWalker() = default;
 
 NS_IMPL_ISUPPORTS(inDeepTreeWalker, inIDeepTreeWalker)
 

layout/ipc/RemoteLayerTreeOwner.cpp

@@ -49,7 +49,7 @@ RemoteLayerTreeOwner::RemoteLayerTreeOwner()
       mInitialized(false),
       mLayersConnected(false) {}
 
-RemoteLayerTreeOwner::~RemoteLayerTreeOwner() {}
+RemoteLayerTreeOwner::~RemoteLayerTreeOwner() = default;
 
 bool RemoteLayerTreeOwner::Initialize(BrowserParent* aBrowserParent) {
   if (mInitialized || !aBrowserParent) {

layout/mathml/nsMathMLChar.cpp

@@ -85,7 +85,7 @@ static const nsGlyphCode kNullGlyph = {{{0, 0}}, 0};
 
 class nsGlyphTable {
  public:
-  virtual ~nsGlyphTable() {}
+  virtual ~nsGlyphTable() = default;
 
   virtual const FontFamilyName& FontNameFor(
       const nsGlyphCode& aGlyphCode) const = 0;
@@ -560,7 +560,7 @@ class nsGlyphTableList final : public nsIObserver {
   nsGlyphTable* GetGlyphTableFor(const nsACString& aFamily);
 
  private:
-  ~nsGlyphTableList() {}
+  ~nsGlyphTableList() = default;
 
   nsPropertiesTable* PropertiesTableAt(int32_t aIndex) {
     return &mPropertiesTableList.ElementAt(aIndex);

layout/mathml/nsMathMLContainerFrame.h

@@ -435,7 +435,7 @@ class nsMathMLmathBlockFrame final : public nsBlockFrame {
     // Bug 1301881: Do we still need to set NS_BLOCK_FLOAT_MGR?
     // AddStateBits(NS_BLOCK_FLOAT_MGR);
   }
-  virtual ~nsMathMLmathBlockFrame() {}
+  virtual ~nsMathMLmathBlockFrame() = default;
 };
 
 // --------------
@@ -498,7 +498,7 @@ class nsMathMLmathInlineFrame final : public nsInlineFrame,
                                    nsPresContext* aPresContext)
       : nsInlineFrame(aStyle, aPresContext, kClassID) {}
 
-  virtual ~nsMathMLmathInlineFrame() {}
+  virtual ~nsMathMLmathInlineFrame() = default;
 };
 
 #endif /* nsMathMLContainerFrame_h___ */

layout/mathml/nsMathMLSelectedFrame.cpp

@@ -9,7 +9,7 @@
 
 using namespace mozilla;
 
-nsMathMLSelectedFrame::~nsMathMLSelectedFrame() {}
+nsMathMLSelectedFrame::~nsMathMLSelectedFrame() = default;
 
 NS_IMETHODIMP
 nsMathMLSelectedFrame::TransmitAutomaticData() {

layout/mathml/nsMathMLTokenFrame.cpp

@@ -21,7 +21,7 @@ nsIFrame* NS_NewMathMLTokenFrame(PresShell* aPresShell, ComputedStyle* aStyle) {
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLTokenFrame)
 
-nsMathMLTokenFrame::~nsMathMLTokenFrame() {}
+nsMathMLTokenFrame::~nsMathMLTokenFrame() = default;
 
 NS_IMETHODIMP
 nsMathMLTokenFrame::InheritAutomaticData(nsIFrame* aParent) {

layout/mathml/nsMathMLmactionFrame.h

@@ -45,7 +45,7 @@ class nsMathMLmactionFrame final : public nsMathMLSelectedFrame {
 
   class MouseListener final : public nsIDOMEventListener {
    private:
-    ~MouseListener() {}
+    ~MouseListener() = default;
 
    public:
     NS_DECL_ISUPPORTS

layout/mathml/nsMathMLmencloseFrame.cpp

@@ -59,7 +59,7 @@ nsMathMLmencloseFrame::nsMathMLmencloseFrame(ComputedStyle* aStyle,
       mRadicalCharIndex(-1),
       mContentWidth(0) {}
 
-nsMathMLmencloseFrame::~nsMathMLmencloseFrame() {}
+nsMathMLmencloseFrame::~nsMathMLmencloseFrame() = default;
 
 nsresult nsMathMLmencloseFrame::AllocateMathMLChar(nsMencloseNotation mask) {
   // Is the char already allocated?

layout/mathml/nsMathMLmfracFrame.cpp

@@ -42,7 +42,7 @@ nsIFrame* NS_NewMathMLmfracFrame(PresShell* aPresShell, ComputedStyle* aStyle) {
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmfracFrame)
 
-nsMathMLmfracFrame::~nsMathMLmfracFrame() {}
+nsMathMLmfracFrame::~nsMathMLmfracFrame() = default;
 
 eMathMLFrameType nsMathMLmfracFrame::GetMathMLFrameType() {
   // frac is "inner" in TeXBook, Appendix G, rule 15e. See also page 170.

layout/mathml/nsMathMLmmultiscriptsFrame.cpp

@@ -30,7 +30,7 @@ nsIFrame* NS_NewMathMLmmultiscriptsFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmmultiscriptsFrame)
 
-nsMathMLmmultiscriptsFrame::~nsMathMLmmultiscriptsFrame() {}
+nsMathMLmmultiscriptsFrame::~nsMathMLmmultiscriptsFrame() = default;
 
 uint8_t nsMathMLmmultiscriptsFrame::ScriptIncrement(nsIFrame* aFrame) {
   if (!aFrame) return 0;

layout/mathml/nsMathMLmoFrame.cpp

@@ -28,7 +28,7 @@ nsIFrame* NS_NewMathMLmoFrame(PresShell* aPresShell, ComputedStyle* aStyle) {
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmoFrame)
 
-nsMathMLmoFrame::~nsMathMLmoFrame() {}
+nsMathMLmoFrame::~nsMathMLmoFrame() = default;
 
 static const char16_t kApplyFunction = char16_t(0x2061);
 static const char16_t kInvisibleTimes = char16_t(0x2062);

layout/mathml/nsMathMLmpaddedFrame.cpp

@@ -37,7 +37,7 @@ nsIFrame* NS_NewMathMLmpaddedFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmpaddedFrame)
 
-nsMathMLmpaddedFrame::~nsMathMLmpaddedFrame() {}
+nsMathMLmpaddedFrame::~nsMathMLmpaddedFrame() = default;
 
 NS_IMETHODIMP
 nsMathMLmpaddedFrame::InheritAutomaticData(nsIFrame* aParent) {

layout/mathml/nsMathMLmrootFrame.cpp

@@ -36,7 +36,7 @@ nsMathMLmrootFrame::nsMathMLmrootFrame(ComputedStyle* aStyle,
       mSqrChar(),
       mBarRect() {}
 
-nsMathMLmrootFrame::~nsMathMLmrootFrame() {}
+nsMathMLmrootFrame::~nsMathMLmrootFrame() = default;
 
 void nsMathMLmrootFrame::Init(nsIContent* aContent, nsContainerFrame* aParent,
                               nsIFrame* aPrevInFlow) {

layout/mathml/nsMathMLmrowFrame.cpp

@@ -22,7 +22,7 @@ nsIFrame* NS_NewMathMLmrowFrame(PresShell* aPresShell, ComputedStyle* aStyle) {
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmrowFrame)
 
-nsMathMLmrowFrame::~nsMathMLmrowFrame() {}
+nsMathMLmrowFrame::~nsMathMLmrowFrame() = default;
 
 NS_IMETHODIMP
 nsMathMLmrowFrame::InheritAutomaticData(nsIFrame* aParent) {

layout/mathml/nsMathMLmspaceFrame.cpp

@@ -24,7 +24,7 @@ nsIFrame* NS_NewMathMLmspaceFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmspaceFrame)
 
-nsMathMLmspaceFrame::~nsMathMLmspaceFrame() {}
+nsMathMLmspaceFrame::~nsMathMLmspaceFrame() = default;
 
 void nsMathMLmspaceFrame::ProcessAttributes(nsPresContext* aPresContext) {
   nsAutoString value;

layout/mathml/nsMathMLmsqrtFrame.cpp

@@ -26,7 +26,7 @@ nsMathMLmsqrtFrame::nsMathMLmsqrtFrame(ComputedStyle* aStyle,
                                        nsPresContext* aPresContext)
     : nsMathMLmencloseFrame(aStyle, aPresContext, kClassID) {}
 
-nsMathMLmsqrtFrame::~nsMathMLmsqrtFrame() {}
+nsMathMLmsqrtFrame::~nsMathMLmsqrtFrame() = default;
 
 void nsMathMLmsqrtFrame::Init(nsIContent* aContent, nsContainerFrame* aParent,
                               nsIFrame* aPrevInFlow) {

layout/mathml/nsMathMLmtableFrame.cpp

@@ -671,7 +671,7 @@ nsContainerFrame* NS_NewMathMLmtableOuterFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmtableWrapperFrame)
 
-nsMathMLmtableWrapperFrame::~nsMathMLmtableWrapperFrame() {}
+nsMathMLmtableWrapperFrame::~nsMathMLmtableWrapperFrame() = default;
 
 nsresult nsMathMLmtableWrapperFrame::AttributeChanged(int32_t aNameSpaceID,
                                                       nsAtom* aAttribute,
@@ -896,7 +896,7 @@ nsContainerFrame* NS_NewMathMLmtableFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmtableFrame)
 
-nsMathMLmtableFrame::~nsMathMLmtableFrame() {}
+nsMathMLmtableFrame::~nsMathMLmtableFrame() = default;
 
 void nsMathMLmtableFrame::SetInitialChildList(ChildListID aListID,
                                               nsFrameList& aChildList) {
@@ -1051,7 +1051,7 @@ nsContainerFrame* NS_NewMathMLmtrFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmtrFrame)
 
-nsMathMLmtrFrame::~nsMathMLmtrFrame() {}
+nsMathMLmtrFrame::~nsMathMLmtrFrame() = default;
 
 nsresult nsMathMLmtrFrame::AttributeChanged(int32_t aNameSpaceID,
                                             nsAtom* aAttribute,
@@ -1093,7 +1093,7 @@ nsContainerFrame* NS_NewMathMLmtdFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmtdFrame)
 
-nsMathMLmtdFrame::~nsMathMLmtdFrame() {}
+nsMathMLmtdFrame::~nsMathMLmtdFrame() = default;
 
 void nsMathMLmtdFrame::Init(nsIContent* aContent, nsContainerFrame* aParent,
                             nsIFrame* aPrevInFlow) {

layout/mathml/nsMathMLmtableFrame.h

@@ -285,7 +285,7 @@ class nsMathMLmtdInnerFrame final : public nsBlockFrame, public nsMathMLFrame {
  protected:
   explicit nsMathMLmtdInnerFrame(ComputedStyle* aStyle,
                                  nsPresContext* aPresContext);
-  virtual ~nsMathMLmtdInnerFrame() {}
+  virtual ~nsMathMLmtdInnerFrame() = default;
 
   mozilla::UniquePtr<nsStyleText> mUniqueStyleText;
 

layout/mathml/nsMathMLmunderoverFrame.cpp

@@ -32,7 +32,7 @@ nsIFrame* NS_NewMathMLmunderoverFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmunderoverFrame)
 
-nsMathMLmunderoverFrame::~nsMathMLmunderoverFrame() {}
+nsMathMLmunderoverFrame::~nsMathMLmunderoverFrame() = default;
 
 nsresult nsMathMLmunderoverFrame::AttributeChanged(int32_t aNameSpaceID,
                                                    nsAtom* aAttribute,

layout/mathml/nsMathMLsemanticsFrame.cpp

@@ -24,7 +24,7 @@ nsIFrame* NS_NewMathMLsemanticsFrame(PresShell* aPresShell,
 
 NS_IMPL_FRAMEARENA_HELPERS(nsMathMLsemanticsFrame)
 
-nsMathMLsemanticsFrame::~nsMathMLsemanticsFrame() {}
+nsMathMLsemanticsFrame::~nsMathMLsemanticsFrame() = default;
 
 nsIFrame* nsMathMLsemanticsFrame::GetSelectedFrame() {
   // By default, we will display the first child of the <semantics> element.

layout/printing/DrawEventRecorder.h

@@ -127,7 +127,7 @@ class PRFileDescStream final : public mozilla::gfx::EventStream {
 class DrawEventRecorderPRFileDesc final : public gfx::DrawEventRecorderPrivate {
  public:
   MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(DrawEventRecorderPRFileDesc, override)
-  explicit DrawEventRecorderPRFileDesc(){};
+  explicit DrawEventRecorderPRFileDesc() = default;
   ~DrawEventRecorderPRFileDesc();
 
   void RecordEvent(const gfx::RecordedEvent& aEvent) override;

layout/printing/ipc/RemotePrintJobChild.cpp

@@ -16,7 +16,7 @@ namespace layout {
 
 NS_IMPL_ISUPPORTS(RemotePrintJobChild, nsIWebProgressListener)
 
-RemotePrintJobChild::RemotePrintJobChild() {}
+RemotePrintJobChild::RemotePrintJobChild() = default;
 
 nsresult RemotePrintJobChild::InitializePrint(const nsString& aDocumentTitle,
                                               const nsString& aPrintToFile,
@@ -153,7 +153,7 @@ RemotePrintJobChild::OnContentBlockingEvent(nsIWebProgress* aProgress,
 
 // End of nsIWebProgressListener
 
-RemotePrintJobChild::~RemotePrintJobChild() {}
+RemotePrintJobChild::~RemotePrintJobChild() = default;
 
 void RemotePrintJobChild::ActorDestroy(ActorDestroyReason aWhy) {
   mPagePrintTimer = nullptr;

layout/style/BindingStyleRule.h

@@ -30,8 +30,8 @@ class BindingStyleRule : public css::Rule {
   BindingStyleRule(StyleSheet* aSheet, css::Rule* aParentRule,
                    uint32_t aLineNumber, uint32_t aColumnNumber)
       : css::Rule(aSheet, aParentRule, aLineNumber, aColumnNumber) {}
-  BindingStyleRule(const BindingStyleRule& aCopy) : css::Rule(aCopy) {}
+  BindingStyleRule(const BindingStyleRule& aCopy) = default;
-  virtual ~BindingStyleRule() {}
+  virtual ~BindingStyleRule() = default;
 
  public:
   // This is pure virtual because we have no members, and are an abstract class

layout/style/CSSNamespaceRule.cpp

@@ -12,7 +12,7 @@ using namespace mozilla::dom;
 
 namespace mozilla {
 
-CSSNamespaceRule::~CSSNamespaceRule() {}
+CSSNamespaceRule::~CSSNamespaceRule() = default;
 
 #ifdef DEBUG
 void CSSNamespaceRule::List(FILE* out, int32_t aIndent) const {

layout/style/CSSRuleList.h

@@ -32,7 +32,7 @@ class CSSRuleList : public nsISupports, public nsWrapperCache {
   virtual uint32_t Length() = 0;
 
  protected:
-  virtual ~CSSRuleList() {}
+  virtual ~CSSRuleList() = default;
 };
 
 }  // namespace dom

layout/style/CSSStyleRule.h

@@ -91,7 +91,7 @@ class CSSStyleRule final : public BindingStyleRule,
 #endif
 
  private:
-  ~CSSStyleRule() {}
+  ~CSSStyleRule() = default;
 
   // For computing the offset of mDecls.
   friend class CSSStyleRuleDeclaration;

layout/style/CSSValue.h

@@ -37,7 +37,7 @@ class CSSValue : public RefCounted<CSSValue> {
   virtual void GetCssText(nsString& aText, ErrorResult& aRv) = 0;
   virtual uint16_t CssValueType() const = 0;
 
-  virtual ~CSSValue(){};
+  virtual ~CSSValue() = default;
 
   // Downcasting
 

layout/style/CounterStyleManager.cpp

@@ -892,7 +892,7 @@ class DependentBuiltinCounterStyle final : public BuiltinCounterStyle {
   }
 
  private:
-  ~DependentBuiltinCounterStyle() {}
+  ~DependentBuiltinCounterStyle() = default;
 
   CounterStyleManager* mManager;
 };
@@ -987,7 +987,7 @@ class CustomCounterStyle final : public CounterStyle {
   }
 
  private:
-  ~CustomCounterStyle() {}
+  ~CustomCounterStyle() = default;
 
   Span<const nsString> GetSymbols();
   Span<const AdditiveSymbol> GetAdditiveSymbols();

layout/style/CounterStyleManager.h

@@ -121,7 +121,7 @@ class AnonymousCounterStyle final : public CounterStyle {
   NS_INLINE_DECL_THREADSAFE_REFCOUNTING(AnonymousCounterStyle)
 
  private:
-  ~AnonymousCounterStyle() {}
+  ~AnonymousCounterStyle() = default;
 
   bool mSingleString;
   StyleSymbolsType mSymbolsType;

layout/style/ImageLoader.h

@@ -111,7 +111,7 @@ class ImageLoader final {
     void ReflowCallbackCanceled() override;
   };
 
-  ~ImageLoader() {}
+  ~ImageLoader() = default;
 
   // We need to be able to look up the frames associated with a request (for
   // delivering notifications) and the requests associated with a frame (when

layout/style/Loader.h

@@ -53,7 +53,7 @@ class ImportRule;
 
 class MOZ_RAII LoaderReusableStyleSheets {
  public:
-  LoaderReusableStyleSheets() {}
+  LoaderReusableStyleSheets() = default;
 
   /**
    * Look for a reusable sheet (see AddReusableSheet) matching the

layout/style/MediaQueryList.cpp

@@ -31,7 +31,7 @@ MediaQueryList::MediaQueryList(Document* aDocument,
   KeepAliveIfHasListenersFor(ONCHANGE_STRING);
 }
 
-MediaQueryList::~MediaQueryList() {}
+MediaQueryList::~MediaQueryList() = default;
 
 NS_IMPL_CYCLE_COLLECTION_CLASS(MediaQueryList)
 

layout/style/PreloadedStyleSheet.h

@@ -41,7 +41,7 @@ class PreloadedStyleSheet : public nsIPreloadedStyleSheet {
   nsresult PreloadAsync(NotNull<dom::Promise*> aPromise);
 
  protected:
-  virtual ~PreloadedStyleSheet() {}
+  virtual ~PreloadedStyleSheet() = default;
 
  private:
   class StylesheetPreloadObserver final : public nsICSSLoaderObserver {
@@ -56,7 +56,7 @@ class PreloadedStyleSheet : public nsIPreloadedStyleSheet {
                                 nsresult aStatus) override;
 
    protected:
-    virtual ~StylesheetPreloadObserver() {}
+    virtual ~StylesheetPreloadObserver() = default;
 
    private:
     RefPtr<dom::Promise> mPromise;

layout/style/ServoStyleSet.h

@@ -603,7 +603,7 @@ class UACacheReporter final : public nsIMemoryReporter {
   NS_DECL_NSIMEMORYREPORTER
 
  private:
-  ~UACacheReporter() {}
+  ~UACacheReporter() = default;
 };
 
 }  // namespace mozilla

layout/style/StyleAnimationValue.h

@@ -49,22 +49,11 @@ struct AnimationValue {
       : mServo(aValue) {}
   AnimationValue() = default;
 
-  AnimationValue(const AnimationValue& aOther) : mServo(aOther.mServo) {}
+  AnimationValue(const AnimationValue& aOther) = default;
-  AnimationValue(AnimationValue&& aOther) : mServo(std::move(aOther.mServo)) {}
+  AnimationValue(AnimationValue&& aOther) = default;
 
-  AnimationValue& operator=(const AnimationValue& aOther) {
+  AnimationValue& operator=(const AnimationValue& aOther) = default;
-    if (this != &aOther) {
+  AnimationValue& operator=(AnimationValue&& aOther) = default;
-      mServo = aOther.mServo;
-    }
-    return *this;
-  }
-  AnimationValue& operator=(AnimationValue&& aOther) {
-    MOZ_ASSERT(this != &aOther, "Do not move itself");
-    if (this != &aOther) {
-      mServo = std::move(aOther.mServo);
-    }
-    return *this;
-  }
 
   bool operator==(const AnimationValue& aOther) const;
   bool operator!=(const AnimationValue& aOther) const;

layout/style/nsDOMCSSAttrDeclaration.cpp

@@ -30,7 +30,7 @@ nsDOMCSSAttributeDeclaration::nsDOMCSSAttributeDeclaration(Element* aElement,
   NS_ASSERTION(aElement, "Inline style for a NULL element?");
 }
 
-nsDOMCSSAttributeDeclaration::~nsDOMCSSAttributeDeclaration() {}
+nsDOMCSSAttributeDeclaration::~nsDOMCSSAttributeDeclaration() = default;
 
 NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(nsDOMCSSAttributeDeclaration, mElement)
 

layout/style/nsHTMLCSSStyleSheet.cpp

@@ -21,7 +21,7 @@
 using namespace mozilla;
 using namespace mozilla::dom;
 
-nsHTMLCSSStyleSheet::nsHTMLCSSStyleSheet() {}
+nsHTMLCSSStyleSheet::nsHTMLCSSStyleSheet() = default;
 
 nsHTMLCSSStyleSheet::~nsHTMLCSSStyleSheet() {
   // We may go away before all of our cached style attributes do,

layout/style/nsHTMLStyleSheet.h

@@ -66,7 +66,7 @@ class nsHTMLStyleSheet final {
   nsHTMLStyleSheet(const nsHTMLStyleSheet& aCopy) = delete;
   nsHTMLStyleSheet& operator=(const nsHTMLStyleSheet& aCopy) = delete;
 
-  ~nsHTMLStyleSheet() {}
+  ~nsHTMLStyleSheet() = default;
 
   // Implementation of SetLink/VisitedLink/ActiveLinkColor
   nsresult ImplLinkColorSetter(RefPtr<RawServoDeclarationBlock>& aDecl,

layout/style/nsStyleStruct.cpp

@@ -1972,7 +1972,7 @@ nsStyleImageLayers::Layer::Layer()
       mComposite(NS_STYLE_MASK_COMPOSITE_ADD),
       mMaskMode(StyleMaskMode::MatchSource) {}
 
-nsStyleImageLayers::Layer::~Layer() {}
+nsStyleImageLayers::Layer::~Layer() = default;
 
 void nsStyleImageLayers::Layer::Initialize(
     nsStyleImageLayers::LayerType aType) {
@@ -2146,12 +2146,7 @@ bool nsStyleBackground::IsTransparent(mozilla::ComputedStyle* aStyle) const {
          NS_GET_A(BackgroundColor(aStyle)) == 0;
 }
 
-StyleTransition::StyleTransition(const StyleTransition& aCopy)
+StyleTransition::StyleTransition(const StyleTransition& aCopy) = default;
-    : mTimingFunction(aCopy.mTimingFunction),
-      mDuration(aCopy.mDuration),
-      mDelay(aCopy.mDelay),
-      mProperty(aCopy.mProperty),
-      mUnknownProperty(aCopy.mUnknownProperty) {}
 
 void StyleTransition::SetInitialValues() {
   mTimingFunction = nsTimingFunction(StyleTimingKeyword::Ease);
@@ -2168,15 +2163,7 @@ bool StyleTransition::operator==(const StyleTransition& aOther) const {
           mUnknownProperty == aOther.mUnknownProperty);
 }
 
-StyleAnimation::StyleAnimation(const StyleAnimation& aCopy)
+StyleAnimation::StyleAnimation(const StyleAnimation& aCopy) = default;
-    : mTimingFunction(aCopy.mTimingFunction),
-      mDuration(aCopy.mDuration),
-      mDelay(aCopy.mDelay),
-      mName(aCopy.mName),
-      mDirection(aCopy.mDirection),
-      mFillMode(aCopy.mFillMode),
-      mPlayState(aCopy.mPlayState),
-      mIterationCount(aCopy.mIterationCount) {}
 
 void StyleAnimation::SetInitialValues() {
   mTimingFunction = nsTimingFunction(StyleTimingKeyword::Ease);

layout/style/nsStyleStruct.h

@@ -181,7 +181,7 @@ struct nsStyleImageLayers {
     mozilla::StyleImageLayerRepeat mXRepeat, mYRepeat;
 
     // Initialize nothing
-    Repeat() {}
+    Repeat() = default;
 
     bool IsInitialValue() const {
       return mXRepeat == mozilla::StyleImageLayerRepeat::Repeat &&
@@ -1952,9 +1952,11 @@ class nsTArray_Simple {
   T* mBuffer;
 
  public:
-  // The existence of a destructor here prevents bindgen from deriving the Clone
+  ~nsTArray_Simple() {
-  // trait via a simple memory copy.
+    // The existence of a user-provided, and therefore non-trivial, destructor
-  ~nsTArray_Simple(){};
+    // here prevents bindgen from deriving the Clone trait via a simple memory
+    // copy.
+  }
 };
 
 STATIC_ASSERT_TYPE_LAYOUTS_MATCH(nsTArray<nsStyleImageLayers::Layer>,

layout/tables/BasicTableLayoutStrategy.cpp

@@ -33,7 +33,7 @@ BasicTableLayoutStrategy::BasicTableLayoutStrategy(nsTableFrame* aTableFrame)
 }
 
 /* virtual */
-BasicTableLayoutStrategy::~BasicTableLayoutStrategy() {}
+BasicTableLayoutStrategy::~BasicTableLayoutStrategy() = default;
 
 /* virtual */
 nscoord BasicTableLayoutStrategy::GetMinISize(gfxContext* aRenderingContext) {

layout/tables/FixedTableLayoutStrategy.cpp

@@ -26,7 +26,7 @@ FixedTableLayoutStrategy::FixedTableLayoutStrategy(nsTableFrame* aTableFrame)
 }
 
 /* virtual */
-FixedTableLayoutStrategy::~FixedTableLayoutStrategy() {}
+FixedTableLayoutStrategy::~FixedTableLayoutStrategy() = default;
 
 /* virtual */
 nscoord FixedTableLayoutStrategy::GetMinISize(gfxContext* aRenderingContext) {

layout/tables/celldata.h

@@ -351,7 +351,7 @@ inline BCData::BCData() {
   mCornerBevel = false;
 }
 
-inline BCData::~BCData() {}
+inline BCData::~BCData() = default;
 
 inline nscoord BCData::GetIStartEdge(BCBorderOwner& aOwner,
                                      bool& aStart) const {

layout/tables/nsITableLayoutStrategy.h

@@ -24,7 +24,7 @@ class nsITableLayoutStrategy {
  public:
   using ReflowInput = mozilla::ReflowInput;
 
-  virtual ~nsITableLayoutStrategy() {}
+  virtual ~nsITableLayoutStrategy() = default;
 
   /** Implement nsIFrame::GetMinISize for the table */
   virtual nscoord GetMinISize(gfxContext* aRenderingContext) = 0;