Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-15 06:15:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug 314091 Fix users of mozAutoDocUpdate to actually declare a local variable,

Browse Source 
so that the destructor doesn't get called immediately
r+sr=bz
This commit is contained in:
cbiesinger%web.de 2005-10-29 12:54:24 +00:00
parent 909be539a0
commit 8afaa18779
8 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
content/base/src/nsDocument.cpp
View File

@ -986,7 +986,7 @@ nsDocument::ResetStylesheetsToURI(nsIURI* aURI)
{
NS_PRECONDITION(aURI, "Null URI passed to ResetStylesheetsToURI");
mozAutoDocUpdate(this, UPDATE_STYLE, PR_TRUE);
mozAutoDocUpdate upd(this, UPDATE_STYLE, PR_TRUE);
// The stylesheets should forget us
PRInt32 indx = mStyleSheets.Count();

2
content/base/src/nsImageLoadingContent.cpp
View File

@ -596,7 +596,7 @@ nsImageLoadingContent::UpdateImageState(PRBool aNotify)
NS_ASSERTION(thisContent->IsInDoc(), "Something is confused");
PRInt32 changedBits = oldState ^ ImageState();
if (changedBits) {
mozAutoDocUpdate(doc, UPDATE_CONTENT_STATE, PR_TRUE);
mozAutoDocUpdate upd(doc, UPDATE_CONTENT_STATE, PR_TRUE);
doc->ContentStatesChanged(thisContent, nsnull, changedBits);
}
}

2
content/base/src/nsObjectLoadingContent.cpp
View File

@ -979,7 +979,7 @@ nsObjectLoadingContent::NotifyStateChanged(ObjectType aOldType,
PRInt32 changedBits = aOldState ^ newState;
{
mozAutoDocUpdate(doc, UPDATE_CONTENT_STATE, PR_TRUE);
mozAutoDocUpdate upd(doc, UPDATE_CONTENT_STATE, PR_TRUE);
doc->ContentStatesChanged(thisContent, nsnull, changedBits);
}
if (aSync) {

2
content/html/content/src/nsGenericHTMLElement.cpp
View File

@ -3246,7 +3246,7 @@ nsGenericHTMLFormElement::AfterSetAttr(PRInt32 aNameSpaceID, nsIAtom* aName,
if (aNotify && aName == nsHTMLAtoms::disabled && CanBeDisabled()) {
nsIDocument* document = GetCurrentDoc();
if (document) {
mozAutoDocUpdate(document, UPDATE_CONTENT_STATE, PR_TRUE);
mozAutoDocUpdate upd(document, UPDATE_CONTENT_STATE, PR_TRUE);
document->ContentStatesChanged(this, nsnull, NS_EVENT_STATE_DISABLED |
NS_EVENT_STATE_ENABLED);
}

2
content/html/content/src/nsHTMLInputElement.cpp
View File

@ -997,7 +997,7 @@ nsHTMLInputElement::SetCheckedInternal(PRBool aChecked, PRBool aNotify)
if (aNotify) {
nsIDocument* document = GetCurrentDoc();
if (document) {
mozAutoDocUpdate(document, UPDATE_CONTENT_STATE, aNotify);
mozAutoDocUpdate upd(document, UPDATE_CONTENT_STATE, aNotify);
document->ContentStatesChanged(this, nsnull, NS_EVENT_STATE_CHECKED);
}
}

2
content/html/content/src/nsHTMLOptGroupElement.cpp
View File

@ -192,7 +192,7 @@ nsHTMLOptGroupElement::AfterSetAttr(PRInt32 aNameSpaceID, nsIAtom* aName,
aName == nsHTMLAtoms::disabled) {
nsIDocument* document = GetCurrentDoc();
if (document) {
mozAutoDocUpdate(document, UPDATE_CONTENT_STATE, PR_TRUE);
mozAutoDocUpdate upd(document, UPDATE_CONTENT_STATE, PR_TRUE);
document->ContentStatesChanged(this, nsnull, NS_EVENT_STATE_DISABLED |
NS_EVENT_STATE_ENABLED);
}

4
content/html/content/src/nsHTMLOptionElement.cpp
View File

@ -230,7 +230,7 @@ nsHTMLOptionElement::SetSelectedInternal(PRBool aValue, PRBool aNotify)
if (aNotify) {
nsIDocument* document = GetCurrentDoc();
if (document) {
mozAutoDocUpdate(document, UPDATE_CONTENT_STATE, aNotify);
mozAutoDocUpdate upd(document, UPDATE_CONTENT_STATE, aNotify);
document->ContentStatesChanged(this, nsnull, NS_EVENT_STATE_CHECKED);
}
}
@ -502,7 +502,7 @@ nsHTMLOptionElement::AfterSetAttr(PRInt32 aNameSpaceID, nsIAtom* aName,
aName == nsHTMLAtoms::disabled) {
nsIDocument* document = GetCurrentDoc();
if (document) {
mozAutoDocUpdate(document, UPDATE_CONTENT_STATE, PR_TRUE);
mozAutoDocUpdate upd(document, UPDATE_CONTENT_STATE, PR_TRUE);
document->ContentStatesChanged(this, nsnull, NS_EVENT_STATE_DISABLED |
NS_EVENT_STATE_ENABLED);
}

2
content/xtf/src/nsXTFElementWrapper.cpp
View File

@ -761,7 +761,7 @@ nsXTFElementWrapper::SetIntrinsicState(PRInt32 aNewState)
return NS_OK;
mIntrinsicState = aNewState;
mozAutoDocUpdate(doc, UPDATE_CONTENT_STATE, PR_TRUE);
mozAutoDocUpdate upd(doc, UPDATE_CONTENT_STATE, PR_TRUE);
doc->ContentStatesChanged(this, nsnull, bits);
return NS_OK;