From 8bcd5cb19ec1e8a242cd12ef693c2f52aacd7363 Mon Sep 17 00:00:00 2001 From: Jared Wein Date: Thu, 7 Sep 2017 03:46:46 -0400 Subject: [PATCH] Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the library animation. r=Gijs MozReview-Commit-ID: HXbjhQFCplb --HG-- extra : rebase_source : ad0ca5e01d4fae85308b7be63ce3953d9767fe12 --- browser/base/content/browser-places.js | 2 -- browser/themes/shared/browser.inc.css | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/browser/base/content/browser-places.js b/browser/base/content/browser-places.js index e76c4f469c9f..d82422bb6f54 100644 --- a/browser/base/content/browser-places.js +++ b/browser/base/content/browser-places.js @@ -1555,7 +1555,6 @@ var LibraryUI = { animatableBox.removeAttribute("brighttext"); } animatableBox.removeAttribute("fade"); - gNavToolbox.setAttribute("animate", animation); libraryButton.setAttribute("animate", animation); animatableBox.setAttribute("animate", animation); if (!this._libraryButtonAnimationEndListeners[animation]) { @@ -1578,7 +1577,6 @@ var LibraryUI = { let libraryButton = document.getElementById("library-button"); // Put the 'fill' back in the normal icon. libraryButton.removeAttribute("animate"); - gNavToolbox.removeAttribute("animate"); } }, }; diff --git a/browser/themes/shared/browser.inc.css b/browser/themes/shared/browser.inc.css index abc03b9bd4a7..9d86327ad21e 100644 --- a/browser/themes/shared/browser.inc.css +++ b/browser/themes/shared/browser.inc.css @@ -56,9 +56,9 @@ min-height: 22px; } -/* Library animation */ +/* Required for Library animation */ -#navigator-toolbox[animate] { +#navigator-toolbox { position: relative; }