Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-03 02:25:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1645339 - Use range-based for with nsTObserverArray in dom/reporting. r=smaug

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D79503
This commit is contained in:
Simon Giesecke 2020-06-16 10:15:42 +00:00
parent d35ea0c25f
commit 8bfe252320
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
dom/reporting/ReportingHeader.cpp
View File

@ -286,11 +286,10 @@ void ReportingHeader::ReportingFromChannel(nsIHttpChannel* aChannel) {
continue;
}
/// XXX We could use a NonObservingRange here and then
/// std::any_of.
bool found = false;
nsTObserverArray<Group>::ForwardIterator iter(client->mGroups);
while (iter.HasMore()) {
const Group& group = iter.GetNext();
for (const Group& group : client->mGroups.ForwardRange()) {
if (group.mName == groupName) {
found = true;
break;
@ -512,10 +511,7 @@ void ReportingHeader::GetEndpointForReport(const nsAString& aGroupName,
return;
}
nsTObserverArray<Group>::ForwardIterator iter(client->mGroups);
while (iter.HasMore()) {
const Group& group = iter.GetNext();
for (const Group& group : client->mGroups.ForwardRange()) {
if (group.mName == aGroupName) {
GetEndpointForReportInternal(group, aEndpointURI);
break;
@ -539,10 +535,8 @@ void ReportingHeader::GetEndpointForReportInternal(
int64_t minPriority = -1;
uint32_t totalWeight = 0;
nsTObserverArray<Endpoint>::ForwardIterator iter(aGroup.mEndpoints);
while (iter.HasMore()) {
const Endpoint& endpoint = iter.GetNext();
/// XXX We could use a NonObservingRange here.
for (const Endpoint& endpoint : aGroup.mEndpoints.ForwardRange()) {
if (minPriority == -1 || minPriority > endpoint.mPriority) {
minPriority = endpoint.mPriority;
totalWeight = endpoint.mWeight;
@ -571,10 +565,8 @@ void ReportingHeader::GetEndpointForReportInternal(
totalWeight = randomNumber % totalWeight;
nsTObserverArray<Endpoint>::ForwardIterator iter2(aGroup.mEndpoints);
while (iter2.HasMore()) {
const Endpoint& endpoint = iter2.GetNext();
/// XXX We could use a NonObservingRange here.
for (const Endpoint& endpoint : aGroup.mEndpoints.ForwardRange()) {
if (minPriority == endpoint.mPriority && totalWeight < endpoint.mWeight) {
Unused << NS_WARN_IF(NS_FAILED(endpoint.mUrl->GetSpec(aEndpointURI)));
break;