Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-01 13:57:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1830790 - P16 - remove localSdp and remoteSdp from internal stats report;r=bwc,webidl,smaug

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D178978
This commit is contained in:
Nico Grunbaum 2023-05-31 19:58:01 +00:00
parent a8ab873507
commit 8bff27c189
3 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dom/media/webrtc/WebrtcGlobal.h
View File

@ -119,8 +119,8 @@ struct ParamTraits<mozilla::dom::RTCStatsCollection> {
DEFINE_IPC_SERIALIZER_WITH_SUPER_CLASS_AND_FIELDS(
mozilla::dom::RTCStatsReportInternal, mozilla::dom::RTCStatsCollection,
mClosed, mLocalSdp, mSdpHistory, mPcid, mBrowserId, mRemoteSdp, mTimestamp,
mCallDurationMs, mIceRestarts, mIceRollbacks, mOfferer, mConfiguration);
mClosed, mSdpHistory, mPcid, mBrowserId, mTimestamp, mCallDurationMs,
mIceRestarts, mIceRollbacks, mOfferer, mConfiguration);
typedef mozilla::dom::RTCStats RTCStats;

4
dom/media/webrtc/jsapi/PeerConnectionImpl.cpp
View File

@ -3737,10 +3737,6 @@ RefPtr<dom::RTCStatsReportPromise> PeerConnectionImpl::GetStats(
mJsepSession->GetLocalDescription(kJsepDescriptionPendingOrCurrent);
std::string remoteDescription =
mJsepSession->GetRemoteDescription(kJsepDescriptionPendingOrCurrent);
report->mLocalSdp.Construct(
NS_ConvertASCIItoUTF16(localDescription.c_str()));
report->mRemoteSdp.Construct(
NS_ConvertASCIItoUTF16(remoteDescription.c_str()));
if (!report->mSdpHistory.AppendElements(mSdpHistory, fallible)) {
mozalloc_handle_oom(0);
}

2
dom/webidl/RTCStatsReport.webidl
View File

@ -311,8 +311,6 @@ dictionary RTCStatsReportInternal : RTCStatsCollection {
required unsigned long browserId;
RTCConfigurationInternal configuration;
DOMString jsepSessionErrors;
DOMString localSdp;
DOMString remoteSdp;
// TODO demux from RTCStatsReportInternal in bug 1830824
sequence<RTCSdpHistoryEntryInternal> sdpHistory = [];
required DOMHighResTimeStamp timestamp;