Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-03 10:33:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix crash due to accessing destroyed data previously owned by a rule node but cached on a style context that inherited it by clearing style data from style contexts before reresolution due to an inline style change. b=105619 sr=hyatt r=shaver

Browse Source
This commit is contained in:
dbaron%fas.harvard.edu 2001-12-08 22:46:21 +00:00
parent 08b53ca764
commit 8c0a6f79f1
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
content/base/src/nsStyleSet.cpp
View File

@ -1245,9 +1245,12 @@ StyleSetImpl::ClearStyleData(nsIPresContext* aPresContext, nsIStyleRule* aRule,
aContext->GetRuleNode(&ruleNode);
ruleNode->ClearCachedData(aRule);
// We don't need to mess with the style tree in this case, since the act of
// changing inline style attributes automatically causes re-resolution to a new style context
// (with new descendant style contexts as well).
// XXX We need to clear style data here in case there's a style context
// that inherits a struct from its parent where the parent uses data
// that's cached on the rule node. Otherwise we could crash while
// doing checks comparing old data to new data during reresolution.
// This could make some of those checks incorrect.
aContext->ClearStyleData(aPresContext, nsnull);
}
else {
// XXXdwh This is not terribly fast, but fortunately this case is rare (and often a full tree

9
layout/style/nsStyleSet.cpp
View File

@ -1245,9 +1245,12 @@ StyleSetImpl::ClearStyleData(nsIPresContext* aPresContext, nsIStyleRule* aRule,
aContext->GetRuleNode(&ruleNode);
ruleNode->ClearCachedData(aRule);
// We don't need to mess with the style tree in this case, since the act of
// changing inline style attributes automatically causes re-resolution to a new style context
// (with new descendant style contexts as well).
// XXX We need to clear style data here in case there's a style context
// that inherits a struct from its parent where the parent uses data
// that's cached on the rule node. Otherwise we could crash while
// doing checks comparing old data to new data during reresolution.
// This could make some of those checks incorrect.
aContext->ClearStyleData(aPresContext, nsnull);
}
else {
// XXXdwh This is not terribly fast, but fortunately this case is rare (and often a full tree