Bug 1605404 - Resolve DOM walker inside updateDetails action. r=rcaliman

Differential Revision: https://phabricator.services.mozilla.com/D58013

--HG--
extra : moz-landing-system : lando

devtools/client/accessibility/actions/details.js

@@ -8,18 +8,21 @@ const { UPDATE_DETAILS } = require("devtools/client/accessibility/constants");
 /**
  * Update details with the given accessible object.
  *
- * @param {Object} dom walker front
  * @param {Object} accessible front
  */
-exports.updateDetails = (domWalker, accessible) => dispatch =>
-  Promise.all([
-    domWalker.getNodeFromActor(accessible.actorID, [
-      "rawAccessible",
-      "DOMNode",
-    ]),
-    accessible.getRelations(),
-    accessible.audit(),
-    accessible.hydrate(),
-  ])
+exports.updateDetails = accessible => dispatch =>
+  accessible.targetFront
+    .getFront("inspector")
+    .then(({ walker: domWalker }) =>
+      Promise.all([
+        domWalker.getNodeFromActor(accessible.actorID, [
+          "rawAccessible",
+          "DOMNode",
+        ]),
+        accessible.getRelations(),
+        accessible.audit(),
+        accessible.hydrate(),
+      ])
+    )
     .then(response => dispatch({ accessible, type: UPDATE_DETAILS, response }))
     .catch(error => dispatch({ accessible, type: UPDATE_DETAILS, error }));

devtools/client/accessibility/components/AccessibilityRow.js

@@ -154,7 +154,7 @@ class AccessibilityRow extends Component {
     scrollIntoView(row);
   }
 
-  async update() {
+  update() {
     const {
       dispatch,
       member: { object },
@@ -163,8 +163,7 @@ class AccessibilityRow extends Component {
       return;
     }
 
-    const domWalker = (await object.targetFront.getFront("inspector")).walker;
-    dispatch(updateDetails(domWalker, object));
+    dispatch(updateDetails(object));
     window.emit(EVENTS.NEW_ACCESSIBLE_FRONT_SELECTED, object);
   }
 

devtools/client/accessibility/components/Accessible.js

@@ -185,16 +185,13 @@ class Accessible extends Component {
     }
   }
 
-  async update() {
+  update() {
     const { dispatch, accessibleFront } = this.props;
     if (!accessibleFront.actorID) {
       return;
     }
 
-    const domWalker = (await accessibleFront.targetFront.getFront("inspector"))
-      .walker;
-
-    dispatch(updateDetails(domWalker, accessibleFront));
+    dispatch(updateDetails(accessibleFront));
   }
 
   setExpanded(item, isExpanded) {