Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 02:14:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1626570 - Improve handling of copying arrays in netwerk/url-classifier/. r=dimi

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D72332
This commit is contained in:
Simon Giesecke 2020-04-30 09:41:04 +00:00
parent e0e0ad5019
commit 8d5dd3da2e
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
netwerk/url-classifier/UrlClassifierFeatureBase.cpp
View File

@ -122,7 +122,7 @@ UrlClassifierFeatureBase::GetTables(nsIUrlClassifierFeature::listType aListType,
return NS_ERROR_INVALID_ARG;
}
aTables = mTables[aListType];
aTables = mTables[aListType].Clone();
return NS_OK;
}

8
netwerk/url-classifier/UrlClassifierFeatureCustomTables.cpp
View File

@ -20,8 +20,8 @@ UrlClassifierFeatureCustomTables::UrlClassifierFeatureCustomTables(
const nsACString& aName, const nsTArray<nsCString>& aBlacklistTables,
const nsTArray<nsCString>& aWhitelistTables)
: mName(aName),
mBlacklistTables(aBlacklistTables),
mWhitelistTables(aWhitelistTables) {}
mBlacklistTables(aBlacklistTables.Clone()),
mWhitelistTables(aWhitelistTables.Clone()) {}
UrlClassifierFeatureCustomTables::~UrlClassifierFeatureCustomTables() = default;
@ -35,12 +35,12 @@ NS_IMETHODIMP
UrlClassifierFeatureCustomTables::GetTables(
nsIUrlClassifierFeature::listType aListType, nsTArray<nsCString>& aTables) {
if (aListType == nsIUrlClassifierFeature::blacklist) {
aTables = mBlacklistTables;
aTables = mBlacklistTables.Clone();
return NS_OK;
}
if (aListType == nsIUrlClassifierFeature::whitelist) {
aTables = mWhitelistTables;
aTables = mWhitelistTables.Clone();
return NS_OK;
}