Bug 1917158 - move some skip-if -> run-if for browser/components/**/browser.toml. r=sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,dao

Differential Revision: https://phabricator.services.mozilla.com/D221286

browser/components/privatebrowsing/test/browser/browser.toml

@@ -64,7 +64,7 @@ skip-if = [
 ["browser_privatebrowsing_cleanup.js"]
 
 ["browser_privatebrowsing_concurrent.js"]
-skip-if = ["release_or_beta"]
+run-if = ["!release_or_beta"]
 
 ["browser_privatebrowsing_context_and_chromeFlags.js"]
 

browser/components/screenshots/tests/browser/browser.toml

@@ -23,10 +23,8 @@ prefs = [
 skip-if = ["os == 'linux'"]
 
 ["browser_keyboard_shortcuts.js"]
-skip-if = [
-  "headless",
-  "display == 'wayland'" # sendNativeMouseEvent doesn't work on wayland
-]
+run-if = ["!headless"]
+skip-if = ["display == 'wayland'"] # sendNativeMouseEvent doesn't work on wayland
 
 ["browser_keyboard_tests.js"]
 
@@ -64,7 +62,7 @@ skip-if = [
 ["browser_screenshots_test_full_page.js"]
 
 ["browser_screenshots_test_page_crash.js"]
-skip-if = ["!crashreporter"]
+run-if = ["crashreporter"]
 
 ["browser_screenshots_test_screenshot_too_big.js"]
 

browser/components/sessionstore/test/browser.toml

@@ -251,14 +251,12 @@ skip-if = ["true"] #Bug 1455602
 
 ["browser_revive_crashed_bg_tabs.js"]
 https_first_disabled = true
-skip-if = ["!crashreporter"]
+run-if = ["crashreporter"]
 
 ["browser_scrollPositions.js"]
 https_first_disabled = true
-skip-if = [
-  "!fission",
-  "os == 'linux'", # Bug 1716445
-]
+run-if = ["fission"]
+skip-if = ["os == 'linux'"] # Bug 1716445
 
 ["browser_scrollPositionsReaderMode.js"]
 
@@ -294,7 +292,7 @@ skip-if = [
 https_first_disabled = true
 
 ["browser_tabicon_after_bg_tab_crash.js"]
-skip-if = ["!crashreporter"]
+run-if = ["crashreporter"]
 
 ["browser_tabs_in_urlbar.js"]
 https_first_disabled = true
@@ -305,7 +303,7 @@ skip-if = ["debug"]
 ["browser_undoCloseById_targetWindow.js"]
 
 ["browser_unrestored_crashedTabs.js"]
-skip-if = ["!crashreporter"]
+run-if = ["crashreporter"]
 
 ["browser_upgrade_backup.js"]
 skip-if = [

browser/components/sessionstore/test/browser_oldformat.toml

@@ -243,8 +243,8 @@ skip-if = [
 ["browser_624727.js"]
 
 ["browser_625016.js"]
+run-if = ["os != 'mac'"] # not running on macOS where closing all windows doesn't quit the application
 skip-if = [
-  "os == 'mac'", # Disabled on OS X:
   "os == 'linux'", # linux, Bug 1348583
   "os == 'win' && debug", # Bug 1430977
 ]

browser/components/shell/test/browser.toml

@@ -2,17 +2,15 @@
 
 ["browser_1119088.js"]
 support-files = ["mac_desktop_image.py"]
-skip-if = [
-  "os != 'mac'",
-  "verify",
-]
+run-if = ["os == 'mac'"]
+skip-if = ["verify"]
 tags = "os_integration"
 
 ["browser_420786.js"]
-skip-if = ["os != 'linux'"]
+run-if = ["os == 'linux'"]
 
 ["browser_633221.js"]
-skip-if = ["os != 'linux'"]
+run-if = ["os == 'linux'"]
 
 ["browser_doesAppNeedPin.js"]
 

browser/components/tabbrowser/test/browser/tabs/browser.toml

@@ -28,7 +28,7 @@ skip-if = [
 ]
 
 ["browser_bfcache_exemption_about_pages.js"]
-skip-if = ["!fission"]
+run-if = ["fission"]
 
 ["browser_blank_tab_label.js"]
 
@@ -190,7 +190,7 @@ https_first_disabled = true
 ["browser_multiselect_tabs_using_Shift_and_Ctrl.js"]
 
 ["browser_multiselect_tabs_using_keyboard.js"]
-skip-if = ["os == 'mac'"] # Skipped because macOS keyboard support requires changing system settings
+run-if = ["os != 'mac'"] # Skipped because macOS keyboard support requires changing system settings
 
 ["browser_multiselect_tabs_using_selectedTabs.js"]
 

browser/components/tests/browser/browser.toml

@@ -18,7 +18,7 @@ skip-if = ["os == 'linux'"]
 ["browser_browserGlue_userNamespacesNotification.js"]
 
 ["browser_bug538331.js"]
-skip-if = ["!updater"]
+run-if = ["updater"]
 reason = "test depends on update channel"
 
 ["browser_contentpermissionprompt.js"]
@@ -34,8 +34,7 @@ run-if = ["os == 'win'"]
 https_first_disabled = true
 
 ["browser_quit_disabled.js"]
-# On macOS we can't change browser.quitShortcut.disabled during runtime.
-skip-if = ["os == 'mac'"]
+run-if = ["os != 'mac'"] # On macOS we can't change browser.quitShortcut.disabled during runtime.
 
 ["browser_quit_multiple_tabs.js"]
 

browser/components/tests/browser/whats_new_page/browser.toml

@@ -1,8 +1,7 @@
 [DEFAULT]
-skip-if = [
-  "verify",
-  "os == 'win' && msix", # Updater is disabled in MSIX builds; what's new pages therefore have no meaning.
-]
+run-if = ["!msix"] # Updater is disabled in MSIX builds; what's new pages therefore have no meaning.
+skip-if = ["verify"]
+
 reason = "This is a startup test. Verify runs tests multiple times after startup."
 support-files = [
   "active-update.xml",

browser/components/urlbar/tests/browser-tips/browser.toml

@@ -19,13 +19,13 @@ https_first_disabled = true
 ["browser_selection.js"]
 
 ["browser_updateAsk.js"]
-skip-if = ["os == 'win' && msix"] # Updater is disabled in MSIX builds
+run-if = ["!msix"] # Updater is disabled in MSIX builds
 
 ["browser_updateRefresh.js"]
-skip-if = ["os == 'win' && msix"] # Updater is disabled in MSIX builds
+run-if = ["!msix"] # Updater is disabled in MSIX builds
 
 ["browser_updateRestart.js"]
-skip-if = ["os == 'win' && msix"] # Updater is disabled in MSIX builds
+run-if = ["!msix"] # Updater is disabled in MSIX builds
 
 ["browser_updateWeb.js"]
-skip-if = ["os == 'win' && msix"] # Updater is disabled in MSIX builds
+run-if = ["!msix"] # Updater is disabled in MSIX builds

browser/components/urlbar/tests/browser-tips/suppress-tips/browser.toml

@@ -1,10 +1,8 @@
 # This test environment is copied from "browser/components/tests/browser/whats_new_page/".
 
 [DEFAULT]
-skip-if = [
-  "verify",
-  "os == 'win' && msix", # Updater is disabled in MSIX builds; what's new pages therefore have no meaning.
-]
+run-if = ["!msix"] # Updater is disabled in MSIX builds
+skip-if = ["verify"]
 reason = "This is a startup test. Verify runs tests multiple times after startup."
 support-files = [
   "../head.js",

browser/components/urlbar/tests/browser/browser.toml

@@ -162,7 +162,7 @@ https_first_disabled = true
 ["browser_autocomplete_no_title.js"]
 
 ["browser_autocomplete_readline_navigation.js"]
-skip-if = ["os != 'mac'"] # Mac only feature
+run-if = ["os == 'mac'"] # Mac only feature
 
 ["browser_autocomplete_tag_star_visibility.js"]