Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 06:11:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

r=brendan,a=brendan. 54127. This change cleans up a leak when we run out of memory, and reduces allocation of the file extension buffer by 2x. it also dumps the count to a local variable to do away w/ memory ambiguity using a pointer to elementCount

Browse Source
This commit is contained in:
valeski%netscape.com 2000-09-27 19:50:59 +00:00
parent 4a62f9220b
commit 8e3f2ce2da
2 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
netwerk/mime/src/nsMIMEInfoImpl.cpp
View File

@ -46,18 +46,24 @@ nsMIMEInfoImpl::GetExtCount() {
NS_IMETHODIMP
nsMIMEInfoImpl::GetFileExtensions(PRUint32 *elementCount, char ***extensions) {
*elementCount = mExtensions.Count();
if (*elementCount < 1) return NS_OK;;
PRUint32 count = mExtensions.Count();
if (count < 1) return NS_OK;
char **_retExts = (char**)nsMemory::Alloc((*elementCount)*2*sizeof(char*));
char **_retExts = (char**)nsMemory::Alloc((count)*sizeof(char*));
if (!_retExts) return NS_ERROR_OUT_OF_MEMORY;
for (PRUint8 i=0; i < *elementCount; i++) {
for (PRUint8 i=0; i < count; i++) {
nsCString* ext = mExtensions.CStringAt(i);
_retExts[i] = ext->ToNewCString();
if (!_retExts[i]) return NS_ERROR_OUT_OF_MEMORY;
if (!_retExts[i]) {
// clean up all the strings we've allocated
while (i-- != 0) nsMemory::Free(_retExts[i]);
nsMemory::Free(_retExts);
return NS_ERROR_OUT_OF_MEMORY;
}
}
*elementCount = count;
*extensions = _retExts;
return NS_OK;

16
uriloader/exthandler/nsMIMEInfoImpl.cpp
View File

@ -46,18 +46,24 @@ nsMIMEInfoImpl::GetExtCount() {
NS_IMETHODIMP
nsMIMEInfoImpl::GetFileExtensions(PRUint32 *elementCount, char ***extensions) {
*elementCount = mExtensions.Count();
if (*elementCount < 1) return NS_OK;;
PRUint32 count = mExtensions.Count();
if (count < 1) return NS_OK;
char **_retExts = (char**)nsMemory::Alloc((*elementCount)*2*sizeof(char*));
char **_retExts = (char**)nsMemory::Alloc((count)*sizeof(char*));
if (!_retExts) return NS_ERROR_OUT_OF_MEMORY;
for (PRUint8 i=0; i < *elementCount; i++) {
for (PRUint8 i=0; i < count; i++) {
nsCString* ext = mExtensions.CStringAt(i);
_retExts[i] = ext->ToNewCString();
if (!_retExts[i]) return NS_ERROR_OUT_OF_MEMORY;
if (!_retExts[i]) {
// clean up all the strings we've allocated
while (i-- != 0) nsMemory::Free(_retExts[i]);
nsMemory::Free(_retExts);
return NS_ERROR_OUT_OF_MEMORY;
}
}
*elementCount = count;
*extensions = _retExts;
return NS_OK;