Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-08 16:03:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1556987 - Invalid assertion in nsHttpChannel::OnPush, r=dragana

Browse Source 
NS_HTTP_ONPUSH_LISTENER capability is set in nsHttpChannel::SetupTransaction when notification callbacks implement nsIHttpPushListener, but nsHttpChannel::OnPush event is initiated on socket thread in Http2PushedStream::TryOnPush and the channel can be closed and listeners released before nsHttpChannel::OnPush is called on the main thread.

Differential Revision: https://phabricator.services.mozilla.com/D33776

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Michal Novotny 2019-06-06 06:35:50 +00:00
parent 66a7ddb52a
commit 8e84b11096
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
netwerk/protocol/http/nsHttpChannel.cpp
View File

@ -9276,13 +9276,12 @@ nsresult nsHttpChannel::OnPush(const nsACString& url,
NS_GET_IID(nsIHttpPushListener),
getter_AddRefs(pushListener));
MOZ_ASSERT(pushListener);
if (!pushListener) {
LOG(
("nsHttpChannel::OnPush [this=%p] notification callbacks do not "
"implement nsIHttpPushListener\n",
this));
return NS_ERROR_UNEXPECTED;
return NS_ERROR_NOT_AVAILABLE;
}
nsCOMPtr<nsIURI> pushResource;