Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 20:05:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1307227 - Add a runtime check for when the profiler button is enabled and checked; r=julienw

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D31663

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Greg Tatum 2019-05-31 15:54:25 +00:00
parent eccc1fe1ef
commit 8ed1db88b3
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
devtools/client/framework/devtools-browser.js
View File

@ -25,6 +25,7 @@ loader.lazyRequireGetter(this, "DebuggerClient", "devtools/shared/client/debugge
loader.lazyRequireGetter(this, "BrowserMenus", "devtools/client/framework/browser-menus");
loader.lazyRequireGetter(this, "appendStyleSheet", "devtools/client/shared/stylesheet-utils", true);
loader.lazyRequireGetter(this, "ResponsiveUIManager", "devtools/client/responsive.html/manager", true);
loader.lazyRequireGetter(this, "AppConstants", "resource://gre/modules/AppConstants.jsm", true);
loader.lazyImporter(this, "BrowserToolboxProcess", "resource://devtools/client/framework/ToolboxProcess.jsm");
loader.lazyImporter(this, "ScratchpadManager", "resource://devtools/client/scratchpad/scratchpad-manager.jsm");
@ -113,6 +114,25 @@ var gDevToolsBrowser = exports.gDevToolsBrowser = {
} catch (e) {
// devtools.recordreplay.enabled only exists on certain platforms.
}
// The profiler's popup is experimental. The plan is to eventually turn it on
// everywhere, but while it's under active development we don't want everyone
// having it enabled. For now the default pref is to turn it on with Nightly,
// with the option to flip the pref in other releases. This feature flag will
// go away once it is fully shipped.
const isPopupFeatureFlagEnabled = Services.prefs.getBoolPref(
"devtools.performance.popup.feature-flag", AppConstants.NIGHTLY_BUILD);
// If the feature flag is disabled, hide the menu item.
toggleMenuItem("menu_toggleProfilerButtonMenu", isPopupFeatureFlagEnabled);
if (isPopupFeatureFlagEnabled) {
// Did the user enable the profiler button in the menu? If it is then update the
// initial UI to show the menu item as checked.
if (Services.prefs.getBoolPref("devtools.performance.popup.enabled", false)) {
const cmd = doc.getElementById("menu_toggleProfilerButtonMenu");
cmd.setAttribute("checked", "true");
}
}
},
/**