Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-27 07:34:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1339555 - Make various operator-news into a known-non-null pointer use a ::operator new overload that odesn't null-check. r=froydnj

Browse Source 
--HG--
extra : rebase_source : cad3ffa778db607bb2ccee2ac42671e60d3c8160
This commit is contained in:
Jeff Walden 2017-02-14 11:23:18 -08:00
parent a23c031c73
commit 8f8272ae04
3 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mfbt/Maybe.h
View File

@ -13,6 +13,7 @@
#include "mozilla/Assertions.h"
#include "mozilla/Attributes.h"
#include "mozilla/Move.h"
#include "mozilla/OperatorNewExtensions.h"
#include "mozilla/TypeTraits.h"
#include <new> // for placement new
@ -458,7 +459,7 @@ public:
void emplace(Args&&... aArgs)
{
MOZ_ASSERT(!mIsSome);
::new (mStorage.addr()) T(Forward<Args>(aArgs)...);
::new (KnownNotNull, mStorage.addr()) T(Forward<Args>(aArgs)...);
mIsSome = true;
}

3
mfbt/MaybeOneOf.h
View File

@ -14,6 +14,7 @@
#include "mozilla/Assertions.h"
#include "mozilla/Move.h"
#include "mozilla/OperatorNewExtensions.h"
#include "mozilla/TemplateLib.h"
#include <new> // for placement new
@ -105,7 +106,7 @@ public:
{
MOZ_ASSERT(state == None);
state = Type2State<T>::result;
::new (data()) T(Forward<Args>(aArgs)...);
::new (KnownNotNull, data()) T(Forward<Args>(aArgs)...);
}
template <class T>

19
mfbt/Variant.h
View File

@ -11,6 +11,7 @@
#include "mozilla/Assertions.h"
#include "mozilla/Move.h"
#include "mozilla/OperatorNewExtensions.h"
#include "mozilla/TemplateLib.h"
#include "mozilla/TypeTraits.h"
@ -179,12 +180,12 @@ struct VariantImplementation<Tag, N, T>
template<typename Variant>
static void copyConstruct(void* aLhs, const Variant& aRhs) {
new (aLhs) T(aRhs.template as<T>());
::new (KnownNotNull, aLhs) T(aRhs.template as<T>());
}
template<typename Variant>
static void moveConstruct(void* aLhs, Variant&& aRhs) {
new (aLhs) T(aRhs.template extract<T>());
::new (KnownNotNull, aLhs) T(aRhs.template extract<T>());
}
template<typename Variant>
@ -222,7 +223,7 @@ struct VariantImplementation<Tag, N, T, Ts...>
template<typename Variant>
static void copyConstruct(void* aLhs, const Variant& aRhs) {
if (aRhs.template is<T>()) {
new (aLhs) T(aRhs.template as<T>());
::new (KnownNotNull, aLhs) T(aRhs.template as<T>());
} else {
Next::copyConstruct(aLhs, aRhs);
}
@ -231,7 +232,7 @@ struct VariantImplementation<Tag, N, T, Ts...>
template<typename Variant>
static void moveConstruct(void* aLhs, Variant&& aRhs) {
if (aRhs.template is<T>()) {
new (aLhs) T(aRhs.template extract<T>());
::new (KnownNotNull, aLhs) T(aRhs.template extract<T>());
} else {
Next::moveConstruct(aLhs, aRhs);
}
@ -485,7 +486,7 @@ public:
explicit Variant(RefT&& aT)
: tag(Impl::template tag<T>())
{
new (ptr()) T(Forward<RefT>(aT));
::new (KnownNotNull, ptr()) T(Forward<RefT>(aT));
}
/**
@ -498,7 +499,7 @@ public:
MOZ_IMPLICIT Variant(detail::AsVariantTemporary<RefT>&& aValue)
: tag(Impl::template tag<T>())
{
new (ptr()) T(Move(aValue.mValue));
::new (KnownNotNull, ptr()) T(Move(aValue.mValue));
}
/** Copy construction. */
@ -519,7 +520,7 @@ public:
Variant& operator=(const Variant& aRhs) {
MOZ_ASSERT(&aRhs != this, "self-assign disallowed");
this->~Variant();
new (this) Variant(aRhs);
::new (KnownNotNull, this) Variant(aRhs);
return *this;
}
@ -527,7 +528,7 @@ public:
Variant& operator=(Variant&& aRhs) {
MOZ_ASSERT(&aRhs != this, "self-assign disallowed");
this->~Variant();
new (this) Variant(Move(aRhs));
::new (KnownNotNull, this) Variant(Move(aRhs));
return *this;
}
@ -536,7 +537,7 @@ public:
Variant& operator=(detail::AsVariantTemporary<T>&& aValue)
{
this->~Variant();
new (this) Variant(Move(aValue));
::new (KnownNotNull, this) Variant(Move(aValue));
return *this;
}