From 8ff0769a7b01774e4a33bf7eeecadff3c6033080 Mon Sep 17 00:00:00 2001
From: "mozilla.mano%sent.com" <mozilla.mano%sent.com>
Date: Wed, 14 Sep 2005 17:22:11 +0000
Subject: [PATCH] Bug 303152 - Update prefs UI is broken. rs=mscott.

---
 mail/components/preferences/advanced.js  | 29 ++++++++++++------------
 mail/components/preferences/advanced.xul | 24 ++++++++------------
 2 files changed, 24 insertions(+), 29 deletions(-)

diff --git a/mail/components/preferences/advanced.js b/mail/components/preferences/advanced.js
index 87df62958bad..13e2ca8a82f0 100644
--- a/mail/components/preferences/advanced.js
+++ b/mail/components/preferences/advanced.js
@@ -91,23 +91,22 @@ var gAdvancedPane = {
    * 
    * UI Components:                                     Preferences
    * 1 = Thunderbird checkbox                               i   = app.update.enabled
-   * 2 = Check Now button for Firefox                       ii  = app.update.auto
-   * 3 = When updates for Thunderbird are found label       iii = app.update.mode
-   * 4 = Automatic Radiogroup (Ask vs. Automatically)
-   * 5 = Warn before disabling extensions checkbox
+   * 2 = When updates for Thunderbird are found label       ii  = app.update.auto
+   * 3 = Automatic Radiogroup (Ask vs. Automatically)       iii = app.update.mode
+   * 4 = Warn before disabling extensions checkbox
    * 
    * States:
    * Element     p   val     locked    Disabled 
-   * 1,2         i   t/f     f         false 
+   * 1           i   t/f     f         false 
    *             i   t/f     t         true
    *             ii  t/f     t/f       false
    *             iii 0/1/2   t/f       false
-   * 3,4         i   t       t/f       false
+   * 2,3         i   t       t/f       false
    *             i   f       t/f       true
    *             ii  t/f     f         false
    *             ii  t/f     t         true
    *             iii 0/1/2   t/f       false
-   * 5           i   t       t/f       false
+   * 4           i   t       t/f       false
    *             i   f       t/f       true
    *             ii  t       t/f       false
    *             ii  f       t/f       true
@@ -122,10 +121,9 @@ var gAdvancedPane = {
         getService(Components.interfaces.nsIApplicationUpdateService);
 
     var enabledPref = document.getElementById("app.update.enabled");
-    
     var enableAppUpdate = document.getElementById("enableAppUpdate");
-    var appCheckNowButton = document.getElementById("appCheckNowButton");
-    appCheckNowButton.disabled = enableAppUpdate.disabled = !aus.canUpdate;
+
+    enableAppUpdate.disabled = !aus.canUpdate || enabledPref.locked;
   },
   
   updateAutoItems: function () 
@@ -136,7 +134,8 @@ var gAdvancedPane = {
     var updateModeLabel = document.getElementById("updateModeLabel");
     var updateMode = document.getElementById("updateMode");
     
-    var disable = !enabledPref.value || autoPref.locked;
+    var disable = enabledPref.locked || !enabledPref.value ||
+                  autoPref.locked;
     updateModeLabel.disabled = updateMode.disabled = disable;
   },
 
@@ -148,7 +147,8 @@ var gAdvancedPane = {
     
     var warnIncompatible = document.getElementById("warnIncompatible");
     
-    var disable = !enabledPref.value || !autoPref.value || modePref.locked;
+    var disable = enabledPref.locked || !enabledPref.value || autoPref.locked ||
+                  !autoPref.value || modePref.locked;
     warnIncompatible.disabled = disable;
   },
 
@@ -159,10 +159,9 @@ var gAdvancedPane = {
   updateAddonUpdateUI: function ()
   {
     var enabledPref = document.getElementById("extensions.update.enabled");
-    
     var enableAddonUpdate = document.getElementById("enableAddonUpdate");
-    var addonCheckNowButton = document.getElementById("addonCheckNowButton");
-    enableAddonUpdate.disabled = addonCheckNowButton.disabled = enabledPref.locked;
+
+    enableAddonUpdate.disabled = enabledPref.locked;
   },  
 
   /**
diff --git a/mail/components/preferences/advanced.xul b/mail/components/preferences/advanced.xul
index 097c228a99d4..3f0441588229 100644
--- a/mail/components/preferences/advanced.xul
+++ b/mail/components/preferences/advanced.xul
@@ -198,20 +198,16 @@
         <tabpanel orient="vertical" align="start">
           <label>&autoCheck.label;</label>
           <vbox class="indent">
-            <hbox>
-              <checkbox id="enableAppUpdate"
-                        label="&enableAppUpdate.label;"
-                        accesskey="&enableAppUpdate.accesskey;"
-                        preference="app.update.enabled"
-                        xhtml2:role="wairole:checkbox" aaa:describedby="updateInfo"/>
-            </hbox>
-            <hbox>
-              <checkbox id="enableAddonUpdate"
-                        label="&enableExtensionUpdate.label;"
-                        accesskey="&enableExtensionUpdate.accesskey;"
-                        preference="extensions.update.enabled"
-                        xhtml2:role="wairole:checkbox" aaa:describedby="updateInfo"/>
-            </hbox>
+            <checkbox id="enableAppUpdate"
+                      label="&enableAppUpdate.label;"
+                      accesskey="&enableAppUpdate.accesskey;"
+                      preference="app.update.enabled"
+                      xhtml2:role="wairole:checkbox" aaa:describedby="updateInfo"/>
+            <checkbox id="enableAddonUpdate"
+                      label="&enableExtensionUpdate.label;"
+                      accesskey="&enableExtensionUpdate.accesskey;"
+                      preference="extensions.update.enabled"
+                      xhtml2:role="wairole:checkbox" aaa:describedby="updateInfo"/>
           </vbox>
           <separator/>
           <label id="updateModeLabel">&whenUpdatesFound.label;</label>