Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1716959 - Don't use lock from profiler_capture_backtrace_into - r=canaltinova

Browse Source 
`profiler_capture_backtrace_into` now only uses thread-safe functions: ThreadRegistration::WithOnThreadRefOf, Register::SyncPopulate, DoSyncSample.
So we don't need to lock the main profiler mutex anymore.

This means that on-thread sampling (typically used in markers) can happen at the same time the periodic sampler has locked the profiler mutex and is sampling this and other threads.

Differential Revision: https://phabricator.services.mozilla.com/D122089
This commit is contained in:
Gerald Squelart 2021-08-25 00:56:01 +00:00
parent ca8279e285
commit 90bd552555
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/profiler/core/platform.cpp
View File

@ -5512,8 +5512,6 @@ bool profiler_capture_backtrace_into(ProfileChunkedBuffer& aChunkedBuffer,
StackCaptureOptions aCaptureOptions) {
MOZ_RELEASE_ASSERT(CorePS::Exists());
PSAutoLock lock;
if (!profiler_is_active() ||
aCaptureOptions == StackCaptureOptions::NoStack) {
return false;