Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 10:44:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1704876 - Fix a shutdown crash when we race to update an animated vector image. r=tnikkel

Browse Source 
If we are shutting down, the document for a VectorImage may be cleared.
If a refresh tick raced with the shutdown, we might try to deref the
null document.

Differential Revision: https://phabricator.services.mozilla.com/D132953
This commit is contained in:
Andrew Osmond 2021-12-07 03:10:10 +00:00
parent 00d79258e2
commit 90fb928d6b
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
image/VectorImage.cpp
View File

@ -481,8 +481,13 @@ VectorImage::RequestRefresh(const TimeStamp& aTime) {
return;
}
PendingAnimationTracker* tracker =
mSVGDocumentWrapper->GetDocument()->GetPendingAnimationTracker();
Document* doc = mSVGDocumentWrapper->GetDocument();
if (!doc) {
// We are racing between shutdown and a refresh.
return;
}
PendingAnimationTracker* tracker = doc->GetPendingAnimationTracker();
if (tracker && ShouldAnimate()) {
tracker->TriggerPendingAnimationsOnNextTick(aTime);
}