Bug 1587206 - [lint.flake8] Enable E117 across the tree, r=sylvestre

Prevents over-indentation.

Depends on D48611

Differential Revision: https://phabricator.services.mozilla.com/D48612

--HG--
extra : moz-landing-system : lando

.flake8

@@ -93,7 +93,7 @@ exclude =
 #   - http://pep8.readthedocs.io/en/latest/intro.html#configuration
 ignore =
     # These should be triaged and either fixed or moved to the list below.
-    E117, W504, W605, W606,
+    W504, W605, W606,
     # These are intentionally disabled (not necessarily for good reason).
     #   F723: syntax error in type comment
     #       text contains quotes which breaks our custom JSON formatter

python/mozbuild/mozbuild/frontend/gyp_reader.py

@@ -202,8 +202,8 @@ def process_gyp_result(gyp_result, gyp_dir_attrs, path, config, output,
             if not ('actions' in spec or 'copies' in spec):
                 continue
         elif spec['type'] in ('static_library', 'shared_library', 'executable'):
-                # Remove leading 'lib' from the target_name if any, and use as
-                # library name.
+            # Remove leading 'lib' from the target_name if any, and use as
+            # library name.
             name = spec['target_name']
             if spec['type'] in ('static_library', 'shared_library'):
                 if name.startswith('lib'):

taskcluster/taskgraph/target_tasks.py

@@ -405,9 +405,9 @@ def target_tasks_ship_desktop(full_task_graph, parameters, graph_config):
             return False
 
         if 'secondary' in task.kind:
-                return is_rc
+            return is_rc
         else:
-                return not is_rc
+            return not is_rc
 
     return [l for l, t in full_task_graph.tasks.iteritems() if filter(t)]
 

testing/geckodriver/mach_commands.py

@@ -42,12 +42,12 @@ class GeckoDriver(MachCommandBase):
         try:
             binpath = self.get_binary_path("geckodriver")
         except Exception as e:
-                print("It looks like geckodriver isn't built. "
-                      "Add ac_add_options --enable-geckodriver to your "
-                      "mozconfig ",
-                      "and run |mach build| to build it.")
-                print(e)
-                return 1
+            print("It looks like geckodriver isn't built. "
+                  "Add ac_add_options --enable-geckodriver to your "
+                  "mozconfig ",
+                  "and run |mach build| to build it.")
+            print(e)
+            return 1
 
         args = [binpath]
 

testing/mozharness/scripts/marionette.py

@@ -176,8 +176,8 @@ class MarionetteTest(TestingMixin, MercurialScript, TransferMixin,
     def _pre_config_lock(self, rw_config):
         super(MarionetteTest, self)._pre_config_lock(rw_config)
         if not self.config.get('emulator') and not self.config.get('marionette_address'):
-                self.fatal("You need to specify a --marionette-address for non-emulator tests! "
-                           "(Try --marionette-address localhost:2828 )")
+            self.fatal("You need to specify a --marionette-address for non-emulator tests! "
+                       "(Try --marionette-address localhost:2828 )")
 
     def _query_tests_dir(self):
         dirs = self.query_abs_dirs()

testing/raptor/test/test_raptor.py

@@ -20,18 +20,18 @@ from raptor.raptor import RaptorDesktopFirefox, RaptorDesktopChrome, RaptorAndro
 
 
 class TestBrowserThread(threading.Thread):
-        def __init__(self, raptor_instance, tests, names):
-            super(TestBrowserThread, self).__init__()
-            self.raptor_instance = raptor_instance
-            self.tests = tests
-            self.names = names
-            self.exc = None
+    def __init__(self, raptor_instance, tests, names):
+        super(TestBrowserThread, self).__init__()
+        self.raptor_instance = raptor_instance
+        self.tests = tests
+        self.names = names
+        self.exc = None
 
-        def run(self):
-            try:
-                self.raptor_instance.run_tests(self.tests, self.names)
-            except BaseException:
-                self.exc = sys.exc_info()
+    def run(self):
+        try:
+            self.raptor_instance.run_tests(self.tests, self.names)
+        except BaseException:
+            self.exc = sys.exc_info()
 
 
 @pytest.mark.parametrize("raptor_class, app_name", [