Bug 1664394 - rename linux64-civet-tidy to linux64-external-tidy;r=andi

Differential Revision: https://phabricator.services.mozilla.com/D90158

build/clang-plugin/external/ExternalChecks.inc

@@ -3,6 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 // Placeholder file to be overwritten with external checks during build
-// The list of checker classes that are compatible with civet-tidy.
+// The list of checker classes that are compatible with clang-tidy-external.
 
 // CHECK(ExternalChecker, "external-checker")

build/clang-plugin/external/ExternalIncludes.inc

@@ -4,6 +4,6 @@
 
 // Placeholder file to be overwritten with external checks during build
 // The list of #include directives necessary for the checker classes that
-// are compatible with civet-tidy.
+// are compatible with clang-tidy-external.
 
 // #include "ExternalChecker.h"

taskcluster/ci/source-test/clang.yml

@@ -82,12 +82,12 @@ format:
               name: public/code-review/clang-format.diff
               path: /builds/worker/clang-format.diff
 
-civet:
+external:
     description: Run static-analysis (clang-tidy) on C/C++ patches with external checks
     attributes:
         code-review: false
     treeherder:
-        symbol: cpp(clang-civet)
+        symbol: cpp(clang-tidy-external)
     run:
         cwd: '{checkout}'
         command: >-
@@ -95,7 +95,7 @@ civet:
             ./mach --log-no-times static-analysis check --checks="-*,mozilla-civet-*" --outgoing --output $HOME/clang-tidy.json --format json
     fetches:
         toolchain:
-            - linux64-civet-tidy
+            - linux-clang-tidy-external
     worker:
         artifacts:
             - type: file

taskcluster/ci/toolchain/clang-tidy.yml

@@ -97,13 +97,13 @@ win64-clang-tidy:
             - cmake
             - ninja
 
-linux64-civet-tidy:
+linux-clang-tidy-external:
     attributes:
         local-toolchain: false
     index:
-        job-name: linux64-civet-tidy
+        job-name: linux-clang-tidy-external
     treeherder:
-        symbol: TL(linux64-civet-tidy)
+        symbol: TL(linux-clang-tidy-external)
     worker:
         artifacts:
             - name: project/civet/clang-tidy.tar.zst
@@ -111,11 +111,11 @@ linux64-civet-tidy:
               type: file
     run:
         toolchain-artifact: project/civet/clang-tidy.tar.zst
-        script: build-civet.sh
+        script: build-clang-tidy-external.sh
         arguments:
-            - 'build/build-clang/civet-tidy-linux64.json'
+            - 'build/build-clang/clang-tidy-external-linux64.json'
         resources:
-            - 'build/build-clang/civet-tidy-linux64.json'
+            - 'build/build-clang/clang-tidy-external-linux64.json'
     run-on-projects: []
     fetches:
         fetch:

taskcluster/scripts/misc/build-clang-tidy-external.sh

@@ -7,7 +7,7 @@ export UPLOAD_DIR="/builds/worker/private-artifacts/"
 # # Delete the external directory
 rm -rf $GECKO_PATH/build/clang-plugin/external/*
 
-# # Move civet into its place
+# Move external repository into its place
 cp -r $MOZ_FETCHES_DIR/civet.git/* $GECKO_PATH/build/clang-plugin/external
 
 # Call build-clang.sh with this script's first argument (our JSON config)