Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1787290 - Cache isDefaultBrowser in ASRouter targeting r=Mardak

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D155646
This commit is contained in:
Barret Rennie 2022-08-30 05:07:45 +00:00
parent 4ef6742cb2
commit 91c6564f53
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
browser/components/newtab/lib/ASRouterTargeting.jsm
View File

@ -277,6 +277,12 @@ const QueryCache = {
FRECENT_SITES_UPDATE_INTERVAL,
ShellService
),
isDefaultBrowser: new CachedTargetingGetter(
"isDefaultBrowser",
null,
FRECENT_SITES_UPDATE_INTERVAL,
ShellService
),
currentThemes: new CachedTargetingGetter(
"getAddonsByTypes",
["theme"],
@ -506,10 +512,7 @@ const TargetingGetters = {
});
},
get isDefaultBrowser() {
try {
return ShellService.isDefaultBrowser();
} catch (e) {}
return null;
return QueryCache.getters.isDefaultBrowser.get().catch(() => null);
},
get devToolsOpenedCount() {
return lazy.devtoolsSelfXSSCount;

2
browser/components/newtab/test/browser/browser_asrouter_targeting.js
View File

@ -355,7 +355,7 @@ add_task(async function checksearchEngines() {
add_task(async function checkisDefaultBrowser() {
const expected = ShellService.isDefaultBrowser();
const result = ASRouterTargeting.Environment.isDefaultBrowser;
const result = await ASRouterTargeting.Environment.isDefaultBrowser;
is(typeof result, "boolean", "isDefaultBrowser should be a boolean value");
is(
result,