Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 01:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1365124 - 3. Don't call getGeckoInterface() in enableSensor/disableSensor/loadPluginClass; r=me

Browse Source 
GeckoAppShell.enableSensor/disableSensor/loadPluginClass don't make use
of the GeckoInterface instance, so get rid of the getGeckoInterface()
call. r=me for trivial patch.

MozReview-Commit-ID: 24PwdQqO0oq
This commit is contained in:
Jim Chen 2017-05-18 17:40:32 -04:00
parent 1cd93ec6b6
commit 91d00481cb
1 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
View File

@ -634,19 +634,14 @@ public class GeckoAppShell
@WrapForJNI(calledFrom = "gecko")
private static void enableSensor(int aSensortype) {
GeckoInterface gi = getGeckoInterface();
if (gi == null) {
return;
}
SensorManager sm = (SensorManager)
final SensorManager sm = (SensorManager)
getApplicationContext().getSystemService(Context.SENSOR_SERVICE);
switch (aSensortype) {
case GeckoHalDefines.SENSOR_GAME_ROTATION_VECTOR:
if (gGameRotationVectorSensor == null) {
gGameRotationVectorSensor = sm.getDefaultSensor(15);
// sm.getDefaultSensor(
// Sensor.TYPE_GAME_ROTATION_VECTOR); // API >= 18
gGameRotationVectorSensor = sm.getDefaultSensor(
Sensor.TYPE_GAME_ROTATION_VECTOR);
}
if (gGameRotationVectorSensor != null) {
sm.registerListener(getSensorListener(),
@ -750,11 +745,7 @@ public class GeckoAppShell
@WrapForJNI(calledFrom = "gecko")
private static void disableSensor(int aSensortype) {
GeckoInterface gi = getGeckoInterface();
if (gi == null)
return;
SensorManager sm = (SensorManager)
final SensorManager sm = (SensorManager)
getApplicationContext().getSystemService(Context.SENSOR_SERVICE);
switch (aSensortype) {
@ -1642,8 +1633,6 @@ public class GeckoAppShell
@WrapForJNI
private static Class<?> loadPluginClass(String className, String libName) {
if (getGeckoInterface() == null)
return null;
try {
final String packageName = getPluginPackage(libName);
final int contextFlags = Context.CONTEXT_INCLUDE_CODE | Context.CONTEXT_IGNORE_SECURITY;