Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 09:45:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

servo: Merge #7691 - Remove deprecated 'creator' WebIDL attribute (from frewsxcv:rm-creator-webidl-attribute); r=nox

Browse Source 
According to @Ms2ger, the 'creator' attribute was merged into 'setter'

Source-Repo: https://github.com/servo/servo
Source-Revision: 291fa888326e743a1e59aa7c06d5288a0643cbb7
This commit is contained in:
Corey Farwell 2015-09-21 05:45:30 -06:00
parent 7eef01d9ec
commit 91eafe9f20
9 changed files with 6 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
servo/components/script/dom/bindings/codegen/CodegenRust.py
View File

@ -4156,8 +4156,6 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
indexedSetter = self.descriptor.operations['IndexedSetter']
if indexedSetter:
if self.descriptor.operations['IndexedCreator'] != indexedSetter:
raise TypeError("Can't handle creator that's different from the setter")
set += ("let index = get_array_index_from_id(cx, id);\n" +
"if let Some(index) = index {\n" +
" let this = UnwrapProxy(proxy);\n" +
@ -4173,8 +4171,6 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
namedSetter = self.descriptor.operations['NamedSetter']
if namedSetter:
if self.descriptor.operations['NamedCreator'] != namedSetter:
raise TypeError("Can't handle creator that's different from the setter")
set += ("if RUST_JSID_IS_STRING(id) != 0 {\n" +
CGIndenter(CGProxyNamedSetter(self.descriptor)).define() +
" (*opresult).code_ = 0; /* SpecialCodes::OkCode */\n" +

2
servo/components/script/dom/bindings/codegen/Configuration.py
View File

@ -179,11 +179,9 @@ class Descriptor(DescriptorProvider):
self.operations = {
'IndexedGetter': None,
'IndexedSetter': None,
'IndexedCreator': None,
'IndexedDeleter': None,
'NamedGetter': None,
'NamedSetter': None,
'NamedCreator': None,
'NamedDeleter': None,
'Stringifier': None,
}

5
servo/components/script/dom/domstringmap.rs
View File

@ -35,11 +35,6 @@ impl DOMStringMap {
// https://html.spec.whatwg.org/#domstringmap
impl DOMStringMapMethods for DOMStringMap {
// https://html.spec.whatwg.org/multipage/#dom-domstringmap-additem
fn NamedCreator(&self, name: DOMString, value: DOMString) -> ErrorResult {
self.NamedSetter(name, value)
}
// https://html.spec.whatwg.org/multipage/#dom-domstringmap-removeitem
fn NamedDeleter(&self, name: DOMString) {
let element = self.element.root();

4
servo/components/script/dom/storage.rs
View File

@ -131,10 +131,6 @@ impl StorageMethods for Storage {
self.SetItem(name, value);
}
fn NamedCreator(&self, name: DOMString, value: DOMString) {
self.SetItem(name, value);
}
fn NamedDeleter(&self, name: DOMString) {
self.RemoveItem(name);
}

2
servo/components/script/dom/testbindingproxy.rs
View File

@ -23,12 +23,10 @@ impl TestBindingProxyMethods for TestBindingProxy {
fn SetItem(&self, _: u32, _: DOMString) -> () {}
fn RemoveItem(&self, _: DOMString) -> () {}
fn Stringifier(&self) -> DOMString { "".to_owned() }
fn NamedCreator(&self, _: DOMString, _: DOMString) -> () {}
fn IndexedGetter(&self, _: u32, _: &mut bool) -> DOMString { "".to_owned() }
fn NamedDeleter(&self, _: DOMString) -> () {}
fn IndexedSetter(&self, _: u32, _: DOMString) -> () {}
fn NamedSetter(&self, _: DOMString, _: DOMString) -> () {}
fn IndexedCreator(&self, _: u32, _: DOMString) -> () {}
fn NamedGetter(&self, _: DOMString, _: &mut bool) -> DOMString { "".to_owned() }
}

2
servo/components/script/dom/webidls/DOMStringMap.webidl
View File

@ -8,6 +8,6 @@
interface DOMStringMap {
getter DOMString (DOMString name);
[Throws]
setter creator void (DOMString name, DOMString value);
setter void (DOMString name, DOMString value);
deleter void (DOMString name);
};

2
servo/components/script/dom/webidls/HTMLSelectElement.webidl
View File

@ -23,7 +23,7 @@ interface HTMLSelectElement : HTMLElement {
void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
//void remove(); // ChildNode overload
//void remove(long index);
//setter creator void (unsigned long index, HTMLOptionElement? option);
//setter void (unsigned long index, HTMLOptionElement? option);
//readonly attribute HTMLCollection selectedOptions;
// attribute long selectedIndex;

4
servo/components/script/dom/webidls/Storage.webidl
View File

@ -4,7 +4,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
/*
* The origin of this IDL file is
* https://html.spec.whatwg.org/multipage/#webstorage
* https://html.spec.whatwg.org/multipage/#the-storage-interface
*
*/
@ -16,7 +16,7 @@ interface Storage {
getter DOMString? getItem(DOMString name);
setter creator void setItem(DOMString name, DOMString value);
setter void setItem(DOMString name, DOMString value);
deleter void removeItem(DOMString name);

4
servo/components/script/dom/webidls/TestBindingProxy.webidl
View File

@ -17,11 +17,11 @@ interface TestBindingProxy : TestBinding {
getter DOMString getNamedItem(DOMString item_name);
setter creator void setNamedItem(DOMString item_name, DOMString value);
setter void setNamedItem(DOMString item_name, DOMString value);
getter DOMString getItem(unsigned long index);
setter creator void setItem(unsigned long index, DOMString value);
setter void setItem(unsigned long index, DOMString value);
deleter void removeItem(DOMString name);