Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-01 05:43:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1689285 - Fix test_visibility.xhtml to not depend on theme values. r=eeejay

Browse Source 
It's relying on the other menuitems being tall enough so that they
overflow 5em. When the non-native theme is enabled, this assumption
breaks because that theme doesn't add padding to XUL menuitems, and we
get the failure:

    wrong state bits for 'mi_file1.2.4' !got '0', expected 'offscreen'

Get what we want to test more explicitly by setting the height of the
menuitems appropriately.

Differential Revision: https://phabricator.services.mozilla.com/D103267
This commit is contained in:
Emilio Cobos Álvarez 2021-01-28 17:19:16 +00:00
parent 69958d50f3
commit 924021206c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
accessible/tests/mochitest/states/test_visibility.xhtml
View File

@ -134,11 +134,11 @@
<menupopup>
<menuitem label="SubFile" id="mi_file1.1"/>
<menu label="SubFile2" id="mi_file1.2">
<menupopup style="max-height: 5em;">
<menuitem label="SubSubFile" id="mi_file1.2.1"/>
<menuitem label="SubSubFile2" id="mi_file1.2.2"/>
<menuitem label="SubSubFile3" id="mi_file1.2.3"/>
<menuitem label="SubSubFile4" id="mi_file1.2.4"/>
<menupopup style="max-height: 3em;">
<menuitem style="height: 1em" label="SubSubFile" id="mi_file1.2.1"/>
<menuitem style="height: 1em" label="SubSubFile2" id="mi_file1.2.2"/>
<menuitem style="height: 1em" label="SubSubFile3" id="mi_file1.2.3"/>
<menuitem style="height: 1em" label="SubSubFile4" id="mi_file1.2.4"/>
</menupopup>
</menu>
</menupopup>