Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-18 15:55:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1621308 - Give up client sync early during shutdown r=glasserc

Browse Source 
A significant amount of clients report OFFLINE_ERROR during shutdown.

Instead of adding a new uptake status to be reported when detecting offline during shutdown (eg. INTERRUPTED, not *_ERROR), we do nothing and give up immediately.

Differential Revision: https://phabricator.services.mozilla.com/D66271

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Mathieu Leplatre 2020-03-10 19:10:18 +00:00
parent 02dfadf8c9
commit 9296f12f2b
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
services/settings/RemoteSettingsClient.jsm
View File

@ -426,6 +426,14 @@ class RemoteSettingsClient extends EventEmitter {
console.warn(`${this.identifier} sync already running`);
return;
}
// Prevent network requests and IndexedDB calls to be initiated
// during shutdown.
if (Services.startup.shuttingDown) {
console.warn(`${this.identifier} sync interrputed by shutdown`);
return;
}
this._syncRunning = true;
let importedFromDump = [];