Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 14:22:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1200609 - Odin: Update comments and code mentioning interrupting via mprotect (r=benj)

Browse Source 
--HG--
extra : rebase_source : 20342d227c9b13b6f642fd344b03fb553d447172
This commit is contained in:
Luke Wagner 2015-11-16 08:57:31 -06:00
parent 6581e3b41d
commit 92ca11b076
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/src/asmjs/AsmJSModule.cpp
View File

@ -326,8 +326,6 @@ AsmJSModule::finish(ExclusiveContext* cx, TokenStream& tokenStream, MacroAssembl
if (!callSites_.appendAll(callSites))
return false;
MOZ_ASSERT(pod.functionBytes_ % AsmJSPageSize == 0);
// Absolute link metadata: absolute addresses that refer to some fixed
// address in the address space.
AbsoluteLinkArray& absoluteLinks = staticLinkData_.absoluteLinks;

8
js/src/asmjs/AsmJSValidate.cpp
View File

@ -1596,17 +1596,9 @@ class MOZ_STACK_CLASS ModuleValidator
masm().patchCall(callerOffset, calleeOffset);
}
// When an interrupt is triggered, all function code is mprotected and,
// for sanity, stub code (particularly the interrupt stub) is not.
// Protection works at page granularity, so we need to ensure that no
// stub code gets into the function code pages.
// TODO; this is no longer true and could be removed, see also
// bug 1200609.
MOZ_ASSERT(!finishedFunctionBodies_);
masm().haltingAlign(AsmJSPageSize);
module_->finishFunctionBodies(masm().currentOffset());
finishedFunctionBodies_ = true;
return true;
}