Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-25 20:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1838468 - Remove noisy warning. r=mccr8

Browse Source 
Usually, this warning points at a problem (we're rendering a native
widget in light mode in a page where we should render it in dark mode).

However there are cases where we do this legitimately, for example for
the -moz-window-titlebar appearance. We render the light titlebar behind
the tabs to be able to render shadows appropriately.

We could probably only warn in some cases but honestly I don't think
that is particularly appealing, so let's remove it.

Differential Revision: https://phabricator.services.mozilla.com/D180961
This commit is contained in:
Emilio Cobos Álvarez 2023-06-14 16:33:27 +00:00
parent f14bf38c39
commit 92cede474d
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
widget/gtk/nsNativeThemeGTK.cpp
View File

@ -1081,8 +1081,7 @@ auto nsNativeThemeGTK::IsWidgetNonNative(nsIFrame* aFrame,
}
// If the non-native theme doesn't support the widget then oh well...
if (NS_WARN_IF(!Theme::ThemeSupportsWidget(aFrame->PresContext(), aFrame,
aAppearance))) {
if (!Theme::ThemeSupportsWidget(aFrame->PresContext(), aFrame, aAppearance)) {
return NonNative::No;
}