Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 16:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1515689 - Fix initialization/destruction race in UiCompositorControllerParent r=botond

Browse Source 
It looks like we can do initialization and destruction from the UI
thread before the bits that run on the Compositor thread have run. Avoid
this by synchronously waiting on the Compositor.

Differential Revision: https://phabricator.services.mozilla.com/D16596

--HG--
extra : moz-landing-system : lando
This commit is contained in:
James Willcox 2019-01-17 19:37:32 +00:00
parent b75c602ced
commit 92d41d761f
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gfx/layers/ipc/UiCompositorControllerParent.cpp
View File

@ -17,6 +17,7 @@
#include "mozilla/Unused.h"
#include "FrameMetrics.h"
#include "SynchronousTask.h"
namespace mozilla {
namespace layers {
@ -277,9 +278,16 @@ void UiCompositorControllerParent::InitializeForSameProcess() {
// This function is called by UiCompositorControllerChild in the main thread.
// So dispatch to the compositor thread to Initialize.
if (!CompositorThreadHolder::IsInCompositorThread()) {
CompositorThreadHolder::Loop()->PostTask(NewRunnableMethod(
"layers::UiCompositorControllerParent::InitializeForSameProcess", this,
&UiCompositorControllerParent::InitializeForSameProcess));
SynchronousTask task(
"UiCompositorControllerParent::InitializeForSameProcess");
CompositorThreadHolder::Loop()->PostTask(NS_NewRunnableFunction(
"UiCompositorControllerParent::InitializeForSameProcess", [&]() {
AutoCompleteTask complete(&task);
InitializeForSameProcess();
}));
task.Wait();
return;
}