Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 08:12:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1856014 - Fix fluent schema for strings in protections panel. r=Gijs,fluent-reviewers,flod

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D191997
This commit is contained in:
DJ 2023-10-30 15:34:55 +00:00
parent 350fc35580
commit 9315ecdf22
3 changed files with 48 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
browser/components/controlcenter/content/protectionsPanel.inc.xhtml
View File

@ -82,8 +82,8 @@
<toolbarseparator></toolbarseparator>
<vbox id="tracking-protection-container" class="protections-popup-section">
<description id="protections-popup-no-trackers-found-description" data-l10n-id="protections-panel-no-trackers-found"></description>
<tooltip id="protections-popup-not-blocking-why-etp-on-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-on-tooltip"></tooltip>
<tooltip id="protections-popup-not-blocking-why-etp-off-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-off-tooltip"></tooltip>
<tooltip id="protections-popup-not-blocking-why-etp-on-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-on-tooltip-label"></tooltip>
<tooltip id="protections-popup-not-blocking-why-etp-off-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-off-tooltip-label"></tooltip>
<vbox id="protections-popup-content" flex="1">
<vbox id="protections-popup-category-list">
<toolbarbutton id="protections-popup-category-trackers"
@ -401,12 +401,12 @@
oncommand="gProtectionsHandler._protectionsPopupMultiView.goBack();"
class="footer-button" />
<button id="protections-popup-cookieBannerView-enable-button"
data-l10n-id="protections-panel-cookie-banner-view-turn-on"
data-l10n-id="protections-panel-cookie-banner-view-turn-on-label"
oncommand="gProtectionsHandler.onCookieBannerToggleCommand()"
default="true"
class="footer-button" />
<button id="protections-popup-cookieBannerView-disable-button"
data-l10n-id="protections-panel-cookie-banner-view-turn-off"
data-l10n-id="protections-panel-cookie-banner-view-turn-off-label"
oncommand="gProtectionsHandler.onCookieBannerToggleCommand()"
default="true"
class="footer-button" />

12
browser/locales/en-US/browser/protectionsPanel.ftl
View File

@ -51,8 +51,10 @@ protections-panel-site-not-working-view =
## a tooltip explaining why these items were not blocked in the page.
protections-panel-not-blocking-why-label = Why?
protections-panel-not-blocking-why-etp-on-tooltip = Blocking these could break elements of some websites. Without trackers, some buttons, forms, and login fields might not work.
protections-panel-not-blocking-why-etp-off-tooltip = All trackers on this site have been loaded because protections are turned off.
protections-panel-not-blocking-why-etp-on-tooltip-label =
.label = Blocking these could break elements of some websites. Without trackers, some buttons, forms, and login fields might not work.
protections-panel-not-blocking-why-etp-off-tooltip-label =
.label = All trackers on this site have been loaded because protections are turned off.
##
@ -142,5 +144,7 @@ protections-panel-cookie-banner-blocker-view-turn-on-for-site = Turn on Cookie B
protections-panel-cookie-banner-view-cookie-clear-warning = { -brand-short-name } will clear this site’s cookies and refresh the page. Clearing all cookies may sign you out or empty shopping carts.
protections-panel-cookie-banner-blocker-view-turn-on-description = Turn on and { -brand-short-name } will try to automatically refuse cookie banners on this site.
protections-panel-cookie-banner-view-cancel = Cancel
protections-panel-cookie-banner-view-turn-off = Turn Off
protections-panel-cookie-banner-view-turn-on = Turn On
protections-panel-cookie-banner-view-turn-off-label =
.label = Turn Off
protections-panel-cookie-banner-view-turn-on-label =
.label = Turn On

36
python/l10n/fluent_migrations/bug_1856014_protectionsPanel_fixButtonLabels.py Normal file
View File

@ -0,0 +1,36 @@
# Any copyright is dedicated to the Public Domain.
# http://creativecommons.org/publicdomain/zero/1.0/
from fluent.migrate.helpers import transforms_from
def migrate(ctx):
"""Bug 1856014 - Fix fluent schema for strings in protections panel, part {index}."""
file = "browser/browser/protectionsPanel.ftl"
ctx.add_transforms(
file,
file,
transforms_from(
"""
protections-panel-not-blocking-why-etp-on-tooltip-label =
.label = {COPY_PATTERN(from_path, "protections-panel-not-blocking-why-etp-on-tooltip")}
protections-panel-not-blocking-why-etp-off-tooltip-label =
.label = {COPY_PATTERN(from_path, "protections-panel-not-blocking-why-etp-off-tooltip")}
""",
from_path=file,
),
)
ctx.add_transforms(
file,
file,
transforms_from(
"""
protections-panel-cookie-banner-view-turn-off-label =
.label = {COPY_PATTERN(from_path, "protections-panel-cookie-banner-view-turn-off")}
protections-panel-cookie-banner-view-turn-on-label =
.label = {COPY_PATTERN(from_path, "protections-panel-cookie-banner-view-turn-on")}
""",
from_path=file,
),
)