Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 19:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1827214 - Make PerfSpewer.cpp compile on macOS, and allow --enable-perf on macOS. r=dpalmeiro

Browse Source 
Emitting Jitdump files on macOS will be useful once the samply profiler
supports Jitdump on macOS.

Differential Revision: https://phabricator.services.mozilla.com/D175045
This commit is contained in:
Markus Stange 2023-04-11 17:35:48 +00:00
parent d3847e5588
commit 9331379cd4
2 changed files with 35 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/moz.configure
View File

@ -431,8 +431,10 @@ option("--enable-perf", env="JS_ION_PERF", help="Enable Linux perf integration")
@depends("--enable-perf", target)
def ion_perf(value, target):
ok_kernel = target.kernel == "Linux" and target.os == "GNU"
if value and ok_kernel:
is_linux = target.kernel == "Linux" and target.os == "GNU"
is_mac = target.kernel == "Darwin" and target.os == "OSX"
if value and (is_linux or is_mac):
return True

32
js/src/jit/PerfSpewer.cpp
View File

@ -22,6 +22,34 @@
# include <unistd.h>
# define gettid() static_cast<pid_t>(syscall(__NR_gettid))
#endif
#if defined(JS_ION_PERF) && defined(XP_MACOSX)
# include <pthread.h>
# include <unistd.h>
pid_t gettid_pthread() {
uint64_t tid;
if (pthread_threadid_np(nullptr, &tid) != 0) {
return 0;
}
// Truncate the tid to 32 bits. macOS thread IDs are usually small enough.
// And even if we do end up truncating, it doesn't matter much for Jitdump
// as long as the process ID is correct.
return pid_t(tid);
}
# define gettid() gettid_pthread()
const char* get_current_dir_name_cwd() {
constexpr size_t CWD_MAX = 256;
char* buffer = (char*)malloc(CWD_MAX);
if (getcwd(buffer, CWD_MAX) == nullptr) {
buffer[0] = 0;
}
return buffer;
}
# define get_current_dir_name() get_current_dir_name_cwd()
#endif
#include "jit/PerfSpewer.h"
#include <atomic>
@ -171,7 +199,9 @@ static bool openJitDump() {
if (env_dir[0] == '/') {
spew_dir = JS_smprintf("%s", env_dir);
} else {
spew_dir = JS_smprintf("%s/%s", get_current_dir_name(), env_dir);
const char* dir = get_current_dir_name();
spew_dir = JS_smprintf("%s/%s", dir, env_dir);
free((void*)dir);
}
} else {
fprintf(stderr, "Please define PERF_SPEW_DIR as an output directory.\n");