Bug 1699586 - De-duplicate small down arrow icons, rename as arrow-down-12.svg. r=harry,preferences-reviewers,desktop-theme-reviewers,thecount,Itiel

Differential Revision: https://phabricator.services.mozilla.com/D117571
This commit is contained in:
Sam Foster 2021-06-23 18:49:41 +00:00
parent 11417db872
commit 9347a81644
32 changed files with 46 additions and 64 deletions

View File

@ -182,7 +182,7 @@
margin-bottom: 2px;
-moz-context-properties: fill;
fill: var(--customize-menu-primary-text-color);
background: url('#{$image-path}glyph-arrowhead-down-12.svg') right no-repeat;
background: url('chrome://global/skin/icons/arrow-down-12.svg') right no-repeat;
background-size: 8px;
background-origin: content-box;
background-color: var(--customize-menu-background);

View File

@ -167,14 +167,14 @@
}
&.icon-arrowhead-down-small {
background-image: url('chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg');
background-image: url('chrome://global/skin/icons/arrow-down-12.svg');
background-size: $smaller-icon-size;
height: $smaller-icon-size;
width: $smaller-icon-size;
}
&.icon-arrowhead-forward-small {
background-image: url('chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg');
background-image: url('chrome://global/skin/icons/arrow-down-12.svg');
background-size: $smaller-icon-size;
height: $smaller-icon-size;
transform: rotate(-90deg);

View File

@ -334,13 +334,13 @@ body[lwt-newtab-brighttext] {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-16.svg");
}
.icon.icon-arrowhead-down-small {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-size: 12px;
height: 12px;
width: 12px;
}
.icon.icon-arrowhead-forward-small {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-size: 12px;
height: 12px;
transform: rotate(-90deg);
@ -2163,7 +2163,7 @@ main.has-snippet {
margin-bottom: 2px;
-moz-context-properties: fill;
fill: var(--customize-menu-primary-text-color);
background: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg") right no-repeat;
background: url("chrome://global/skin/icons/arrow-down-12.svg") right no-repeat;
background-size: 8px;
background-origin: content-box;
background-color: var(--customize-menu-background);

View File

@ -338,13 +338,13 @@ body[lwt-newtab-brighttext] {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-16.svg");
}
.icon.icon-arrowhead-down-small {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-size: 12px;
height: 12px;
width: 12px;
}
.icon.icon-arrowhead-forward-small {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-size: 12px;
height: 12px;
transform: rotate(-90deg);
@ -2167,7 +2167,7 @@ main.has-snippet {
margin-bottom: 2px;
-moz-context-properties: fill;
fill: var(--customize-menu-primary-text-color);
background: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg") right no-repeat;
background: url("chrome://global/skin/icons/arrow-down-12.svg") right no-repeat;
background-size: 8px;
background-origin: content-box;
background-color: var(--customize-menu-background);

View File

@ -334,13 +334,13 @@ body[lwt-newtab-brighttext] {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-16.svg");
}
.icon.icon-arrowhead-down-small {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-size: 12px;
height: 12px;
width: 12px;
}
.icon.icon-arrowhead-forward-small {
background-image: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-size: 12px;
height: 12px;
transform: rotate(-90deg);
@ -2163,7 +2163,7 @@ main.has-snippet {
margin-bottom: 2px;
-moz-context-properties: fill;
fill: var(--customize-menu-primary-text-color);
background: url("chrome://activity-stream/content/data/content/assets/glyph-arrowhead-down-12.svg") right no-repeat;
background: url("chrome://global/skin/icons/arrow-down-12.svg") right no-repeat;
background-size: 8px;
background-origin: content-box;
background-color: var(--customize-menu-background);

View File

@ -102,8 +102,6 @@ browser/chrome/browser/content/activity-stream/data/content/tippytop/favicons/ya
browser/chrome/browser/search-extensions/yandex/yandex-ru.ico
# Bug 1698146, bug 1699586 - Deduplicate chevrons/arrows in the tree
chrome/toolkit/skin/classic/global/icons/arrow-dropdown-12.svg
chrome/toolkit/skin/classic/global/icons/twisty-expanded.svg
chrome/toolkit/skin/classic/global/icons/twisty-collapsed-rtl.svg
chrome/toolkit/skin/classic/global/icons/arrow-dropdown-16.svg
chrome/toolkit/skin/classic/global/icons/find-next-arrow.svg
@ -124,7 +122,6 @@ chrome/toolkit/skin/classic/global/icons/lightbulb.svg
# Bug 1708502 - De-duplicate about:newtab icons
browser/chrome/browser/content/activity-stream/data/content/assets/glyph-arrow.svg
browser/chrome/browser/content/activity-stream/data/content/assets/glyph-arrowhead-down-12.svg
browser/chrome/browser/content/activity-stream/data/content/assets/glyph-arrowhead-down-16.svg
browser/chrome/browser/content/activity-stream/data/content/assets/glyph-caret-right.svg
browser/chrome/browser/content/activity-stream/data/content/assets/glyph-dismiss-16.svg

View File

@ -80,7 +80,7 @@
display: -moz-box;
width: 12px;
height: 12px;
content: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
content: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill;
fill: currentColor;
}

View File

@ -73,7 +73,7 @@
}
#placesToolbar > toolbarbutton[type="menu"] > .toolbarbutton-menu-dropmarker {
list-style-image: url(chrome://global/skin/icons/arrow-dropdown-12.svg);
list-style-image: url(chrome://global/skin/icons/arrow-down-12.svg);
padding: 0;
margin-inline-end: 2px;
}

View File

@ -712,7 +712,7 @@ menupopup::part(drop-indicator) {
}
.ac-dropmarker::part(icon) {
list-style-image: url(chrome://global/skin/icons/arrow-dropdown-12.svg);
list-style-image: url(chrome://global/skin/icons/arrow-down-12.svg);
-moz-context-properties: fill;
fill: var(--input-color, -moz-DialogText);
}

View File

@ -2726,7 +2726,7 @@ panelview:not([mainview]) #PanelUI-whatsNew-title {
margin-block-start: 5px;
-moz-context-properties: fill;
fill: currentColor;
background: url("chrome://global/skin/icons/arrow-dropdown-12.svg") center center no-repeat;
background: url("chrome://global/skin/icons/arrow-down-12.svg") center center no-repeat;
}
#PanelUI-profiler-presets:-moz-locale-dir(ltr)::after {

View File

@ -73,7 +73,7 @@
#viewButton > .button-box > .button-menu-dropmarker {
appearance: none !important;
display: -moz-box;
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
width: 12px;
height: 12px;
-moz-context-properties: fill;

View File

@ -139,7 +139,7 @@
min-width: 20px;
max-height: 20px;
max-width: 20px;
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-color: transparent;
padding: 3px;
}

View File

@ -64,7 +64,7 @@
}
#sidebar-switcher-arrow {
list-style-image: url(chrome://global/skin/icons/arrow-dropdown-12.svg);
list-style-image: url(chrome://global/skin/icons/arrow-down-12.svg);
width: 12px;
height: 12px;
}

View File

@ -84,7 +84,7 @@ body {
.item.client .item-twisty-container {
min-width: 12px;
height: 12px;
background-image: url("chrome://global/skin/icons/twisty-expanded.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill, fill-opacity;
fill: currentColor;
fill-opacity: 1;

View File

@ -38,7 +38,7 @@ notification[value="translation"] menulist::part(dropmarker) {
}
notification[value="translation"] menulist::part(dropmarker-icon) {
list-style-image: url(chrome://global/skin/icons/arrow-dropdown-12.svg);
list-style-image: url(chrome://global/skin/icons/arrow-down-12.svg);
-moz-context-properties: fill;
fill: currentColor;
}

View File

@ -843,7 +843,7 @@
}
.searchbar-search-button:hover:not([addengines=true]) > .searchbar-search-icon-overlay {
list-style-image: url(chrome://global/skin/icons/arrow-dropdown-12.svg);
list-style-image: url(chrome://global/skin/icons/arrow-down-12.svg);
-moz-context-properties: fill;
margin-inline: -8px 2px;
width: 6px;

View File

@ -145,7 +145,7 @@
#placesMenu > menu > .menubar-text {
margin-block: 0 !important; /* override menu.css */
padding-inline-end: 8px;
background: url(chrome://global/skin/icons/arrow-dropdown-12.svg) right center no-repeat;
background: url(chrome://global/skin/icons/arrow-down-12.svg) right center no-repeat;
background-size: 6px;
}
@ -313,7 +313,7 @@ treechildren::-moz-tree-separator(selected) {
border-radius: 4px;
color: var(--organizer-color);
background-color: var(--organizer-content-background);
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill;
fill: currentColor;
}
@ -337,7 +337,7 @@ treechildren::-moz-tree-separator(selected) {
}
#editBookmarkPanelRows .expander-up {
transform: scaleY(-1);
list-style-image: url("chrome://global/skin/icons/arrow-up-12.svg");
}
#editBookmarkPanelRows .expander-up > .button-box,

View File

@ -159,7 +159,7 @@ td {
transform: scaleX(-1);
}
.twisty.open::before {
content: url("chrome://global/skin/icons/twisty-expanded.svg");
content: url("chrome://global/skin/icons/arrow-down-12.svg");
}
#dispatch-tbody > tr > td.indent {
padding-inline-start: 88px;
@ -201,7 +201,7 @@ td {
fill: currentColor;
}
.desc {
background-image: url(chrome://global/skin/icons/arrow-dropdown-12.svg);
background-image: url(chrome://global/skin/icons/arrow-down-12.svg);
-moz-context-properties: fill;
fill: currentColor;
}

View File

@ -106,7 +106,7 @@ td:first-child {
content: url("chrome://global/skin/icons/twisty-collapsed-rtl.svg");
}
.twisty.open::before {
content: url("chrome://global/skin/icons/twisty-expanded.svg");
content: url("chrome://global/skin/icons/arrow-down-12.svg");
}
.indent {
padding-inline: 48px 0;
@ -156,11 +156,11 @@ tr[selected] > td {
background-image: url(chrome://global/skin/icons/arrow-up-12.svg);
}
.desc {
background-image: url(chrome://global/skin/icons/arrow-dropdown-12.svg);
background-image: url(chrome://global/skin/icons/arrow-down-12.svg);
}
%else
.asc {
background-image: url(chrome://global/skin/icons/arrow-dropdown-12.svg);
background-image: url(chrome://global/skin/icons/arrow-down-12.svg);
}
.desc {
background-image: url(chrome://global/skin/icons/arrow-up-12.svg);

View File

@ -108,7 +108,7 @@ select:not([size], [multiple])[iconic] {
#printer-picker {
background-size: auto 12px, 16px;
background-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg"), url("chrome://global/skin/icons/print.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg"), url("chrome://global/skin/icons/print.svg");
background-position: right 3px center, left 8px center;
width: 100%;
}
@ -118,7 +118,7 @@ select:not([size], [multiple])[iconic] {
}
#printer-picker[output="pdf"] {
background-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg"), url("chrome://global/skin/icons/page-portrait.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg"), url("chrome://global/skin/icons/page-portrait.svg");
}
input[type="number"],
@ -151,14 +151,13 @@ input[type="text"] {
}
#more-settings > summary > .twisty {
background-image: url("chrome://global/skin/icons/twisty-expanded.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-repeat: no-repeat;
background-position: center;
-moz-context-properties: fill;
fill: currentColor;
width: 12px;
height: 12px;
scale: 1 1;
}
#more-settings > summary > .label {
@ -166,8 +165,7 @@ input[type="text"] {
}
#more-settings[open] > summary > .twisty {
/* flip arrow to point up for the open state */
scale: 1 -1;
background-image: url("chrome://global/skin/icons/arrow-up-12.svg");
}
#open-dialog-link {

View File

@ -70,5 +70,5 @@ button[type="disclosure"] {
}
button[type="disclosure"][open="true"] {
list-style-image: url("chrome://global/skin/icons/twisty-expanded.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
}

View File

@ -60,7 +60,7 @@ toolbarbutton:-moz-lwtheme:not(:hover, [checked="true"], [open="true"], [disable
.toolbarbutton-combined-buttons-dropmarker {
appearance: none;
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill;
fill: currentColor;
width: auto;

View File

@ -26,7 +26,7 @@ toolbarbutton[disabled="true"] {
.toolbarbutton-menu-dropmarker,
.toolbarbutton-combined-buttons-dropmarker {
appearance: none;
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill;
fill: currentColor;
width: auto;

View File

@ -14,7 +14,7 @@
toolbarbutton {
color: inherit !important; /* override any color changes for toolbar buttons in e.g. disabled or hover states */
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill, fill-opacity;
fill: currentColor;
fill-opacity: 1;
@ -30,7 +30,7 @@ toolbarbutton[disabled="true"] {
}
#scrollbutton-up > .toolbarbutton-icon {
transform: scaleY(-1);
list-style-image: url("chrome://global/skin/icons/arrow-up-12.svg");
}
:host([orient="horizontal"]) > #scrollbutton-down:-moz-locale-dir(ltr) > .toolbarbutton-icon,

View File

Before

Width:  |  Height:  |  Size: 498 B

After

Width:  |  Height:  |  Size: 498 B

View File

@ -1,6 +0,0 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 12" width="12" height="12" fill="context-fill" fill-opacity="context-fill-opacity">
<path d="m6.24 8.999 3.614-3.613a.498.498 0 0 0 0-.707.5.5 0 0 0-.707 0L5.999 7.826 2.854 4.68a.5.5 0 0 0-.707.707L5.759 9l.481-.001z"/>
</svg>

Before

Width:  |  Height:  |  Size: 498 B

View File

@ -1,6 +0,0 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 12" width="12" height="12" fill="context-fill" fill-opacity="context-fill-opacity">
<path d="m6.24 8.999 3.614-3.613a.498.498 0 0 0 0-.707.5.5 0 0 0-.707 0L5.999 7.826 2.854 4.68a.5.5 0 0 0-.707.707L5.759 9l.481-.001z"/>
</svg>

Before

Width:  |  Height:  |  Size: 498 B

View File

@ -406,7 +406,7 @@ xul|tab:-moz-focusring > .tab-middle > .tab-text {
}
html|select:not([size], [multiple]) {
background-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
background-image: url("chrome://global/skin/icons/arrow-down-12.svg");
background-position: right 3px center;
background-repeat: no-repeat;
background-size: auto 12px;
@ -546,7 +546,7 @@ xul|menulist::part(dropmarker) {
padding: 0;
border: none;
background-color: transparent;
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill;
fill: currentColor;
}

View File

@ -77,12 +77,11 @@ toolkit.jar:
skin/classic/global/icons/sort-arrow.svg (../../shared/icons/sort-arrow.svg)
skin/classic/global/icons/twisty-collapsed.svg (../../shared/icons/twisty-collapsed.svg)
skin/classic/global/icons/twisty-collapsed-rtl.svg (../../shared/icons/twisty-collapsed-rtl.svg)
skin/classic/global/icons/twisty-expanded.svg (../../shared/icons/twisty-expanded.svg)
#if defined(NIGHTLY_BUILD)
skin/classic/global/icons/icon-refresh.svg (../../shared/icons/icon-refresh.svg)
#endif
skin/classic/global/icons/update-icon.svg (../../shared/icons/update-icon.svg)
skin/classic/global/icons/arrow-dropdown-12.svg (../../shared/icons/arrow-dropdown-12.svg)
skin/classic/global/icons/arrow-down-12.svg (../../shared/icons/arrow-down-12.svg)
skin/classic/global/icons/arrow-dropdown-16.svg (../../shared/icons/arrow-dropdown-16.svg)
skin/classic/global/icons/arrow-up-12.svg (../../shared/icons/arrow-up-12.svg)
skin/classic/global/icons/arrow-up-16.svg (../../shared/icons/arrow-up-16.svg)

View File

@ -185,7 +185,7 @@ treechildren:-moz-locale-dir(rtl)::-moz-tree-twisty(closed) {
}
treechildren::-moz-tree-twisty(open) {
list-style-image: url("chrome://global/skin/icons/twisty-expanded.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
}
treechildren::-moz-tree-indentation {

View File

@ -60,7 +60,7 @@ button:where([disabled="true"]) {
.button-menu-dropmarker {
appearance: none;
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill;
fill: currentColor;
width: 12px;
@ -84,5 +84,5 @@ button[type="disclosure"] {
}
button[type="disclosure"][open="true"] {
list-style-image: url("chrome://global/skin/icons/twisty-expanded.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
}

View File

@ -64,7 +64,7 @@ toolbarbutton[disabled="true"] {
.toolbarbutton-menu-dropmarker,
.toolbarbutton-combined-buttons-dropmarker {
appearance: none;
list-style-image: url("chrome://global/skin/icons/arrow-dropdown-12.svg");
list-style-image: url("chrome://global/skin/icons/arrow-down-12.svg");
-moz-context-properties: fill;
fill: currentColor;
width: auto;