Bug 1502119 - Remove obsolete nodeAnnotationChanged. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D34998

--HG--
extra : moz-landing-system : lando

browser/components/places/content/browserPlacesViews.js

@@ -439,8 +439,6 @@ PlacesViewBase.prototype = {
     elt.setAttribute("image", aPlacesNode.icon);
   },
 
-  nodeAnnotationChanged() {},
-
   nodeTitleChanged:
   function PVB_nodeTitleChanged(aPlacesNode, aNewTitle) {
     let elt = this._getDOMNodeForPlacesNode(aPlacesNode);
@@ -1233,23 +1231,6 @@ PlacesToolbar.prototype = {
     PlacesViewBase.prototype.nodeMoved.apply(this, arguments);
   },
 
-  nodeAnnotationChanged:
-  function PT_nodeAnnotationChanged(aPlacesNode, aAnno) {
-    let elt = this._getDOMNodeForPlacesNode(aPlacesNode, true);
-    // Nothing to do if it's a never-visible node.
-    if (!elt || elt == this._rootElt)
-      return;
-
-    // We're notified for the menupopup, not the containing toolbarbutton.
-    if (elt.localName == "menupopup")
-      elt = elt.parentNode;
-
-    if (elt.parentNode != this._rootElt) { // Node is on the toolbar.
-      // Node is in a submenu.
-      PlacesViewBase.prototype.nodeAnnotationChanged.apply(this, arguments);
-    }
-  },
-
   nodeTitleChanged: function PT_nodeTitleChanged(aPlacesNode, aNewTitle) {
     let elt = this._getDOMNodeForPlacesNode(aPlacesNode, true);
 
@@ -1860,8 +1841,6 @@ PlacesPanelMenuView.prototype = {
     this._rootElt.insertBefore(elt, this._rootElt.children[aNewIndex]);
   },
 
-  nodeAnnotationChanged() {},
-
   nodeTitleChanged: function PAMV_nodeTitleChanged(aPlacesNode, aNewTitle) {
     let elt = this._getDOMNodeForPlacesNode(aPlacesNode);
 

browser/components/places/content/treeView.js

@@ -861,8 +861,6 @@ PlacesTreeView.prototype = {
 
   nodeKeywordChanged(aNode, aNewKeyword) {},
 
-  nodeAnnotationChanged() {},
-
   nodeDateAddedChanged: function PTV_nodeDateAddedChanged(aNode, aNewValue) {
     this._invalidateCellValue(aNode, this.COLUMN_TYPE_DATEADDED);
   },

toolkit/components/downloads/DownloadHistory.jsm

@@ -728,7 +728,6 @@ this.DownloadHistoryList.prototype = {
   },
 
   // nsINavHistoryResultObserver
-  nodeAnnotationChanged() {},
   nodeIconChanged() {},
   nodeTitleChanged() {},
   nodeKeywordChanged() {},

toolkit/components/places/nsINavHistoryService.idl

@@ -410,18 +410,6 @@ interface nsINavHistoryResultObserver : nsISupports
   void nodeKeywordChanged(in nsINavHistoryResultNode aNode,
                           in AUTF8String aNewKeyword);
 
-  /**
-   * Called right after an annotation of aNode's has changed (set, altered, or
-   * unset).
-   *
-   * @param aNode
-   *        a result node
-   * @param aAnnoName
-   *        the name of the annotation that changed
-   */
-  void nodeAnnotationChanged(in nsINavHistoryResultNode aNode,
-                             in AUTF8String aAnnoName);
-
   /**
    * Called right after aNode's dateAdded property has changed.
    *

toolkit/components/places/tests/head_common.js

@@ -732,7 +732,6 @@ NavHistoryResultObserver.prototype = {
   batching() {},
   containerStateChanged() {},
   invalidateContainer() {},
-  nodeAnnotationChanged() {},
   nodeDateAddedChanged() {},
   nodeHistoryDetailsChanged() {},
   nodeIconChanged() {},

toolkit/components/places/tests/unit/test_nsINavHistoryViewer.js

@@ -14,8 +14,6 @@ var resultObserver = {
     this.removedNode = node;
   },
 
-  nodeAnnotationChanged() {},
-
   newTitle: "",
   nodeChangedByTitle: null,
   nodeTitleChanged(node, newTitle) {