Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 07:13:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1459205 - Speed up dict type by preventing duplicated calls to getType from its write method. r=jryans

Browse Source 
MozReview-Commit-ID: Dn37LGEpB6q

--HG--
extra : rebase_source : 11cf83fdc1dba6d8b13c9440adf1e6d1d2b6d554
This commit is contained in:
Alexandre Poirot 2018-05-03 12:47:27 -07:00
parent 711c760354
commit 93856a5ce8
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
devtools/shared/protocol.js
View File

@ -241,14 +241,27 @@ types.addArrayType = function(subtype) {
* A dict of property names => type
*/
types.addDictType = function(name, specializations) {
let specTypes = {};
for (let prop in specializations) {
try {
specTypes[prop] = types.getType(specializations[prop]);
} catch (e) {
// Types may not be defined yet. Sometimes, we define the type *after* using it, but
// also, we have cyclic definitions on types. So lazily load them when they are not
// immediately available.
loader.lazyGetter(specTypes, prop, () => {
return types.getType(specializations[prop]);
});
}
}
return types.addType(name, {
category: "dict",
specializations: specializations,
specializations,
read: (v, ctx) => {
let ret = {};
for (let prop in v) {
if (prop in specializations) {
ret[prop] = types.getType(specializations[prop]).read(v[prop], ctx);
if (prop in specTypes) {
ret[prop] = specTypes[prop].read(v[prop], ctx);
} else {
ret[prop] = v[prop];
}
@ -259,8 +272,8 @@ types.addDictType = function(name, specializations) {
write: (v, ctx) => {
let ret = {};
for (let prop in v) {
if (prop in specializations) {
ret[prop] = types.getType(specializations[prop]).write(v[prop], ctx);
if (prop in specTypes) {
ret[prop] = specTypes[prop].write(v[prop], ctx);
} else {
ret[prop] = v[prop];
}