From 9388b058dc79727d46a15d29e8ce50c53724e1c0 Mon Sep 17 00:00:00 2001
From: Richard Newman <rnewman@mozilla.com>
Date: Thu, 16 Oct 2014 19:50:41 -0700
Subject: [PATCH] Bug 1064263 - Part 1: avoid crash when Sync is partially
 configured. r=nalexander

---
 .../service/sharemethods/SendTab.java         |  8 +++++
 .../ui/SendTabDeviceListArrayAdapter.java     | 29 ++++++++++---------
 .../android/base/overlays/ui/SendTabList.java | 12 ++------
 .../ui/SendTabTargetSelectedListener.java     |  7 +++++
 .../android/base/overlays/ui/ShareDialog.java | 22 +++++++-------
 5 files changed, 43 insertions(+), 35 deletions(-)

diff --git a/mobile/android/base/overlays/service/sharemethods/SendTab.java b/mobile/android/base/overlays/service/sharemethods/SendTab.java
index 691684b23d52..fffa0baec60f 100644
--- a/mobile/android/base/overlays/service/sharemethods/SendTab.java
+++ b/mobile/android/base/overlays/service/sharemethods/SendTab.java
@@ -206,6 +206,13 @@ public class SendTab extends ShareMethod {
             i++;
         }
 
+        if (validGUIDs.isEmpty()) {
+            // Guess we'd better override. We have no clients.
+            // This does the broadcast for us.
+            setOverrideIntent(FxAccountGetStartedActivity.class);
+            return;
+        }
+
         Intent uiStateIntent = getUIStateIntent();
         uiStateIntent.putExtra(EXTRA_CLIENT_RECORDS, records);
         broadcastUIState(uiStateIntent);
@@ -230,6 +237,7 @@ public class SendTab extends ShareMethod {
 
         Intent uiStateIntent = getUIStateIntent();
         uiStateIntent.putExtra(OVERRIDE_INTENT, intent);
+
         broadcastUIState(uiStateIntent);
     }
 
diff --git a/mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java b/mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java
index 08f2beb7d134..32c6054ad88d 100644
--- a/mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java
+++ b/mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java
@@ -112,24 +112,27 @@ public class SendTabDeviceListArrayAdapter extends ArrayAdapter<ParcelableClient
         }
 
         // The remaining states delegate to the SentTabTargetSelectedListener.
-        final String listenerGUID;
-
-        ParcelableClientRecord clientRecord = getItem(position);
+        final ParcelableClientRecord clientRecord = getItem(position);
         if (currentState == State.LIST) {
             row.setText(clientRecord.name);
             row.setCompoundDrawablesWithIntrinsicBounds(getImage(clientRecord), 0, 0, 0);
 
-            listenerGUID = clientRecord.guid;
-        } else {
-            listenerGUID = null;
-        }
+            final String listenerGUID = clientRecord.guid;
 
-        row.setOnClickListener(new OnClickListener() {
-            @Override
-            public void onClick(View view) {
-                listener.onSendTabTargetSelected(listenerGUID);
-            }
-        });
+            row.setOnClickListener(new OnClickListener() {
+                @Override
+                public void onClick(View view) {
+                    listener.onSendTabTargetSelected(listenerGUID);
+                }
+            });
+        } else {
+            row.setOnClickListener(new OnClickListener() {
+                @Override
+                public void onClick(View view) {
+                    listener.onSendTabActionSelected();
+                }
+            });
+        }
 
         return row;
     }
diff --git a/mobile/android/base/overlays/ui/SendTabList.java b/mobile/android/base/overlays/ui/SendTabList.java
index e32da677a802..aa1885cca942 100644
--- a/mobile/android/base/overlays/ui/SendTabList.java
+++ b/mobile/android/base/overlays/ui/SendTabList.java
@@ -6,7 +6,6 @@ package org.mozilla.gecko.overlays.ui;
 
 import static org.mozilla.gecko.overlays.ui.SendTabList.State.LIST;
 import static org.mozilla.gecko.overlays.ui.SendTabList.State.LOADING;
-import static org.mozilla.gecko.overlays.ui.SendTabList.State.NONE;
 import static org.mozilla.gecko.overlays.ui.SendTabList.State.SHOW_DEVICES;
 
 import java.util.Arrays;
@@ -111,16 +110,9 @@ public class SendTabList extends ListView {
     public void setSyncClients(final ParcelableClientRecord[] c) {
         final ParcelableClientRecord[] clients = c == null ? new ParcelableClientRecord[0] : c;
 
-        int size = clients.length;
-        if (size == 0) {
-            // Just show a button to set up Sync (or whatever).
-            switchState(NONE);
-            return;
-        }
-
         clientListAdapter.setClientRecordList(Arrays.asList(clients));
 
-        if (size <= MAXIMUM_INLINE_ELEMENTS) {
+        if (clients.length <= MAXIMUM_INLINE_ELEMENTS) {
             // Show the list of devices in-line.
             switchState(LIST);
             return;
@@ -133,7 +125,7 @@ public class SendTabList extends ListView {
     /**
      * Get an AlertDialog listing all devices, allowing the user to select the one they want.
      * Used when more than MAXIMUM_INLINE_ELEMENTS devices are found (to avoid displaying them all
-     * inline and looking crazy.
+     * inline and looking crazy).
      */
     public AlertDialog getDialog() {
         AlertDialog.Builder builder = new AlertDialog.Builder(getContext());
diff --git a/mobile/android/base/overlays/ui/SendTabTargetSelectedListener.java b/mobile/android/base/overlays/ui/SendTabTargetSelectedListener.java
index 536b1ed5af8a..79da526da59c 100644
--- a/mobile/android/base/overlays/ui/SendTabTargetSelectedListener.java
+++ b/mobile/android/base/overlays/ui/SendTabTargetSelectedListener.java
@@ -15,4 +15,11 @@ public interface SendTabTargetSelectedListener {
      * @param targetGUID The GUID of the ClientRecord the element represents (if any, otherwise null)
      */
     public void onSendTabTargetSelected(String targetGUID);
+
+    /**
+     * Called when the overall Send Tab item is clicked.
+     *
+     * This implies that the clients list was unavailable.
+     */
+    public void onSendTabActionSelected();
 }
diff --git a/mobile/android/base/overlays/ui/ShareDialog.java b/mobile/android/base/overlays/ui/ShareDialog.java
index 04a5b125c7d9..3dc7e5dd413d 100644
--- a/mobile/android/base/overlays/ui/ShareDialog.java
+++ b/mobile/android/base/overlays/ui/ShareDialog.java
@@ -295,14 +295,17 @@ public class ShareDialog extends LocaleAware.LocaleAwareActivity implements Send
      * launching Fennec").
      */
 
-    public void sendTab(String targetGUID) {
-        // If an override intent has been set, dispatch it.
-        if (sendTabOverrideIntent != null) {
-            startActivity(sendTabOverrideIntent);
-            finish();
-            return;
-        }
+    @Override
+    public void onSendTabActionSelected() {
+        // This requires an override intent.
+        Assert.isTrue(sendTabOverrideIntent != null);
 
+        startActivity(sendTabOverrideIntent);
+        finish();
+    }
+
+    @Override
+    public void onSendTabTargetSelected(String targetGUID) {
         // targetGUID being null with no override intent should be an impossible state.
         Assert.isTrue(targetGUID != null);
 
@@ -320,11 +323,6 @@ public class ShareDialog extends LocaleAware.LocaleAwareActivity implements Send
         slideOut();
     }
 
-    @Override
-    public void onSendTabTargetSelected(String targetGUID) {
-        sendTab(targetGUID);
-    }
-
     public void addToReadingList() {
         startService(getServiceIntent(ShareMethod.Type.ADD_TO_READING_LIST));
         slideOut();