Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1356569 - Remove appendElement's last parameter when it is false, r=jaws.

Browse Source
This commit is contained in:
Florian Queze 2017-04-14 21:51:39 +02:00
parent 95d4d20c17
commit 93a734a3ce
39 changed files with 87 additions and 92 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
browser/base/content/utilityOverlay.js
View File

@ -309,15 +309,15 @@ function openLinkIn(url, where, params) {
createInstance(Ci.nsISupportsPRUint32);
userContextIdSupports.data = aUserContextId;
sa.appendElement(wuri, /* weak =*/ false);
sa.appendElement(charset, /* weak =*/ false);
sa.appendElement(referrerURISupports, /* weak =*/ false);
sa.appendElement(aPostData, /* weak =*/ false);
sa.appendElement(allowThirdPartyFixupSupports, /* weak =*/ false);
sa.appendElement(referrerPolicySupports, /* weak =*/ false);
sa.appendElement(userContextIdSupports, /* weak =*/ false);
sa.appendElement(aPrincipal, /* weak =*/ false);
sa.appendElement(aTriggeringPrincipal, /* weak =*/ false);
sa.appendElement(wuri);
sa.appendElement(charset);
sa.appendElement(referrerURISupports);
sa.appendElement(aPostData);
sa.appendElement(allowThirdPartyFixupSupports);
sa.appendElement(referrerPolicySupports);
sa.appendElement(userContextIdSupports);
sa.appendElement(aPrincipal);
sa.appendElement(aTriggeringPrincipal);
let features = "chrome,dialog=no,all";
if (aIsPrivate) {
@ -747,7 +747,7 @@ function openPreferences(paneID, extraArgs) {
let supportsStringPrefURL = Cc["@mozilla.org/supports-string;1"]
.createInstance(Ci.nsISupportsString);
supportsStringPrefURL.data = preferencesURL;
windowArguments.appendElement(supportsStringPrefURL, /* weak =*/ false);
windowArguments.appendElement(supportsStringPrefURL);
win = Services.ww.openWindow(null, Services.prefs.getCharPref("browser.chromeURL"),
"_blank", "chrome,dialog=no,all", windowArguments);

10
browser/components/extensions/ext-windows.js
View File

@ -123,19 +123,19 @@ this.windows = class extends ExtensionAPI {
}
createData.incognito = incognito;
args.appendElement(tab, /* weak = */ false);
args.appendElement(tab);
} else if (createData.url !== null) {
if (Array.isArray(createData.url)) {
let array = Cc["@mozilla.org/array;1"].createInstance(Ci.nsIMutableArray);
for (let url of createData.url) {
array.appendElement(mkstr(url), /* weak = */ false);
array.appendElement(mkstr(url));
}
args.appendElement(array, /* weak = */ false);
args.appendElement(array);
} else {
args.appendElement(mkstr(createData.url), /* weak = */ false);
args.appendElement(mkstr(createData.url));
}
} else {
args.appendElement(mkstr(aboutNewTabService.newTabURL), /* weak = */ false);
args.appendElement(mkstr(aboutNewTabService.newTabURL));
}
let features = ["chrome"];

2
browser/components/feeds/WebContentConverter.js
View File

@ -437,7 +437,7 @@ WebContentConverterRegistrar.prototype = {
let eps = Cc["@mozilla.org/uriloader/external-protocol-service;1"].
getService(Ci.nsIExternalProtocolService);
let handlerInfo = eps.getProtocolHandlerInfo(protocol);
handlerInfo.possibleApplicationHandlers.appendElement(handler, false);
handlerInfo.possibleApplicationHandlers.appendElement(handler);
// Since the user has agreed to add a new handler, chances are good
// that the next time they see a handler of this type, they're going

2
browser/components/migration/MigrationUtils.jsm
View File

@ -865,7 +865,7 @@ this.MigrationUtils = Object.freeze({
throw new Error("Unexpected parameter type " + (typeof item) + ": " + item);
}
}
params.appendElement(comtaminatedVal, false);
params.appendElement(comtaminatedVal);
}
} else {
params = aParams;

24
browser/components/nsBrowserContentHandler.js
View File

@ -197,20 +197,20 @@ function openWindow(parent, url, target, features, args, noExternalArgs) {
var sstring = Components.classes["@mozilla.org/supports-string;1"]
.createInstance(nsISupportsString);
sstring.data = uri;
uriArray.appendElement(sstring, /* weak = */ false);
uriArray.appendElement(sstring);
});
argArray.appendElement(uriArray, /* weak =*/ false);
argArray.appendElement(uriArray);
} else {
argArray.appendElement(null, /* weak =*/ false);
argArray.appendElement(null);
}
// Pass these as null to ensure that we always trigger the "single URL"
// behavior in browser.js's gBrowserInit.onLoad (which handles the window
// arguments)
argArray.appendElement(null, /* weak =*/ false); // charset
argArray.appendElement(null, /* weak =*/ false); // referer
argArray.appendElement(null, /* weak =*/ false); // postData
argArray.appendElement(null, /* weak =*/ false); // allowThirdPartyFixup
argArray.appendElement(null); // charset
argArray.appendElement(null); // referer
argArray.appendElement(null); // postData
argArray.appendElement(null); // allowThirdPartyFixup
return Services.ww.openWindow(parent, url, target, features, argArray);
}
@ -223,7 +223,7 @@ function openPreferences() {
.createInstance(Components.interfaces.nsISupportsString);
wuri.data = "about:preferences";
args.appendElement(wuri, /* weak = */ false);
args.appendElement(wuri);
Services.ww.openWindow(null, gBrowserContentHandler.chromeURL,
"_blank",
@ -251,10 +251,10 @@ function doSearch(searchTerm, cmdLine) {
.createInstance(Components.interfaces.nsISupportsString);
wuri.data = submission.uri.spec;
args.appendElement(wuri, /* weak =*/ false);
args.appendElement(null, /* weak =*/ false);
args.appendElement(null, /* weak =*/ false);
args.appendElement(submission.postData, /* weak =*/ false);
args.appendElement(wuri);
args.appendElement(null);
args.appendElement(null);
args.appendElement(submission.postData);
// XXXbsmedberg: use handURIToExistingBrowser to obey tabbed-browsing
// preferences, but need nsIBrowserDOMWindow extensions

2
browser/components/places/PlacesUIUtils.jsm
View File

@ -947,7 +947,7 @@ this.PlacesUIUtils = {
var uriList = PlacesUtils.toISupportsString(urls.join("|"));
var args = Cc["@mozilla.org/array;1"].
createInstance(Ci.nsIMutableArray);
args.appendElement(uriList, /* weak =*/ false);
args.appendElement(uriList);
browserWindow = Services.ww.openWindow(aWindow,
"chrome://browser/content/browser.xul",
null, "chrome,dialog=no,all", args);

6
browser/components/preferences/in-content-old/applications.js
View File

@ -222,7 +222,7 @@ HandlerInfoWrapper.prototype = {
if (possibleApps.getNext().equals(aNewHandler))
return;
}
this.possibleApplicationHandlers.appendElement(aNewHandler, false);
this.possibleApplicationHandlers.appendElement(aNewHandler);
},
removePossibleApplicationHandler(aHandler) {
@ -572,13 +572,13 @@ FeedHandlerInfo.prototype = {
let preferredApp = getLocalHandlerApp(preferredAppFile);
let defaultApp = this._defaultApplicationHandler;
if (!defaultApp || !defaultApp.equals(preferredApp))
this._possibleApplicationHandlers.appendElement(preferredApp, false);
this._possibleApplicationHandlers.appendElement(preferredApp);
}
// Add the registered web handlers. There can be any number of these.
var webHandlers = this._converterSvc.getContentHandlers(this.type);
for (let webHandler of webHandlers)
this._possibleApplicationHandlers.appendElement(webHandler, false);
this._possibleApplicationHandlers.appendElement(webHandler);
return this._possibleApplicationHandlers;
},

2
browser/components/preferences/in-content-old/tests/browser_bug410900.js
View File

@ -16,7 +16,7 @@ function test() {
var extps = Cc["@mozilla.org/uriloader/external-protocol-service;1"].
getService(Ci.nsIExternalProtocolService);
var info = extps.getProtocolHandlerInfo("apppanetest");
info.possibleApplicationHandlers.appendElement(handler, false);
info.possibleApplicationHandlers.appendElement(handler);
var hserv = Cc["@mozilla.org/uriloader/handler-service;1"].
getService(Ci.nsIHandlerService);

2
browser/components/preferences/in-content-old/tests/browser_change_app_handler.js
View File

@ -9,7 +9,7 @@ function setupFakeHandler() {
let handler = info.possibleLocalHandlers.queryElementAt(0, Ci.nsILocalHandlerApp);
let infoToModify = gMimeSvc.getFromTypeAndExtension("text/x-test-handler", null);
infoToModify.possibleApplicationHandlers.appendElement(handler, false);
infoToModify.possibleApplicationHandlers.appendElement(handler);
gHandlerSvc.store(infoToModify);
}

6
browser/components/preferences/in-content/applications.js
View File

@ -224,7 +224,7 @@ HandlerInfoWrapper.prototype = {
if (possibleApps.getNext().equals(aNewHandler))
return;
}
this.possibleApplicationHandlers.appendElement(aNewHandler, false);
this.possibleApplicationHandlers.appendElement(aNewHandler);
},
removePossibleApplicationHandler(aHandler) {
@ -574,13 +574,13 @@ FeedHandlerInfo.prototype = {
let preferredApp = getLocalHandlerApp(preferredAppFile);
let defaultApp = this._defaultApplicationHandler;
if (!defaultApp || !defaultApp.equals(preferredApp))
this._possibleApplicationHandlers.appendElement(preferredApp, false);
this._possibleApplicationHandlers.appendElement(preferredApp);
}
// Add the registered web handlers. There can be any number of these.
var webHandlers = this._converterSvc.getContentHandlers(this.type);
for (let webHandler of webHandlers)
this._possibleApplicationHandlers.appendElement(webHandler, false);
this._possibleApplicationHandlers.appendElement(webHandler);
return this._possibleApplicationHandlers;
},

2
browser/components/preferences/in-content/tests/browser_bug410900.js
View File

@ -16,7 +16,7 @@ function test() {
var extps = Cc["@mozilla.org/uriloader/external-protocol-service;1"].
getService(Ci.nsIExternalProtocolService);
var info = extps.getProtocolHandlerInfo("apppanetest");
info.possibleApplicationHandlers.appendElement(handler, false);
info.possibleApplicationHandlers.appendElement(handler);
var hserv = Cc["@mozilla.org/uriloader/handler-service;1"].
getService(Ci.nsIHandlerService);

2
browser/components/preferences/in-content/tests/browser_change_app_handler.js
View File

@ -9,7 +9,7 @@ function setupFakeHandler() {
let handler = info.possibleLocalHandlers.queryElementAt(0, Ci.nsILocalHandlerApp);
let infoToModify = gMimeSvc.getFromTypeAndExtension("text/x-test-handler", null);
infoToModify.possibleApplicationHandlers.appendElement(handler, false);
infoToModify.possibleApplicationHandlers.appendElement(handler);
gHandlerSvc.store(infoToModify);
}

2
browser/components/tests/browser/browser_contentpermissionprompt.js
View File

@ -44,7 +44,7 @@ MockContentPermissionType.prototype = {
function MockContentPermissionRequest(typesArray) {
this.types = Cc["@mozilla.org/array;1"].createInstance(Ci.nsIMutableArray);
for (let type of typesArray) {
this.types.appendElement(type, false);
this.types.appendElement(type);
}
}

2
browser/modules/ContentWebRTC.jsm
View File

@ -72,7 +72,7 @@ this.ContentWebRTC = {
let allowedDevices = Cc["@mozilla.org/array;1"]
.createInstance(Ci.nsIMutableArray);
for (let deviceIndex of aMessage.data.devices)
allowedDevices.appendElement(devices[deviceIndex], /* weak =*/ false);
allowedDevices.appendElement(devices[deviceIndex]);
Services.obs.notifyObservers(allowedDevices, "getUserMedia:response:allow", callID);
break;

6
browser/modules/WindowsJumpLists.jsm
View File

@ -279,7 +279,7 @@ this.WinTaskbarJumpList =
return;
var item = this._getHandlerAppItem(task.title, task.description,
task.args, task.iconIndex, null);
items.appendElement(item, false);
items.appendElement(item);
}, this);
if (items.length > 0)
@ -324,7 +324,7 @@ this.WinTaskbarJumpList =
let faviconPageUri = Services.io.newURI(aResult.uri);
let shortcut = this._getHandlerAppItem(title, title, aResult.uri, 1,
faviconPageUri);
items.appendElement(shortcut, false);
items.appendElement(shortcut);
this._frequentHashList.push(aResult.uri);
},
this
@ -369,7 +369,7 @@ this.WinTaskbarJumpList =
let faviconPageUri = Services.io.newURI(aResult.uri);
let shortcut = this._getHandlerAppItem(title, title, aResult.uri, 1,
faviconPageUri);
items.appendElement(shortcut, false);
items.appendElement(shortcut);
count++;
},
this

2
dom/presentation/provider/PresentationControlService.js
View File

@ -375,7 +375,7 @@ function ChannelDescription(aInit) {
let wrapper = Cc["@mozilla.org/supports-cstring;1"]
.createInstance(Ci.nsISupportsCString);
wrapper.data = address;
this._tcpAddresses.appendElement(wrapper, false);
this._tcpAddresses.appendElement(wrapper);
}
this._tcpPort = aInit.tcpPort;

2
dom/presentation/tests/mochitest/PresentationSessionChromeScript.js
View File

@ -51,7 +51,7 @@ const address = Cc["@mozilla.org/supports-cstring;1"]
.createInstance(Ci.nsISupportsCString);
address.data = "127.0.0.1";
const addresses = Cc["@mozilla.org/array;1"].createInstance(Ci.nsIMutableArray);
addresses.appendElement(address, false);
addresses.appendElement(address);
const mockedChannelDescription = {
QueryInterface: XPCOMUtils.generateQI([Ci.nsIPresentationChannelDescription]),

2
dom/presentation/tests/xpcshell/test_presentation_device_manager.js
View File

@ -131,7 +131,7 @@ function filterDevice() {
let presentationUrls = Cc['@mozilla.org/array;1'].createInstance(Ci.nsIMutableArray);
let url = Cc['@mozilla.org/supports-string;1'].createInstance(Ci.nsISupportsString);
url.data = forbiddenRequestedUrl;
presentationUrls.appendElement(url, false);
presentationUrls.appendElement(url);
let devices = manager.getAvailableDevices(presentationUrls);
Assert.equal(devices.length, 0, 'expect 0 available device for example.com');
run_next_test();

2
dom/presentation/tests/xpcshell/test_presentation_session_transport.js
View File

@ -26,7 +26,7 @@ const address = Cc["@mozilla.org/supports-cstring;1"]
.createInstance(Ci.nsISupportsCString);
address.data = "127.0.0.1";
const addresses = Cc["@mozilla.org/array;1"].createInstance(Ci.nsIMutableArray);
addresses.appendElement(address, false);
addresses.appendElement(address);
const serverChannelDescription = {
QueryInterface: XPCOMUtils.generateQI([Ci.nsIPresentationChannelDescription]),

2
dom/presentation/tests/xpcshell/test_tcp_control_channel.js
View File

@ -32,7 +32,7 @@ function TestDescription(aType, aTcpAddress, aTcpPort) {
let wrapper = Cc["@mozilla.org/supports-cstring;1"]
.createInstance(Ci.nsISupportsCString);
wrapper.data = address;
this.tcpAddress.appendElement(wrapper, false);
this.tcpAddress.appendElement(wrapper);
}
this.tcpPort = aTcpPort;
}

2
dom/push/Push.js
View File

@ -190,7 +190,7 @@ Push.prototype = {
QueryInterface: XPCOMUtils.generateQI([Ci.nsIContentPermissionType]),
};
let typeArray = Cc["@mozilla.org/array;1"].createInstance(Ci.nsIMutableArray);
typeArray.appendElement(type, false);
typeArray.appendElement(type);
// create a nsIContentPermissionRequest
let request = {

4
mobile/android/chrome/content/WebrtcUI.js
View File

@ -156,13 +156,13 @@ var WebrtcUI = {
if (inputs && inputs.audioDevice != undefined)
audioId = inputs.audioDevice;
if (audioDevices[audioId])
allowedDevices.appendElement(audioDevices[audioId], /*weak =*/ false);
allowedDevices.appendElement(audioDevices[audioId]);
let videoId = 0;
if (inputs && inputs.videoSource != undefined)
videoId = inputs.videoSource;
if (videoDevices[videoId]) {
allowedDevices.appendElement(videoDevices[videoId], /*weak =*/ false);
allowedDevices.appendElement(videoDevices[videoId]);
let perms = Services.perms;
// Although the lifetime is "session" it will be removed upon
// use so it's more of a one-shot.

2
mobile/android/tests/browser/robocop/testAndroidCastDeviceProvider.js
View File

@ -45,7 +45,7 @@ function TestDescription(aType, aTcpAddress, aTcpPort) {
let wrapper = Cc["@mozilla.org/supports-cstring;1"]
.createInstance(Ci.nsISupportsCString);
wrapper.data = address;
this.tcpAddress.appendElement(wrapper, false);
this.tcpAddress.appendElement(wrapper);
}
this.tcpPort = aTcpPort;
}

2
security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js
View File

@ -31,7 +31,7 @@ var cert;
*/
function openClientAuthDialog(cert) {
let certList = Cc["@mozilla.org/array;1"].createInstance(Ci.nsIMutableArray);
certList.appendElement(cert, false);
certList.appendElement(cert);
let returnVals = Cc["@mozilla.org/hash-property-bag;1"]
.createInstance(Ci.nsIWritablePropertyBag2);

9
toolkit/components/downloads/test/unit/test_app_rep.js
View File

@ -330,12 +330,9 @@ add_test(function test_redirect_on_blocklist() {
let secman = Services.scriptSecurityManager;
let badRedirects = Cc["@mozilla.org/array;1"]
.createInstance(Ci.nsIMutableArray);
badRedirects.appendElement(secman.createCodebasePrincipal(exampleURI, {}),
false);
badRedirects.appendElement(secman.createCodebasePrincipal(blocklistedURI, {}),
false);
badRedirects.appendElement(secman.createCodebasePrincipal(whitelistedURI, {}),
false);
badRedirects.appendElement(secman.createCodebasePrincipal(exampleURI, {}));
badRedirects.appendElement(secman.createCodebasePrincipal(blocklistedURI, {}));
badRedirects.appendElement(secman.createCodebasePrincipal(whitelistedURI, {}));
gAppRep.queryReputation({
sourceURI: whitelistedURI,
referrerURI: exampleURI,

2
toolkit/components/extensions/ext-c-identity.js
View File

@ -67,7 +67,7 @@ function openOAuthWindow(details, redirectURI) {
let supportsStringPrefURL = Cc["@mozilla.org/supports-string;1"]
.createInstance(Ci.nsISupportsString);
supportsStringPrefURL.data = details.url;
args.appendElement(supportsStringPrefURL, /* weak =*/ false);
args.appendElement(supportsStringPrefURL);
let window = Services.ww.openWindow(null,
Services.prefs.getCharPref("browser.chromeURL"),

2
toolkit/components/extensions/ext-protocolHandlers.js
View File

@ -39,7 +39,7 @@ this.protocolHandlers = class extends ExtensionAPI {
handler.uriTemplate = handlerConfig.uriTemplate;
let protoInfo = protocolService.getProtocolHandlerInfo(handlerConfig.protocol);
protoInfo.possibleApplicationHandlers.appendElement(handler, false);
protoInfo.possibleApplicationHandlers.appendElement(handler);
handlerService.store(protoInfo);
}
}

4
toolkit/components/feeds/FeedProcessor.js
View File

@ -505,7 +505,7 @@ Entry.prototype = {
this.enclosures.QueryInterface(Ci.nsIMutableArray);
}
this.enclosures.appendElement(new_enc, false);
this.enclosures.appendElement(new_enc);
this.__enclosure_map[new_enc.getPropertyAsAString("url")] = new_enc;
},
@ -1533,7 +1533,7 @@ FeedProcessor.prototype = {
// off the handle in the browser, and loses track of the interface
// on large files. Bug 335638.
newProp.QueryInterface(Ci.nsIMutableArray);
newProp.appendElement(obj, false);
newProp.appendElement(obj);
// If new object is an nsIFeedContainer, we want to deal with
// its member nsIPropertyBag instead.

2
toolkit/components/passwordmgr/LoginHelper.jsm
View File

@ -703,7 +703,7 @@ this.LoginHelper = {
dataObject = Cc["@mozilla.org/array;1"].
createInstance(Ci.nsIMutableArray);
for (let i = 0; i < data.length; i++) {
dataObject.appendElement(data[i], false);
dataObject.appendElement(data[i]);
}
} else if (typeof(data) == "string") {
dataObject = Cc["@mozilla.org/supports-string;1"].

2
toolkit/components/url-classifier/nsUrlClassifierHashCompleter.js
View File

@ -685,7 +685,7 @@ HashCompleterRequest.prototype = {
req.response.matches.forEach(m => {
matches.appendElement(
new FullHashMatch(m.tableName, m.completeHash, m.cacheDuration), false);
new FullHashMatch(m.tableName, m.completeHash, m.cacheDuration));
});
req.callback.completionV4(req.partialHash, req.tableName,

8
toolkit/mozapps/handling/nsContentDispatchChooser.js
View File

@ -56,11 +56,11 @@ nsContentDispatchChooser.prototype =
for (let text of arr) {
let string = new SupportsString;
string.data = text;
params.appendElement(string, false);
params.appendElement(string);
}
params.appendElement(aHandler, false);
params.appendElement(aURI, false);
params.appendElement(aWindowContext, false);
params.appendElement(aHandler);
params.appendElement(aURI);
params.appendElement(aWindowContext);
var ww = Cc["@mozilla.org/embedcomp/window-watcher;1"].
getService(Ci.nsIWindowWatcher);

2
toolkit/mozapps/update/nsUpdateService.js
View File

@ -4577,7 +4577,7 @@ UpdatePrompt.prototype = {
if (update) {
ary = Cc["@mozilla.org/array;1"].
createInstance(Ci.nsIMutableArray);
ary.appendElement(update, /* weak =*/ false);
ary.appendElement(update);
}
var win = this._getUpdateWindow();

10
uriloader/exthandler/nsHandlerService-json.js
View File

@ -122,7 +122,7 @@ HandlerService.prototype = {
for (let handlerNumber of Object.keys(schemes[scheme])) {
let handlerApp = this.handlerAppFromSerializable(schemes[scheme][handlerNumber]);
if (!this._isInHandlerArray(possibleHandlers, handlerApp)) {
possibleHandlers.appendElement(handlerApp, false);
possibleHandlers.appendElement(handlerApp);
}
}
@ -167,11 +167,11 @@ HandlerService.prototype = {
createInstance(Ci.nsIMutableArray);
for (let type of Object.keys(this._store.data.mimetypes)) {
let handler = gMIMEService.getFromTypeAndExtension(type, null);
handlers.appendElement(handler, false);
handlers.appendElement(handler);
}
for (let type of Object.keys(this._store.data.schemes)) {
let handler = gExternalProtocolService.getProtocolHandlerInfo(type);
handlers.appendElement(handler, false);
handlers.appendElement(handler);
}
return handlers.enumerate();
},
@ -245,7 +245,7 @@ HandlerService.prototype = {
}
handlerInfo.preferredApplicationHandler = preferHandler;
if (preferHandler) {
handlerInfo.possibleApplicationHandlers.appendElement(preferHandler, false);
handlerInfo.possibleApplicationHandlers.appendElement(preferHandler);
}
if (storedHandlerInfo.possibleHandlers) {
@ -253,7 +253,7 @@ HandlerService.prototype = {
let possibleHandler = this.handlerAppFromSerializable(handler);
if (possibleHandler && (!preferHandler ||
!possibleHandler.equals(preferHandler))) {
handlerInfo.possibleApplicationHandlers.appendElement(possibleHandler, false);
handlerInfo.possibleApplicationHandlers.appendElement(possibleHandler);
}
}
}

8
uriloader/exthandler/nsHandlerService.js
View File

@ -267,7 +267,7 @@ HandlerService.prototype = {
handlerApp.name = handlerPrefs.name;
if (!this._isInHandlerArray(possibleHandlers, handlerApp)) {
possibleHandlers.appendElement(handlerApp, false);
possibleHandlers.appendElement(handlerApp);
}
}
@ -515,7 +515,7 @@ HandlerService.prototype = {
// include the preferred handler, so check if it's included as we build
// the list of handlers, and, if it's not included, add it to the list.
if (aPreferredHandler)
aPossibleHandlers.appendElement(aPreferredHandler, false);
aPossibleHandlers.appendElement(aPreferredHandler);
var possibleHandlerTargets = this._getTargets(aInfoID, NC_POSSIBLE_APP);
@ -528,7 +528,7 @@ HandlerService.prototype = {
let possibleHandler = this._retrieveHandlerApp(possibleHandlerID);
if (possibleHandler && (!aPreferredHandler ||
!possibleHandler.equals(aPreferredHandler)))
aPossibleHandlers.appendElement(possibleHandler, false);
aPossibleHandlers.appendElement(possibleHandler);
}
},
@ -1169,7 +1169,7 @@ HandlerService.prototype = {
else
handler = this._protocolSvc.getProtocolHandlerInfo(type);
aHandlers.appendElement(handler, false);
aHandlers.appendElement(handler);
}
},

2
uriloader/exthandler/tests/mochitest/head.js
View File

@ -36,7 +36,7 @@ function createMockedObjects(createHandlerApp) {
if (createHandlerApp) {
let mockedHandlerApp = createMockedHandlerApp();
internalMockedMIME.description = mockedHandlerApp.detailedDescription;
internalMockedMIME.possibleApplicationHandlers.appendElement(mockedHandlerApp, false);
internalMockedMIME.possibleApplicationHandlers.appendElement(mockedHandlerApp);
internalMockedMIME.preferredApplicationHandler = mockedHandlerApp;
}

4
uriloader/exthandler/tests/unit/common_test_handlerService.js
View File

@ -255,8 +255,8 @@ add_task(function* testPreferHandlerIsTheFirstOrder() {
HandlerServiceTestUtils.getBlankHandlerInfo("nonexistent/type2");
handlerInfo2.preferredAction = Ci.nsIHandlerInfo.useHelperApp;
handlerInfo2.preferredApplicationHandler = webHandler;
handlerInfo2.possibleApplicationHandlers.appendElement(localHandler, false);
handlerInfo2.possibleApplicationHandlers.appendElement(webHandler, false);
handlerInfo2.possibleApplicationHandlers.appendElement(localHandler);
handlerInfo2.possibleApplicationHandlers.appendElement(webHandler);
handlerInfo2.alwaysAskBeforeHandling = false;
gHandlerService.store(handlerInfo2);

6
uriloader/exthandler/tests/unit/test_handlerService.js
View File

@ -301,10 +301,8 @@ function run_test() {
// Add two handlers, store the object, re-retrieve it, and make sure it has
// two handlers.
possibleHandlersInfo.possibleApplicationHandlers.appendElement(localHandler,
false);
possibleHandlersInfo.possibleApplicationHandlers.appendElement(webHandler,
false);
possibleHandlersInfo.possibleApplicationHandlers.appendElement(localHandler);
possibleHandlersInfo.possibleApplicationHandlers.appendElement(webHandler);
handlerSvc.store(possibleHandlersInfo);
possibleHandlersInfo =
mimeSvc.getFromTypeAndExtension("nonexistent/possible-handlers", null);

2
widget/tests/unit/test_taskbar_jumplistitems.js
View File

@ -227,7 +227,7 @@ function test_jumplist()
if (notepad.exists()) {
handlerApp.executable = notepad;
sc.app = handlerApp;
items.appendElement(sc, false);
items.appendElement(sc);
var removed = Cc["@mozilla.org/array;1"]
.createInstance(Ci.nsIMutableArray);

6
xpcom/tests/unit/test_nsIMutableArray.js
View File

@ -16,7 +16,7 @@ function create_n_element_array(n)
for (let i=0; i<n; i++) {
let str = new SupportsString();
str.data = "element " + i;
arr.appendElement(str, false);
arr.appendElement(str);
}
return arr;
}
@ -25,7 +25,7 @@ function test_appending_null_actually_inserts()
{
var arr = new MutableArray();
do_check_eq(0, arr.length);
arr.appendElement(null, false);
arr.appendElement(null);
do_check_eq(1, arr.length);
}
@ -34,7 +34,7 @@ function test_object_gets_appended()
var arr = new MutableArray();
var str = new SupportsString();
str.data = "hello";
arr.appendElement(str, false);
arr.appendElement(str);
do_check_eq(1, arr.length);
var obj = arr.queryElementAt(0, Ci.nsISupportsString);
do_check_eq(str, obj);