From 94c95262e2ffd5c2afa8a44f061e7ef134b14373 Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Tue, 19 Nov 2019 19:14:03 +0000 Subject: [PATCH] Bug 1593230 - Retry uploading symbols on 429 too. r=tomprince Differential Revision: https://phabricator.services.mozilla.com/D53715 --HG-- extra : moz-landing-system : lando --- toolkit/crashreporter/tools/upload_symbols.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/toolkit/crashreporter/tools/upload_symbols.py b/toolkit/crashreporter/tools/upload_symbols.py index 98e2e8f52ed5..906acd39eda0 100644 --- a/toolkit/crashreporter/tools/upload_symbols.py +++ b/toolkit/crashreporter/tools/upload_symbols.py @@ -113,9 +113,9 @@ def main(): # in front of symbols.mozilla.org has a 300 second timeout, so we'll use that. timeout=(10, 300), **zip_arg) - # 500 is likely to be a transient failure. + # 429 or any 5XX is likely to be a transient failure. # Break out for success or other error codes. - if r.status_code < 500: + if r.ok or (r.status_code < 500 and r.status_code != 429): break print_error(r) except requests.exceptions.RequestException as e: