Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 15:23:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1372323 - Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups. r=froydnj

Browse Source 
MozReview-Commit-ID: GWsRF1vSLXx
This commit is contained in:
Mats Palmgren 2017-06-14 17:27:25 +02:00
parent 45166146e9
commit 95d8ecc7bf
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
dom/console/Console.cpp
View File

@ -2195,15 +2195,19 @@ Console::IncreaseCounter(JSContext* aCx, const Sequence<JS::Value>& aArguments,
aCountLabel = string;
uint32_t count = 0;
if (!mCounterRegistry.Get(aCountLabel, &count) &&
mCounterRegistry.Count() >= MAX_PAGE_COUNTERS) {
return MAX_PAGE_COUNTERS;
const bool maxCountersReached = mCounterRegistry.Count() >= MAX_PAGE_COUNTERS;
auto entry = mCounterRegistry.LookupForAdd(aCountLabel);
if (entry) {
++entry.Data();
} else {
entry.OrInsert([](){ return 1; });
if (maxCountersReached) {
// oops, we speculatively added an entry even though we shouldn't
mCounterRegistry.Remove(aCountLabel);
return MAX_PAGE_COUNTERS;
}
}
++count;
mCounterRegistry.Put(aCountLabel, count);
return count;
return entry.Data();
}
JS::Value