bug 1392603 - Remove toolkit/crashreporter/tools/win32. r=gsvelto

We have prebuilt dump_syms binaries in toolkit/crashreporter/tools/win32 from
the days when we didn't build it as part of the build. There's one per MSVC
version, since the APIs it uses are version-specific, but we don't actually
support building with the MSVC versions corresponding to the binaries in that
directory anymore, so we should just remove them.

The only code change necessary here is changing the functional test to skip
running the test if a dump_syms binary isn't available.

MozReview-Commit-ID: IBuJZMVfv7C

Differential Revision: https://phabricator.services.mozilla.com/D15717

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Ted Mielczarek 2019-01-04 13:39:39 +00:00
parent 12c357c40f
commit 96349b53f8
4 changed files with 1 additions and 6 deletions

View File

@ -479,12 +479,7 @@ class TestFunctional(HelperMixin, unittest.TestCase):
'dist', 'host', 'bin',
'dump_syms.exe')
else:
self.dump_syms = os.path.join(self.topsrcdir,
'toolkit',
'crashreporter',
'tools',
'win32',
'dump_syms_vc{_MSC_VER}.exe'.format(**buildconfig.substs))
self.skip_test = True
self.target_bin = os.path.join(buildconfig.topobjdir,
'dist', 'bin',
'firefox.exe')