From 963a76c6fc44a590d6daed8af8b058dfd4eb57be Mon Sep 17 00:00:00 2001 From: Simon Giesecke Date: Wed, 4 Mar 2020 13:10:54 +0000 Subject: [PATCH] Bug 1619307 - Fixed assertion in IDBTransaction::Run. r=dom-workers-and-storage-reviewers,janv Differential Revision: https://phabricator.services.mozilla.com/D64984 --HG-- extra : moz-landing-system : lando --- dom/indexedDB/IDBTransaction.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dom/indexedDB/IDBTransaction.cpp b/dom/indexedDB/IDBTransaction.cpp index b74942992252..4437ae7f84d1 100644 --- a/dom/indexedDB/IDBTransaction.cpp +++ b/dom/indexedDB/IDBTransaction.cpp @@ -988,7 +988,10 @@ IDBTransaction::Run() { // abort/commit. if (ReadyState::Finished == mReadyState) { - MOZ_ASSERT(IsAborted()); + // There are three cases where mReadyState is set to Finished: In + // FileCompleteOrAbortEvents, AbortInternal and in CommitIfNotStarted. We + // shouldn't get here after CommitIfNotStarted again. + MOZ_ASSERT(mFiredCompleteOrAbort || IsAborted()); return NS_OK; }