Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-07 18:04:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1287006 - Don't pass Nullable by value in various places, rather by const&. r=bz

Browse Source 
--HG--
extra : rebase_source : cbdd6e33cc69f58983a4b6ce97642caf54ddbc9a
This commit is contained in:
Jeff Walden 2017-02-13 09:07:40 -08:00
parent cdee578059
commit 965f401e22
9 changed files with 47 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dom/bindings/test/TestBindingHeader.h
View File

@ -266,27 +266,27 @@ public:
float WritableUnrestrictedFloat() const;
void SetWritableUnrestrictedFloat(float);
Nullable<float> GetWritableNullableFloat() const;
void SetWritableNullableFloat(Nullable<float>);
void SetWritableNullableFloat(const Nullable<float>&);
Nullable<float> GetWritableNullableUnrestrictedFloat() const;
void SetWritableNullableUnrestrictedFloat(Nullable<float>);
void SetWritableNullableUnrestrictedFloat(const Nullable<float>&);
double WritableDouble() const;
void SetWritableDouble(double);
double WritableUnrestrictedDouble() const;
void SetWritableUnrestrictedDouble(double);
Nullable<double> GetWritableNullableDouble() const;
void SetWritableNullableDouble(Nullable<double>);
void SetWritableNullableDouble(const Nullable<double>&);
Nullable<double> GetWritableNullableUnrestrictedDouble() const;
void SetWritableNullableUnrestrictedDouble(Nullable<double>);
void PassFloat(float, float, Nullable<float>, Nullable<float>,
double, double, Nullable<double>, Nullable<double>,
void SetWritableNullableUnrestrictedDouble(const Nullable<double>&);
void PassFloat(float, float, const Nullable<float>&, const Nullable<float>&,
double, double, const Nullable<double>&, const Nullable<double>&,
const Sequence<float>&, const Sequence<float>&,
const Sequence<Nullable<float> >&,
const Sequence<Nullable<float> >&,
const Sequence<double>&, const Sequence<double>&,
const Sequence<Nullable<double> >&,
const Sequence<Nullable<double> >&);
void PassLenientFloat(float, float, Nullable<float>, Nullable<float>,
double, double, Nullable<double>, Nullable<double>,
void PassLenientFloat(float, float, const Nullable<float>&, const Nullable<float>&,
double, double, const Nullable<double>&, const Nullable<double>&,
const Sequence<float>&, const Sequence<float>&,
const Sequence<Nullable<float> >&,
const Sequence<Nullable<float> >&,

18
dom/events/DeviceMotionEvent.cpp
View File

@ -33,7 +33,7 @@ DeviceMotionEvent::InitDeviceMotionEvent(
const DeviceAccelerationInit& aAcceleration,
const DeviceAccelerationInit& aAccelIncludingGravity,
const DeviceRotationRateInit& aRotationRate,
Nullable<double> aInterval)
const Nullable<double>& aInterval)
{
InitDeviceMotionEvent(aType, aCanBubble, aCancelable, aAcceleration,
aAccelIncludingGravity, aRotationRate, aInterval,
@ -48,8 +48,8 @@ DeviceMotionEvent::InitDeviceMotionEvent(
const DeviceAccelerationInit& aAcceleration,
const DeviceAccelerationInit& aAccelIncludingGravity,
const DeviceRotationRateInit& aRotationRate,
Nullable<double> aInterval,
Nullable<uint64_t> aTimeStamp)
const Nullable<double>& aInterval,
const Nullable<uint64_t>& aTimeStamp)
{
NS_ENSURE_TRUE_VOID(!mEvent->mFlags.mIsBeingDispatched);
@ -115,9 +115,9 @@ NS_IMPL_CYCLE_COLLECTION_ROOT_NATIVE(DeviceAcceleration, AddRef)
NS_IMPL_CYCLE_COLLECTION_UNROOT_NATIVE(DeviceAcceleration, Release)
DeviceAcceleration::DeviceAcceleration(DeviceMotionEvent* aOwner,
Nullable<double> aX,
Nullable<double> aY,
Nullable<double> aZ)
const Nullable<double>& aX,
const Nullable<double>& aY,
const Nullable<double>& aZ)
: mOwner(aOwner)
, mX(aX)
, mY(aY)
@ -139,9 +139,9 @@ NS_IMPL_CYCLE_COLLECTION_ROOT_NATIVE(DeviceRotationRate, AddRef)
NS_IMPL_CYCLE_COLLECTION_UNROOT_NATIVE(DeviceRotationRate, Release)
DeviceRotationRate::DeviceRotationRate(DeviceMotionEvent* aOwner,
Nullable<double> aAlpha,
Nullable<double> aBeta,
Nullable<double> aGamma)
const Nullable<double>& aAlpha,
const Nullable<double>& aBeta,
const Nullable<double>& aGamma)
: mOwner(aOwner)
, mAlpha(aAlpha)
, mBeta(aBeta)

16
dom/events/DeviceMotionEvent.h
View File

@ -21,8 +21,9 @@ public:
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS(DeviceRotationRate)
DeviceRotationRate(DeviceMotionEvent* aOwner,
Nullable<double> aAlpha, Nullable<double> aBeta,
Nullable<double> aGamma);
const Nullable<double>& aAlpha,
const Nullable<double>& aBeta,
const Nullable<double>& aGamma);
DeviceMotionEvent* GetParentObject() const
{
@ -53,8 +54,9 @@ public:
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS(DeviceAcceleration)
DeviceAcceleration(DeviceMotionEvent* aOwner,
Nullable<double> aX, Nullable<double> aY,
Nullable<double> aZ);
const Nullable<double>& aX,
const Nullable<double>& aY,
const Nullable<double>& aZ);
DeviceMotionEvent* GetParentObject() const
{
@ -128,7 +130,7 @@ public:
const DeviceAccelerationInit& aAcceleration,
const DeviceAccelerationInit& aAccelerationIncludingGravity,
const DeviceRotationRateInit& aRotationRate,
Nullable<double> aInterval);
const Nullable<double>& aInterval);
void InitDeviceMotionEvent(
const nsAString& aType,
@ -137,8 +139,8 @@ public:
const DeviceAccelerationInit& aAcceleration,
const DeviceAccelerationInit& aAccelerationIncludingGravity,
const DeviceRotationRateInit& aRotationRate,
Nullable<double> aInterval,
Nullable<uint64_t> aTimeStamp);
const Nullable<double>& aInterval,
const Nullable<uint64_t>& aTimeStamp);
static already_AddRefed<DeviceMotionEvent>
Constructor(const GlobalObject& aGlobal,

2
dom/html/HTMLInputElement.cpp
View File

@ -2332,7 +2332,7 @@ HTMLInputElement::GetValueAsDate(ErrorResult& aRv)
}
void
HTMLInputElement::SetValueAsDate(Nullable<Date> aDate, ErrorResult& aRv)
HTMLInputElement::SetValueAsDate(const Nullable<Date>& aDate, ErrorResult& aRv)
{
if (!IsDateTimeInputType(mType)) {
aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR);

2
dom/html/HTMLInputElement.h
View File

@ -669,7 +669,7 @@ public:
Nullable<Date> GetValueAsDate(ErrorResult& aRv);
void SetValueAsDate(Nullable<Date>, ErrorResult& aRv);
void SetValueAsDate(const Nullable<Date>& aDate, ErrorResult& aRv);
double ValueAsNumber() const
{

2
dom/indexedDB/IDBEvents.cpp
View File

@ -52,7 +52,7 @@ already_AddRefed<IDBVersionChangeEvent>
IDBVersionChangeEvent::CreateInternal(EventTarget* aOwner,
const nsAString& aType,
uint64_t aOldVersion,
Nullable<uint64_t> aNewVersion)
const Nullable<uint64_t>& aNewVersion)
{
RefPtr<IDBVersionChangeEvent> event =
new IDBVersionChangeEvent(aOwner, aOldVersion);

2
dom/indexedDB/IDBEvents.h
View File

@ -123,7 +123,7 @@ private:
CreateInternal(EventTarget* aOwner,
const nsAString& aName,
uint64_t aOldVersion,
Nullable<uint64_t> aNewVersion);
const Nullable<uint64_t>& aNewVersion);
};
NS_DEFINE_STATIC_IID_ACCESSOR(IDBVersionChangeEvent, IDBVERSIONCHANGEEVENT_IID)

24
dom/quota/ActorsParent.cpp
View File

@ -259,11 +259,11 @@ class DirectoryLockImpl final
public:
DirectoryLockImpl(QuotaManager* aQuotaManager,
Nullable<PersistenceType> aPersistenceType,
const Nullable<PersistenceType>& aPersistenceType,
const nsACString& aGroup,
const OriginScope& aOriginScope,
Nullable<bool> aIsApp,
Nullable<Client::Type> aClientType,
const Nullable<bool>& aIsApp,
const Nullable<Client::Type>& aClientType,
bool aExclusive,
bool aInternal,
OpenDirectoryListener* aOpenListener);
@ -920,7 +920,7 @@ public:
}
protected:
NormalOriginOperationBase(Nullable<PersistenceType> aPersistenceType,
NormalOriginOperationBase(const Nullable<PersistenceType>& aPersistenceType,
const OriginScope& aOriginScope,
bool aExclusive)
: mPersistenceType(aPersistenceType)
@ -2116,11 +2116,11 @@ DeallocPQuotaParent(PQuotaParent* aActor)
******************************************************************************/
DirectoryLockImpl::DirectoryLockImpl(QuotaManager* aQuotaManager,
Nullable<PersistenceType> aPersistenceType,
const Nullable<PersistenceType>& aPersistenceType,
const nsACString& aGroup,
const OriginScope& aOriginScope,
Nullable<bool> aIsApp,
Nullable<Client::Type> aClientType,
const Nullable<bool>& aIsApp,
const Nullable<Client::Type>& aClientType,
bool aExclusive,
bool aInternal,
OpenDirectoryListener* aOpenListener)
@ -2808,11 +2808,11 @@ QuotaManager::IsShuttingDown()
}
auto
QuotaManager::CreateDirectoryLock(Nullable<PersistenceType> aPersistenceType,
QuotaManager::CreateDirectoryLock(const Nullable<PersistenceType>& aPersistenceType,
const nsACString& aGroup,
const OriginScope& aOriginScope,
Nullable<bool> aIsApp,
Nullable<Client::Type> aClientType,
const Nullable<bool>& aIsApp,
const Nullable<Client::Type>& aClientType,
bool aExclusive,
bool aInternal,
OpenDirectoryListener* aOpenListener)
@ -4422,9 +4422,9 @@ QuotaManager::OpenDirectory(PersistenceType aPersistenceType,
}
void
QuotaManager::OpenDirectoryInternal(Nullable<PersistenceType> aPersistenceType,
QuotaManager::OpenDirectoryInternal(const Nullable<PersistenceType>& aPersistenceType,
const OriginScope& aOriginScope,
Nullable<Client::Type> aClientType,
const Nullable<Client::Type>& aClientType,
bool aExclusive,
OpenDirectoryListener* aOpenListener)
{

10
dom/quota/QuotaManager.h
View File

@ -252,9 +252,9 @@ public:
// XXX RemoveMe once bug 1170279 gets fixed.
void
OpenDirectoryInternal(Nullable<PersistenceType> aPersistenceType,
OpenDirectoryInternal(const Nullable<PersistenceType>& aPersistenceType,
const OriginScope& aOriginScope,
Nullable<Client::Type> aClientType,
const Nullable<Client::Type>& aClientType,
bool aExclusive,
OpenDirectoryListener* aOpenListener);
@ -407,11 +407,11 @@ private:
Shutdown();
already_AddRefed<DirectoryLockImpl>
CreateDirectoryLock(Nullable<PersistenceType> aPersistenceType,
CreateDirectoryLock(const Nullable<PersistenceType>& aPersistenceType,
const nsACString& aGroup,
const OriginScope& aOriginScope,
Nullable<bool> aIsApp,
Nullable<Client::Type> aClientType,
const Nullable<bool>& aIsApp,
const Nullable<Client::Type>& aClientType,
bool aExclusive,
bool aInternal,
OpenDirectoryListener* aOpenListener);