Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 19:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1812028 - Do not show the website's name in the DoH error UI title (fallback page) r=acreskey,fluent-reviewers,flod

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D170669
This commit is contained in:
Valentin Gosu 2023-02-23 14:01:19 +00:00
parent 1399552a17
commit 96cee35462
3 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser/base/content/test/about/browser_aboutNetError_native_fallback.js
View File

@ -68,12 +68,12 @@ async function verifyError(url, fallbackWarning, testName) {
if (args.fallbackWarning) {
is(
actualDataL10nID,
"dns-not-found-native-fallback-title",
"dns-not-found-native-fallback-title2",
"Correct fallback warning error page title is set: " + args.testName
);
} else {
ok(
actualDataL10nID != "dns-not-found-native-fallback-title",
actualDataL10nID != "dns-not-found-native-fallback-title2",
"Should not show fallback warning: " + args.testName
);
}

12
toolkit/content/aboutNetError.mjs
View File

@ -505,15 +505,11 @@ function showNativeFallbackWarning() {
let bodyTitleId = gErrorCode + "-title";
document.body.className = "certerror"; // Shows warning icon
pageTitleId = "dns-not-found-native-fallback-title";
document.l10n.setAttributes(docTitle, pageTitleId, {
hostname: HOST_NAME,
});
pageTitleId = "dns-not-found-native-fallback-title2";
document.l10n.setAttributes(docTitle, pageTitleId);
bodyTitleId = "dns-not-found-native-fallback-title";
document.l10n.setAttributes(bodyTitle, bodyTitleId, {
hostname: HOST_NAME,
});
bodyTitleId = "dns-not-found-native-fallback-title2";
document.l10n.setAttributes(bodyTitle, bodyTitleId);
shortDesc.textContent = "";
let nativeFallbackIgnoreButton = document.getElementById(

8
toolkit/locales/en-US/toolkit/neterror/certError.ftl
View File

@ -106,14 +106,10 @@ deniedPortAccess-title = This address is restricted
# You don't have to include it in your translation if your language does not have a written word like this.
dnsNotFound-title = Hmm. We’re having trouble finding that site.
# Variables:
dns-not-found-trr-only-title2 =
Possible security risk looking up this domain
# Variables:
# $hostname (string) - Hostname of the website to which the user was trying to connect.
dns-not-found-native-fallback-title =
Possible security risk for { $hostname }.
dns-not-found-native-fallback-title2 =
Possible security risk looking up this domain
fileNotFound-title = File not found
fileAccessDenied-title = Access to the file was denied