diff --git a/image/src/RasterImage.cpp b/image/src/RasterImage.cpp index 31a93d3b2a40..f62233d7db5c 100644 --- a/image/src/RasterImage.cpp +++ b/image/src/RasterImage.cpp @@ -234,8 +234,8 @@ RasterImage::RasterImage(imgStatusTracker* aStatusTracker) : mInDecoder(false), mAnimationFinished(false), mFinishing(false), - mInUpdateImageContainer(false), - mScaleRequest(this) + mScaleRequest(this), + mInUpdateImageContainer(false) { // Set up the discard tracker node. mDiscardTrackerNode.img = this; @@ -2714,10 +2714,6 @@ RasterImage::ScaleWorker::RequestScale(RasterImage* aImg) if (request->isInList()) return; - // While the request is outstanding, we hold a reference to it so it won't be - // deleted from under us (and, since it owns us, so we won't be deleted). - request->kungFuDeathGrip = request->image; - mScaleRequests.insertBack(request); if (!sScaleWorkerThread) { @@ -2762,11 +2758,6 @@ RasterImage::DrawWorker::Run() nsIntRect frameRect = request->srcFrame->GetRect(); observer->FrameChanged(nullptr, request->image, &frameRect); } - if (request->done) { - // We are now done with this image, so we can release our reference. - // THIS CAN DELETE THE REQUEST! - request->kungFuDeathGrip = nullptr; - } } return NS_OK; diff --git a/image/src/RasterImage.h b/image/src/RasterImage.h index 891f888b7227..0d2c7dece6d9 100644 --- a/image/src/RasterImage.h +++ b/image/src/RasterImage.h @@ -511,7 +511,6 @@ private: static void Stop(RasterImage* aImg); RasterImage* const image; - nsRefPtr kungFuDeathGrip; imgFrame *srcFrame; nsAutoPtr dstFrame; gfxSize scale; diff --git a/toolkit/components/downloads/nsDownloadManager.h b/toolkit/components/downloads/nsDownloadManager.h index ec2f1d2c9df6..3ff3bb745356 100644 --- a/toolkit/components/downloads/nsDownloadManager.h +++ b/toolkit/components/downloads/nsDownloadManager.h @@ -382,7 +382,6 @@ private: nsCOMPtr mMIMEInfo; DownloadState mDownloadState; - DownloadType mDownloadType; uint32_t mID; int32_t mPercentComplete; diff --git a/toolkit/components/places/Database.cpp b/toolkit/components/places/Database.cpp index 208b25811955..64e3413ce424 100644 --- a/toolkit/components/places/Database.cpp +++ b/toolkit/components/places/Database.cpp @@ -340,7 +340,6 @@ Database::Database() , mMainThreadAsyncStatements(mMainConn) , mAsyncThreadStatements(mMainConn) , mDBPageSize(0) - , mCurrentJournalMode(JOURNAL_DELETE) , mDatabaseStatus(nsINavHistoryService::DATABASE_STATUS_OK) , mShuttingDown(false) { diff --git a/toolkit/components/places/Database.h b/toolkit/components/places/Database.h index 9ffe3f0f16bd..37b268bb0cde 100644 --- a/toolkit/components/places/Database.h +++ b/toolkit/components/places/Database.h @@ -295,7 +295,6 @@ private: mutable StatementCache mAsyncThreadStatements; int32_t mDBPageSize; - enum JournalMode mCurrentJournalMode; uint16_t mDatabaseStatus; bool mShuttingDown; };