Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-07 07:04:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix appending to nsSharableString by always null-terminating in SetLength. b=113188 r=jag sr=jst

Browse Source
This commit is contained in:
dbaron%fas.harvard.edu 2001-12-08 22:50:34 +00:00
parent f7b755c4e0
commit 986705d7d8
2 changed files with 36 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
string/src/nsSharableString.cpp
View File

@ -108,12 +108,16 @@ nsSharableString::SetLength( size_type aNewLength )
else
{
mBuffer->DataEnd( mBuffer->DataStart() + aNewLength );
*mBuffer->DataEnd() = char_type(0); // This is needed for |Truncate|
// callers but perhaps not
// for callers that are
// manipulating the
// internals of the string.
}
// This is needed for |Truncate| callers and also for some callers
// (such as nsAString::do_AppendFromReadable) that are manipulating
// the internals of the string. It also makes sense to do this
// since this class implements |nsAFlatString|, so the buffer must
// always be null-terminated at its length. Callers using writing
// iterators can't be expected to null-terminate themselves since
// they don't know if they're dealing with a string that has a
// buffer big enough for null-termination.
*mBuffer->DataEnd() = char_type(0);
}
void
@ -253,12 +257,16 @@ nsSharableCString::SetLength( size_type aNewLength )
else
{
mBuffer->DataEnd( mBuffer->DataStart() + aNewLength );
*mBuffer->DataEnd() = char_type(0); // This is needed for |Truncate|
// callers but perhaps not
// for callers that are
// manipulating the
// internals of the string.
}
// This is needed for |Truncate| callers and also for some callers
// (such as nsACString::do_AppendFromReadable) that are manipulating
// the internals of the string. It also makes sense to do this
// since this class implements |nsAFlatString|, so the buffer must
// always be null-terminated at its length. Callers using writing
// iterators can't be expected to null-terminate themselves since
// they don't know if they're dealing with a string that has a
// buffer big enough for null-termination.
*mBuffer->DataEnd() = char_type(0);
}
void

28
xpcom/string/src/nsSharableString.cpp
View File

@ -108,12 +108,16 @@ nsSharableString::SetLength( size_type aNewLength )
else
{
mBuffer->DataEnd( mBuffer->DataStart() + aNewLength );
*mBuffer->DataEnd() = char_type(0); // This is needed for |Truncate|
// callers but perhaps not
// for callers that are
// manipulating the
// internals of the string.
}
// This is needed for |Truncate| callers and also for some callers
// (such as nsAString::do_AppendFromReadable) that are manipulating
// the internals of the string. It also makes sense to do this
// since this class implements |nsAFlatString|, so the buffer must
// always be null-terminated at its length. Callers using writing
// iterators can't be expected to null-terminate themselves since
// they don't know if they're dealing with a string that has a
// buffer big enough for null-termination.
*mBuffer->DataEnd() = char_type(0);
}
void
@ -253,12 +257,16 @@ nsSharableCString::SetLength( size_type aNewLength )
else
{
mBuffer->DataEnd( mBuffer->DataStart() + aNewLength );
*mBuffer->DataEnd() = char_type(0); // This is needed for |Truncate|
// callers but perhaps not
// for callers that are
// manipulating the
// internals of the string.
}
// This is needed for |Truncate| callers and also for some callers
// (such as nsACString::do_AppendFromReadable) that are manipulating
// the internals of the string. It also makes sense to do this
// since this class implements |nsAFlatString|, so the buffer must
// always be null-terminated at its length. Callers using writing
// iterators can't be expected to null-terminate themselves since
// they don't know if they're dealing with a string that has a
// buffer big enough for null-termination.
*mBuffer->DataEnd() = char_type(0);
}
void