Backed out changeset 283c5335d006 (bug 1589826) for causing browser chrome failures. CLOSED TREE

This commit is contained in:
Cosmin Sabou 2019-11-05 16:24:45 +02:00
parent fc0c278134
commit 98797835bb
5 changed files with 19 additions and 14 deletions

View File

@ -302,6 +302,7 @@ class UrlbarController {
this.view.close();
} else {
this.input.handleRevert();
this.input.endLayoutExtend(true);
}
}
event.preventDefault();

View File

@ -1009,11 +1009,11 @@ class UrlbarInput {
}
}
endLayoutExtend() {
endLayoutExtend(force) {
if (
!this.hasAttribute("breakout-extend") ||
this.view.isOpen ||
this.getAttribute("focused") == "true"
(!force && this.getAttribute("focused") == "true")
) {
return;
}
@ -1746,11 +1746,10 @@ class UrlbarInput {
// We handle mouse-based expansion events separately in _on_click.
if (this._focusedViaMousedown) {
this._focusedViaMousedown = false;
} else if (this.inputField.hasAttribute("refocused-by-panel")) {
this._maybeSelectAll(true);
} else {
this.startLayoutExtend();
if (this.inputField.hasAttribute("refocused-by-panel")) {
this._maybeSelectAll(true);
}
}
this._updateUrlTooltip();
@ -1835,6 +1834,17 @@ class UrlbarInput {
if (!UrlbarPrefs.get("ui.popup.disable_autohide")) {
this.view.close();
}
if (
event.target.id == "tabs-newtab-button" ||
event.target.id == "new-tab-button" ||
event.target.classList.contains("tab-close-button")
) {
break;
}
// We collapse the urlbar for any clicks outside of it.
this.endLayoutExtend(true);
}
}

View File

@ -377,9 +377,7 @@ notification[value="translation"] menulist > .menulist-dropmarker {
.tab-drop-indicator {
list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator.png);
margin-bottom: -9px;
/* The z-index needs to be big enough to trump other positioned UI pieces
that we want to overlay. The expanded urlbar uses 3. */
z-index: 4;
z-index: 3;
}
/* All tabs menupopup */

View File

@ -612,9 +612,7 @@
.tab-drop-indicator {
list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator.png);
margin-top: -2px;
/* The z-index needs to be big enough to trump other positioned UI pieces
that we want to overlay. The expanded urlbar uses 3. */
z-index: 4;
z-index: 3;
}
@media (min-resolution: 2dppx) {

View File

@ -607,9 +607,7 @@ menuitem.bookmark-item {
.tab-drop-indicator {
list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator.png);
margin-bottom: -9px;
/* The z-index needs to be big enough to trump other positioned UI pieces
that we want to overlay. The expanded urlbar uses 3. */
z-index: 4;
z-index: 3;
}
/* All tabs menupopup */