Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-14 10:43:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix for 86501 - bookmarks truncated when disk full

Browse Source 
Make bookmarks check on the success of the file stream write before overwriting the old bookmarks file with the new one.
r=darin, sr=brendan
This commit is contained in:
ben%netscape.com 2002-06-26 05:18:41 +00:00
parent f47565520b
commit 98ddcdddfa
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
xpfe/components/bookmarks/src/nsBookmarksService.cpp
View File

@ -5021,6 +5021,8 @@ nsBookmarksService::WriteBookmarks(nsFileSpec* aBookmarksFile, nsIRDFDataSource*
nsFileSpec tempFile(*aBookmarksFile);
tempFile.MakeUnique();
PRBool succeeded = PR_TRUE;
// Scope the stream so that it closes when we're done with it.
{
nsOutputFileStream strm(tempFile);
@ -5042,13 +5044,13 @@ nsBookmarksService::WriteBookmarks(nsFileSpec* aBookmarksFile, nsIRDFDataSource*
// If WriteBookmarksContainer failed for some reason, return that value.
// Otherwise, report the status of the stream operation.
rv = NS_FAILED(rv) ? rv : strm.error();
succeeded = NS_FAILED(rv) ? PR_FALSE : NS_SUCCEEDED(strm.lastWriteStatus());
}
// If we wrote to the file successfully (i.e. if the disk wasn't full)
// then trash the old bookmarks file and rename the temp file so it takes
// its place.
if (NS_SUCCEEDED(rv)) {
if (succeeded) {
char* bookmarksFileName = aBookmarksFile->GetLeafName();
aBookmarksFile->Delete(PR_FALSE);